Bug 165850 - Add implementation for navigator.requestMediaKeySystemAccess()
Summary: Add implementation for navigator.requestMediaKeySystemAccess()
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Media (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Jer Noble
URL:
Keywords: InRadar
: 158837 (view as bug list)
Depends on: 165972 165823
Blocks: 158836
  Show dependency tree / graph
 
Reported: 2016-12-14 08:25 PST by Jer Noble
Modified: 2018-07-23 08:11 PDT (History)
8 users (show)

See Also:

Attachments
Patch (22.26 KB, patch)
2016-12-14 08:30 PST, Jer Noble 		no flags Details | Formatted Diff | Diff
Patch (122.39 KB, patch)
2016-12-16 14:56 PST, Jer Noble 		no flags Details | Formatted Diff | Diff
Patch (124.53 KB, patch)
2016-12-16 15:06 PST, Jer Noble 		eric.carlson: review+
Details | Formatted Diff | Diff
Patch for landing (124.49 KB, patch)
2016-12-16 23:31 PST, Jer Noble 		no flags Details | Formatted Diff | Diff
Patch for landing (124.40 KB, patch)
2016-12-16 23:53 PST, Jer Noble 		no flags Details | Formatted Diff | Diff
Archive of layout-test-results from ews114 for mac-yosemite (1.66 MB, application/zip)
2016-12-17 01:07 PST, Build Bot 		no flags Details
Show Obsolete (3) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Jer Noble 2016-12-14 08:25:16 PST 
Add implementation for navigator.requestMediaKeySystemAccess()
Comment 1 Jer Noble 2016-12-14 08:30:45 PST 
Created attachment 297091 [details]
Patch
Comment 2 Jer Noble 2016-12-16 14:56:38 PST 
Created attachment 297360 [details]
Patch
Comment 3 Jer Noble 2016-12-16 15:06:35 PST 
Created attachment 297362 [details]
Patch
Comment 4 Radar WebKit Bug Importer 2016-12-16 15:07:18 PST 
<rdar://problem/29714167>
Comment 5 Eric Carlson 2016-12-16 15:34:17 PST 
Comment on attachment 297362 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=297362&action=review

r=me once the bots are happy

> LayoutTests/media/encrypted-media/mock-navigator-requestMediaKeySystemAccess.html:63
> +        run('promise  = navigator.requestMediaKeySystemAccess("org.webkit.mock", capabilities)');

Nit: extra space here.
Comment 6 Jer Noble 2016-12-16 16:31:01 PST 
Looks like an extra reference to JSPositionOptions.cpp snuck in during a rebase.
Comment 7 Jer Noble 2016-12-16 23:31:29 PST 
Created attachment 297394 [details]
Patch for landing
Comment 8 Jer Noble 2016-12-16 23:53:41 PST 
Created attachment 297396 [details]
Patch for landing
Comment 9 Build Bot 2016-12-17 01:07:55 PST 
Comment on attachment 297396 [details]
Patch for landing

Attachment 297396 [details] did not pass mac-debug-ews (mac):
Output: http://webkit-queues.webkit.org/results/2742417

New failing tests:
http/tests/fetch/fetching-same-resource-with-diffferent-options.html
Comment 10 Build Bot 2016-12-17 01:07:58 PST 
Created attachment 297400 [details]
Archive of layout-test-results from ews114 for mac-yosemite

The attached test failures were seen while running run-webkit-tests on the mac-debug-ews.
Bot: ews114  Port: mac-yosemite  Platform: Mac OS X 10.10.5
Comment 11 Jer Noble 2016-12-17 08:54:30 PST 
Comment on attachment 297396 [details]
Patch for landing

Ignoring the commit-bot; this feature is not enabled on mac.
Comment 12 WebKit Commit Bot 2016-12-17 09:19:34 PST 
Comment on attachment 297396 [details]
Patch for landing

Clearing flags on attachment: 297396

Committed r209964: <http://trac.webkit.org/changeset/209964>
Comment 13 Zan Dobersek 2016-12-18 11:05:16 PST 
*** Bug 158837 has been marked as a duplicate of this bug. ***
Comment 14 Charlie Turner 2018-07-23 08:11:43 PDT 
This has been completed. Closing.