Bug 165823 - Move existing CDM* implementations into modules/encryptedmedia/legacy
Summary: Move existing CDM* implementations into modules/encryptedmedia/legacy
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Jer Noble
Depends on:
Blocks: 165850
  Show dependency treegraph
Reported: 2016-12-13 15:07 PST by Jer Noble
Modified: 2016-12-16 13:53 PST (History)
1 user (show)

See Also:

Patch for landing (44.56 KB, patch)
2016-12-13 15:12 PST, Jer Noble
sam: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Jer Noble 2016-12-13 15:07:27 PST
Move existing CDM* implementations into modules/encryptedmedia/legacy
Comment 1 Jer Noble 2016-12-13 15:12:04 PST
Created attachment 297044 [details]
Patch for landing
Comment 2 WebKit Commit Bot 2016-12-13 15:14:59 PST
Attachment 297044 [details] did not pass style-queue:

ERROR: Source/WebCore/Modules/encryptedmedia/legacy/LegacyCDMPrivateMediaPlayer.cpp:32:  Alphabetical sorting problem.  [build/include_order] [4]
ERROR: Source/WebCore/Modules/encryptedmedia/legacy/WebKitMediaKeySession.h:31:  Alphabetical sorting problem.  [build/include_order] [4]
ERROR: Source/WebCore/platform/graphics/LegacyCDMSession.h:26:  Use #pragma once instead of #ifndef for header guard.  [build/header_guard] [5]
ERROR: Source/WebCore/platform/graphics/MediaPlayer.h:33:  Alphabetical sorting problem.  [build/include_order] [4]
ERROR: Source/WebCore/Modules/encryptedmedia/legacy/LegacyCDMPrivateClearKey.cpp:32:  Alphabetical sorting problem.  [build/include_order] [4]
ERROR: Source/WebCore/Modules/encryptedmedia/legacy/WebKitMediaKeys.h:30:  Alphabetical sorting problem.  [build/include_order] [4]
ERROR: Source/WebCore/Modules/encryptedmedia/legacy/LegacyCDM.cpp:30:  You should not add a blank line before implementation file's own header.  [build/include_order] [4]
ERROR: Source/WebCore/platform/graphics/avfoundation/objc/CDMSessionAVStreamSession.mm:32:  Alphabetical sorting problem.  [build/include_order] [4]
ERROR: Source/WebCore/platform/graphics/avfoundation/objc/CDMSessionAVContentKeySession.mm:31:  Alphabetical sorting problem.  [build/include_order] [4]
Total errors found: 9 in 25 files

If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 3 Sam Weinig 2016-12-14 13:57:26 PST
Comment on attachment 297044 [details]
Patch for landing

Comment 4 Jer Noble 2016-12-16 13:53:25 PST
Committed r209936: <http://trac.webkit.org/changeset/209936>