Bug 165972 - Add a WebKit preference to control the RuntimeEnabledFeature encryptedMediaAPIEnabled.
Summary: Add a WebKit preference to control the RuntimeEnabledFeature encryptedMediaAP...
Status: ASSIGNED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Media (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Jer Noble
URL:
Keywords:
Depends on:
Blocks: 165850
  Show dependency tree / graph
 
Reported: 2016-12-16 14:35 PST by Jer Noble
Modified: 2017-01-24 13:11 PST (History)
2 users (show)

See Also:

Attachments
Patch (5.19 KB, patch)
2016-12-16 14:37 PST, Jer Noble 		eric.carlson: review+
commit-queue: commit-queue-
Details | Formatted Diff | Diff
Archive of layout-test-results from ews117 for mac-yosemite (1.67 MB, application/zip)
2016-12-16 16:29 PST, Build Bot 		no flags Details
Patch for landing (5.41 KB, patch)
2017-01-24 13:11 PST, Jer Noble 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Jer Noble 2016-12-16 14:35:45 PST 
Add a WebKit preference to control the RuntimeEnabledFeature encryptedMediaAPIEnabled.
Comment 1 Jer Noble 2016-12-16 14:37:54 PST 
Created attachment 297356 [details]
Patch
Comment 2 Eric Carlson 2016-12-16 15:38:37 PST 
Comment on attachment 297356 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=297356&action=review

> Tools/ChangeLog:9
> +        * DumpRenderTree/mac/DumpRenderTree.mm:
> +        (resetWebPreferencesToConsistentValues):

Don't you also want to enable the feature in WTR?
Comment 3 Build Bot 2016-12-16 16:29:38 PST 
Comment on attachment 297356 [details]
Patch

Attachment 297356 [details] did not pass mac-debug-ews (mac):
Output: http://webkit-queues.webkit.org/results/2739884

New failing tests:
http/tests/navigation/keyboard-events-during-provisional-navigation.html
Comment 4 Build Bot 2016-12-16 16:29:41 PST 
Created attachment 297373 [details]
Archive of layout-test-results from ews117 for mac-yosemite

The attached test failures were seen while running run-webkit-tests on the mac-debug-ews.
Bot: ews117  Port: mac-yosemite  Platform: Mac OS X 10.10.5
Comment 5 Jer Noble 2016-12-16 19:51:22 PST 
(In reply to comment #2)
> Comment on attachment 297356 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=297356&action=review
> 
> > Tools/ChangeLog:9
> > +        * DumpRenderTree/mac/DumpRenderTree.mm:
> > +        (resetWebPreferencesToConsistentValues):
> 
> Don't you also want to enable the feature in WTR?

Amazingly, it already is in WKTR.
Comment 6 WebKit Commit Bot 2017-01-24 11:32:46 PST 
Comment on attachment 297356 [details]
Patch

Rejecting attachment 297356 [details] from commit-queue.

Failed to run "['/Volumes/Data/EWS/WebKit/Tools/Scripts/webkit-patch', '--status-host=webkit-queues.webkit.org', '--bot-id=webkit-cq-02', 'apply-attachment', '--no-update', '--non-interactive', 297356, '--port=mac']" exit_code: 2 cwd: /Volumes/Data/EWS/WebKit

Last 500 characters of output:
nes).
patching file Source/WebKit/mac/WebView/WebView.mm
Hunk #1 succeeded at 2898 (offset 21 lines).
patching file Tools/ChangeLog
Hunk #1 succeeded at 1 with fuzz 3.
patching file Tools/DumpRenderTree/mac/DumpRenderTree.mm
Hunk #1 FAILED at 999.
1 out of 1 hunk FAILED -- saving rejects to file Tools/DumpRenderTree/mac/DumpRenderTree.mm.rej

Failed to run "[u'/Volumes/Data/EWS/WebKit/Tools/Scripts/svn-apply', '--force', '--reviewer', u'Eric Carlson']" exit_code: 1 cwd: /Volumes/Data/EWS/WebKit

Full output: http://webkit-queues.webkit.org/results/2942072
Comment 7 Jer Noble 2017-01-24 13:11:39 PST 
Created attachment 299622 [details]
Patch for landing