Convert contributors.json to a flat list
Created attachment 291050 [details] Patch
Attachment 291050 [details] did not pass style-queue: ERROR: Tools/Scripts/webkitpy/common/config/contributors.json:0: contributors.json should not be modified through the commit queue [json/syntax] [5] Total errors found: 1 in 6 files If any of these errors are false positives, please file a bug against check-webkit-style.
Any reason it shouldn't just be the highest level of capability per person? No reviewer doesn't also have commit.
Yeah it could be.
Should there be a Bugzilla change too here? This file is used for email address auto-complete.
Created attachment 291052 [details] Patch
Alexey, will the bugzilla script changes be picked up automatically?
Attachment 291052 [details] did not pass style-queue: ERROR: Tools/Scripts/webkitpy/common/config/contributors.json:0: contributors.json should not be modified through the commit queue [json/syntax] [5] Total errors found: 1 in 8 files If any of these errors are false positives, please file a bug against check-webkit-style.
> Alexey, will the bugzilla script changes be picked up automatically? It's been a long time since we made changes to bugzilla, so any auto-update mechanism may have fallen apart. CC'ing David, who should be able to update it manually if needed.
https://trac.webkit.org/changeset/206973
Bugzilla seems to have updated immediately. webkit.org/team not yet updated.
webkit.org/team is working now.
r206973 broke `webkit-patch suggest-reviewers` and `webkit-patch upload --suggest-reviewers`: % webkit-patch suggest-reviewers Traceback (most recent call last): File "/Users/andy/Code/OpenSource/Tools/Scripts/webkit-patch", line 84, in <module> main() File "/Users/andy/Code/OpenSource/Tools/Scripts/webkit-patch", line 79, in main WebKitPatch(os.path.abspath(__file__)).main() File "/Users/andy/Code/OpenSource/Tools/Scripts/webkitpy/tool/multicommandtool.py", line 305, in main result = command.check_arguments_and_execute(options, args, self) File "/Users/andy/Code/OpenSource/Tools/Scripts/webkitpy/tool/multicommandtool.py", line 123, in check_arguments_and_execute return self.execute(options, args, tool) or 0 File "/Users/andy/Code/OpenSource/Tools/Scripts/webkitpy/tool/commands/abstractsequencedcommand.py", line 55, in execute self._sequence.run_and_handle_errors(tool, options, state) File "/Users/andy/Code/OpenSource/Tools/Scripts/webkitpy/tool/commands/stepsequence.py", line 73, in run_and_handle_errors self._run(tool, options, state) File "/Users/andy/Code/OpenSource/Tools/Scripts/webkitpy/tool/commands/stepsequence.py", line 67, in _run step(tool, options).run(state) File "/Users/andy/Code/OpenSource/Tools/Scripts/webkitpy/tool/steps/suggestreviewers.py", line 45, in run reviewers = self._tool.checkout().suggested_reviewers(self._options.git_commit, self._changed_files(state))[:5] File "/Users/andy/Code/OpenSource/Tools/Scripts/webkitpy/common/checkout/checkout.py", line 146, in suggested_reviewers unique_reviewers = reduce(lambda suggestions, reviewer: suggestions + [reviewer if reviewer not in suggestions else None], reviewers, []) File "/Users/andy/Code/OpenSource/Tools/Scripts/webkitpy/common/checkout/checkout.py", line 146, in <lambda> unique_reviewers = reduce(lambda suggestions, reviewer: suggestions + [reviewer if reviewer not in suggestions else None], reviewers, []) File "/Users/andy/Code/OpenSource/Tools/Scripts/webkitpy/common/config/committers.py", line 79, in __eq__ return (self.full_name == other.full_name AttributeError: 'NoneType' object has no attribute 'full_name'
(In reply to comment #13) > r206973 broke `webkit-patch suggest-reviewers` and `webkit-patch upload > --suggest-reviewers` I filed https://bugs.webkit.org/show_bug.cgi?id=163478
*** Bug 152665 has been marked as a duplicate of this bug. ***