Bug 152665 – Too easy to add contributors to wrong place in contributors.json

• Status: RESOLVED
• Resolution: DUPLICATE
• Component: Tools / Tests

[Michael Catanzaro]

contributors.json has three lists: committers, contributors (who are neither committers nor reviewers; good to make it easy to CC people or bots in Bugzilla), and reviewers. But the file is very long, so it's easy to not realize this and add a name to the wrong list, or get confused about which part of the file you are in.

For instance, it took three tries to get Sebastian's name in the right place:

http://trac.webkit.org/changeset/190959
http://trac.webkit.org/changeset/194432
http://trac.webkit.org/changeset/194511

I also noticed Frédéric was in the wrong place:

http://trac.webkit.org/changeset/194512

I only caught these two cases because these are folks whom I happen to know, and I was looking through the file while moving myself to the reviewers list. There are probably many other contributors in the wrong place.

Make it more difficult to add people in the wrong place by splitting these lists out into three separate files.

[Michael Catanzaro]

Created attachment 268139 [details]
Patch

[Alexey Proskuryakov]

Comment on attachment 268139 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=268139&action=review

> Tools/ChangeLog:3
> +        Too easy to add contributors to wrong place in contributors.json

I think that this breaks Bugzilla autocomplete, as well as a contributors page on webkit.org.

[Michael Catanzaro]

(In reply to comment #2)
> I think that this breaks Bugzilla autocomplete, as well as a contributors
> page on webkit.org.

You're right. I updated the Python code that processes these files, but neither Bugzilla nor the contributors page use that code. It seems like the code I updated was only used by the WebKit commit bot.

[Konstantin Tokarev]

I think this change is not relevant anymore after r206973. contributors.json is a flat alphabetically sorted list now.

*** This bug has been marked as a duplicate of bug 163183 ***