Bug 163478 – REGRESSION (r206973): Running "webkit-patch suggest-reviewers" throws an AttributeError: 'NoneType' object has no attribute 'full_name'

• Status: RESOLVED
• Resolution: FIXED
• Component: Tools / Tests

[Andy Estes]

% webkit-patch suggest-reviewers
Traceback (most recent call last):
  File "/Users/andy/Code/OpenSource/Tools/Scripts/webkit-patch", line 84, in <module>
    main()
  File "/Users/andy/Code/OpenSource/Tools/Scripts/webkit-patch", line 79, in main
    WebKitPatch(os.path.abspath(__file__)).main()
  File "/Users/andy/Code/OpenSource/Tools/Scripts/webkitpy/tool/multicommandtool.py", line 305, in main
    result = command.check_arguments_and_execute(options, args, self)
  File "/Users/andy/Code/OpenSource/Tools/Scripts/webkitpy/tool/multicommandtool.py", line 123, in check_arguments_and_execute
    return self.execute(options, args, tool) or 0
  File "/Users/andy/Code/OpenSource/Tools/Scripts/webkitpy/tool/commands/abstractsequencedcommand.py", line 55, in execute
    self._sequence.run_and_handle_errors(tool, options, state)
  File "/Users/andy/Code/OpenSource/Tools/Scripts/webkitpy/tool/commands/stepsequence.py", line 73, in run_and_handle_errors
    self._run(tool, options, state)
  File "/Users/andy/Code/OpenSource/Tools/Scripts/webkitpy/tool/commands/stepsequence.py", line 67, in _run
    step(tool, options).run(state)
  File "/Users/andy/Code/OpenSource/Tools/Scripts/webkitpy/tool/steps/suggestreviewers.py", line 45, in run
    reviewers = self._tool.checkout().suggested_reviewers(self._options.git_commit, self._changed_files(state))[:5]
  File "/Users/andy/Code/OpenSource/Tools/Scripts/webkitpy/common/checkout/checkout.py", line 146, in suggested_reviewers
    unique_reviewers = reduce(lambda suggestions, reviewer: suggestions + [reviewer if reviewer not in suggestions else None], reviewers, [])
  File "/Users/andy/Code/OpenSource/Tools/Scripts/webkitpy/common/checkout/checkout.py", line 146, in <lambda>
    unique_reviewers = reduce(lambda suggestions, reviewer: suggestions + [reviewer if reviewer not in suggestions else None], reviewers, [])
  File "/Users/andy/Code/OpenSource/Tools/Scripts/webkitpy/common/config/committers.py", line 79, in __eq__
    return (self.full_name == other.full_name
AttributeError: 'NoneType' object has no attribute 'full_name'

[Simon Fraser (smfr)]

Created attachment 291701 [details]
Patch

[WebKit Commit Bot]

Comment on attachment 291701 [details]
Patch

Clearing flags on attachment: 291701

Committed r207370: <http://trac.webkit.org/changeset/207370>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.