Bug 162801 - Add test coverage for radiusX / radiusY / rotationAngle in WebPlatformTouchPoint.
Summary: Add test coverage for radiusX / radiusY / rotationAngle in WebPlatformTouchPo...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Chris Dumez
URL:
Keywords: InRadar
Depends on: 162787 163547
Blocks:
  Show dependency tree / graph
 
Reported: 2016-09-30 12:25 PDT by Chris Dumez
Modified: 2016-11-09 10:39 PST (History)
5 users (show)

See Also:

Attachments
WIP Patch (3.61 KB, patch)
2016-10-17 13:54 PDT, Chris Dumez 		no flags Details | Formatted Diff | Diff
Patch (5.13 KB, patch)
2016-10-25 14:08 PDT, Chris Dumez 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Chris Dumez 2016-09-30 12:25:39 PDT 
Add test coverage for radiusX / radiusY / rotationAngle in WebPlatformTouchPoint.
Comment 1 Chris Dumez 2016-10-17 11:07:10 PDT 
Simon indicated I can extend and use UIScriptController for this purpose. I am working on it.
Comment 2 Chris Dumez 2016-10-17 13:53:15 PDT 
Ok, so I wrote a test but it does not pass in the simulator because UIKit does not populate the radius on the UITouch in the simulator :(

Not sure how to move forward here :/
Comment 3 Chris Dumez 2016-10-17 13:54:39 PDT 
Created attachment 291867 [details]
WIP Patch
Comment 4 Radar WebKit Bug Importer 2016-10-17 14:01:46 PDT 
<rdar://problem/28807455>
Comment 5 Chris Dumez 2016-10-25 14:08:58 PDT 
Created attachment 292817 [details]
Patch
Comment 6 WebKit Commit Bot 2016-11-09 10:38:55 PST 
Comment on attachment 292817 [details]
Patch

Clearing flags on attachment: 292817

Committed r208447: <http://trac.webkit.org/changeset/208447>
Comment 7 WebKit Commit Bot 2016-11-09 10:39:00 PST 
All reviewed patches have been landed.  Closing bug.