Bug 162787 – [WK2][iOS] Add radiusX / radiusY / rotationAngle to WebPlatformTouchPoint

• Status: RESOLVED
• Resolution: FIXED
• Component: WebKit2

[Chris Dumez]

Add radiusX / radiusY / rotationAngle to WebPlatformTouchPoint.

[Chris Dumez]

<rdar://problem/28554292>

[Chris Dumez]

Created attachment 290332 [details]
Patch

[Chris Dumez]

Created attachment 290333 [details]
Patch

[David Kilzer (:ddkilzer)]

Comment on attachment 290333 [details]
Patch

r=me...if I were a WK2 reviewer.

[Benjamin Poulain]

Comment on attachment 290333 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=290333&action=review

> Source/WebKit2/Platform/spi/ios/UIKitSPI.h:657
> +    CGFloat majorRadiusInScreenCoordinates;

Be careful with bincompat.

> Source/WebKit2/Shared/WebEvent.h:333
> +    void setRadiusX(float radiusX) { m_radiusX = radiusX; }
> +    float radiusX() const { return m_radiusX; }
> +    void setRadiusY(float radiusY) { m_radiusY = radiusY; }
> +    float radiusY() const { return m_radiusY; }
> +    void setRotationAngle(float rotationAngle) { m_rotationAngle = rotationAngle; }
> +    float rotationAngle() const { return m_rotationAngle; }

float->double

> Source/WebKit2/Shared/WebEvent.h:354
> +    float m_radiusX { 0 };
> +    float m_radiusY { 0 };
> +    float m_rotationAngle { 0 };

Let's use double. We can round to float when we expose the value to the API.
We should not lose precision internally.

[Chris Dumez]

Created attachment 290361 [details]
Patch

[Chris Dumez]

Comment on attachment 290361 [details]
Patch

Clearing flags on attachment: 290361

Committed r206651: <http://trac.webkit.org/changeset/206651>

[Chris Dumez]

All reviewed patches have been landed.  Closing bug.