Bug 163547 - [iOS] Hook up WebPlatformTouchPoint's radiusX / radiusY to _UIWebTouchPoint.majorRadiusInScreenCoordinates
Summary: [iOS] Hook up WebPlatformTouchPoint's radiusX / radiusY to _UIWebTouchPoint.m...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Platform (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Chris Dumez
URL:
Keywords:
Depends on:
Blocks: 162801
  Show dependency tree / graph
 
Reported: 2016-10-17 09:41 PDT by Chris Dumez
Modified: 2016-11-07 09:36 PST (History)
8 users (show)

See Also:

Attachments
Patch (2.89 KB, patch)
2016-10-17 09:43 PDT, Chris Dumez 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Chris Dumez 2016-10-17 09:41:36 PDT 
Hook up WebPlatformTouchPoint's radiusX / radiusY to _UIWebTouchPoint.majorRadiusInScreenCoordinates.
Comment 1 Chris Dumez 2016-10-17 09:43:30 PDT 
Created attachment 291825 [details]
Patch
Comment 2 WebKit Commit Bot 2016-10-17 09:45:50 PDT 
Attachment 291825 [details] did not pass style-queue:


ERROR: Source/WebKit2/Platform/spi/ios/UIKitSPI.h:0:  Use #pragma once header guard.  [build/header_guard] [5]
Total errors found: 1 in 3 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 3 WebKit Commit Bot 2016-10-17 10:51:09 PDT 
Comment on attachment 291825 [details]
Patch

Clearing flags on attachment: 291825

Committed r207413: <http://trac.webkit.org/changeset/207413>
Comment 4 WebKit Commit Bot 2016-10-17 10:51:14 PDT 
All reviewed patches have been landed.  Closing bug.
Comment 5 Daniel Bates 2016-10-17 11:02:26 PDT 
Can we write tests for this change?
Comment 6 Chris Dumez 2016-10-17 11:03:27 PDT 
(In reply to comment #5)
> Can we write tests for this change?

Sure, this is my next patch (see https://bugs.webkit.org/show_bug.cgi?id=162801) which is blocked by this bug.
Comment 7 Ryan Haddad 2016-10-18 15:36:20 PDT 
Reverted r207413 for reason:

This change broke iOS builds.

Committed r207494: <http://trac.webkit.org/changeset/207494>
Comment 8 Ryan Haddad 2016-10-18 15:37:12 PDT 
<rdar://problem/28833585>
Comment 9 Chris Dumez 2016-10-25 09:37:24 PDT 
Reverted r207494 for reason:

iOS SDK has been updated on the bots now so rollout the rollout

Committed r207823: <http://trac.webkit.org/changeset/207823>
Comment 10 Chris Dumez 2016-11-07 09:36:19 PST 
Relanded in r207823.