Bug 160302 – Remove unused check-for-exit-time-destructors, check-for-global-initializers scripts and deploy -Wexit-time-destructors, -Wglobal-constructors clang switches consistently

• Status: NEW
• Component: Tools / Tests

[David Kilzer (:ddkilzer)]

Anders replaced the check-for-exit-time-destructors script with the -Wexit-time-destructors compiler flag and the check-for-global-initializers with the -Wglobal-constructors consistently a while ago.

Now that clang on all supported platforms also supports -Wexit-time-destructors and -Wglobal-constructors, we can remove the scripts.

[David Kilzer (:ddkilzer)]

FYI:

check-for-global-initializers was added in r13539:  <https://trac.webkit.org/r13539>
check-for-exit-time-destructors was added in r38100:  <https://trac.webkit.org/r38100>

[David Kilzer (:ddkilzer)]

Created attachment 284796 [details]
Patch v1

[David Kilzer (:ddkilzer)]

Comment on attachment 284796 [details]
Patch v1

I'm assuming the new warning flags won't cause build failures, but let's check.

[WebKit Commit Bot]

Note that there are important steps to take when updating ANGLE. See http://trac.webkit.org/wiki/UpdatingANGLE

[David Kilzer (:ddkilzer)]

(In reply to comment #3)
> Comment on attachment 284796 [details]
> Patch v1
> 
> I'm assuming the new warning flags won't cause build failures, but let's
> check.

And I was wrong!

[David Kilzer (:ddkilzer)]

(In reply to comment #4)
> Note that there are important steps to take when updating ANGLE. See
> http://trac.webkit.org/wiki/UpdatingANGLE

I'm going to break the ANGLE fixes out into a separate bug.

[David Kilzer (:ddkilzer)]

(In reply to comment #6)
> (In reply to comment #4)
> > Note that there are important steps to take when updating ANGLE. See
> > http://trac.webkit.org/wiki/UpdatingANGLE
> 
> I'm going to break the ANGLE fixes out into a separate bug.

Bug 160332: ANGLE: Fix global constructors and exit-time destructors

[David Kilzer (:ddkilzer)]

Created attachment 284937 [details]
Patch v2

[David Kilzer (:ddkilzer)]

Created attachment 298831 [details]
Patch v3

[Darin Adler]

/Volumes/Data/EWS/WebKit/Tools/DumpRenderTree/mac/DumpRenderTree.mm:180:20: error: declaration requires an exit-time destructor [-Werror,-Wexit-time-destructors]
RefPtr<TestRunner> gTestRunner;
/Volumes/Data/EWS/WebKit/Tools/DumpRenderTree/mac/DumpRenderTree.mm:216:31: error: declaration requires an exit-time destructor [-Werror,-Wexit-time-destructors]
static RetainPtr<CFStringRef> persistentUserStyleSheetLocation;
/Volumes/Data/EWS/WebKit/Tools/DumpRenderTree/mac/DumpRenderTree.mm:217:30: error: declaration requires an exit-time destructor [-Werror,-Wexit-time-destructors]
static std::set<std::string> allowedHosts;