WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
83342
webkit-patch upload --suggest-reviewers shouldn't break in the presence of deleted or moved files
https://bugs.webkit.org/show_bug.cgi?id=83342
Summary
webkit-patch upload --suggest-reviewers shouldn't break in the presence of de...
Ami Fischman
Reported
2012-04-05 18:27:33 PDT
Apparently webkit-patch upload's --suggest-reviewers feature is broken in the presence of moved (removed?) files. After moving a test & its expectation from LayoutTests/http/tests/media to LayoutTests/media the upload failed like this: $ ./Tools/Scripts/webkit-patch upload --request-commit --suggest-reviewers 83296 Total errors found: 0 in 4 files Was that diff correct? [Y/n]: Fetching:
https://bugs.webkit.org/show_bug.cgi?id=83296
&ctype=xml Path /usr/local/google/fischman/src/chromium/src/third_party/WebKit/LayoutTests/http/tests/media/media-can-load-when-hidden-expected.txt does not exist. Path /usr/local/google/fischman/src/chromium/src/third_party/WebKit/LayoutTests/http/tests/media/media-can-load-when-hidden-expected.txt does not exist. Removing the --suggest-reviewers option made it work just fine.
Attachments
Patch v1
(6.54 KB, patch)
2016-07-28 12:47 PDT
,
David Kilzer (:ddkilzer)
no flags
Details
Formatted Diff
Diff
View All
Add attachment
proposed patch, testcase, etc.
David Kilzer (:ddkilzer)
Comment 1
2016-07-28 12:47:46 PDT
Created
attachment 284804
[details]
Patch v1
WebKit Commit Bot
Comment 2
2016-07-28 12:50:37 PDT
Attachment 284804
[details]
did not pass style-queue: ERROR: Tools/Scripts/webkitpy/common/checkout/scm/scm_unittest.py:413: [SCMTest._shared_test_revisions_changing_file] Instance of 'SCMTest' has no 'scm' member [pylint/E1101] [5] Total errors found: 1 in 4 files If any of these errors are false positives, please file a bug against check-webkit-style.
David Kilzer (:ddkilzer)
Comment 3
2016-07-28 12:52:38 PDT
(In reply to
comment #2
)
>
Attachment 284804
[details]
did not pass style-queue: > > ERROR: Tools/Scripts/webkitpy/common/checkout/scm/scm_unittest.py:413: > [SCMTest._shared_test_revisions_changing_file] Instance of 'SCMTest' has no > 'scm' member [pylint/E1101] [5] > Total errors found: 1 in 4 files
This can be safely ignored. Tests pass despite this warning.
WebKit Commit Bot
Comment 4
2016-07-28 13:22:15 PDT
Comment on
attachment 284804
[details]
Patch v1 Clearing flags on attachment: 284804 Committed
r203832
: <
http://trac.webkit.org/changeset/203832
>
WebKit Commit Bot
Comment 5
2016-07-28 13:22:20 PDT
All reviewed patches have been landed. Closing bug.
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug