Bug 159877 - All-in-one buildfix after r202439
Summary: All-in-one buildfix after r202439
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: Other
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Csaba Osztrogonác
URL:
Keywords:
Depends on:
Blocks: 158354
  Show dependency tree / graph
 
Reported: 2016-07-18 04:54 PDT by Csaba Osztrogonác
Modified: 2016-07-18 23:51 PDT (History)
4 users (show)

See Also:

Attachments
Patch (1.64 KB, patch)
2016-07-18 04:57 PDT, Csaba Osztrogonác 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Csaba Osztrogonác 2016-07-18 04:54:13 PDT 
https://trac.webkit.org/changeset/202439 broke the all-in-one build:

In file included from ../../Source/WebCore/Modules/webaudio/AudioContext.h:31:0,
                 from DerivedSources/WebCore/JSAudioContext.h:25,
                 from ../../Source/WebCore/bindings/js/JSDOMWindowCustom.cpp:43,
                 from ../../Source/WebCore/bindings/js/JSBindingsAllInOne.cpp:63:
../../Source/WebCore/Modules/webaudio/AudioDestinationNode.h:62:25: error: reference to 'Function' is ambiguous

...

../../Source/WTF/wtf/Forward.h:28:28: note: candidates are: template<class T> class WTF::Function
../../Source/JavaScriptCore/runtime/PropertySlot.h:46:5: note:                 JSC::Attribute Function



similar bug: https://bugs.webkit.org/show_bug.cgi?id=159875
Comment 1 Csaba Osztrogonác 2016-07-18 04:57:14 PDT 
Created attachment 283900 [details]
Patch
Comment 2 WebKit Commit Bot 2016-07-18 04:59:27 PDT 
Attachment 283900 [details] did not pass style-queue:


ERROR: Source/WebCore/Modules/webaudio/AudioDestinationNode.h:62:  Extra space before ( in function call  [whitespace/parens] [4]
ERROR: Source/WebCore/Modules/webaudio/AudioDestinationNode.h:63:  Extra space before ( in function call  [whitespace/parens] [4]
ERROR: Source/WebCore/Modules/webaudio/AudioDestinationNode.h:64:  Extra space before ( in function call  [whitespace/parens] [4]
Total errors found: 3 in 2 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 3 WebKit Commit Bot 2016-07-18 23:51:45 PDT 
Comment on attachment 283900 [details]
Patch

Clearing flags on attachment: 283900

Committed r203399: <http://trac.webkit.org/changeset/203399>
Comment 4 WebKit Commit Bot 2016-07-18 23:51:49 PDT 
All reviewed patches have been landed.  Closing bug.