Bug 159875 - Windows buildfix after r203338
Summary: Windows buildfix after r203338
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: Other
Hardware: Unspecified Unspecified
: P1 Blocker
Assignee: Csaba Osztrogonác
URL:
Keywords:
Depends on:
Blocks: 159856
  Show dependency tree / graph
 
Reported: 2016-07-18 04:17 PDT by Csaba Osztrogonác
Modified: 2016-07-18 05:43 PDT (History)
10 users (show)

See Also:

Attachments
Patch (1.73 KB, patch)
2016-07-18 04:21 PDT, Csaba Osztrogonác 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Csaba Osztrogonác 2016-07-18 04:17:27 PDT 
...
Comment 1 Csaba Osztrogonác 2016-07-18 04:21:02 PDT 
Created attachment 283898 [details]
Patch

speculative fix, let Windows EWS check it
Comment 2 Csaba Osztrogonác 2016-07-18 04:21:43 PDT 
build log:
c:\cygwin\home\buildbot\slave\win-release\build\source\webcore\dom\UserGestureIndicator.h(58): error C2872: 'Function': ambiguous symbol (compiling source file C:\cygwin\home\buildbot\slave\win-release\build\Source\WebCore\bindings\js\JSBindingsAllInOne.cpp) [C:\cygwin\home\buildbot\slave\win-release\build\WebKitBuild\Release\Source\WebCore\WebCore.vcxproj]
  C:\cygwin\home\buildbot\slave\win-release\build\WebKitBuild\Release\DerivedSources\ForwardingHeaders\wtf/Function.h(33): note: could be 'WTF::Function' (compiling source file C:\cygwin\home\buildbot\slave\win-release\build\Source\WebCore\bindings\js\JSBindingsAllInOne.cpp)
  c:\cygwin\home\buildbot\slave\win-release\build\webkitbuild\release\derivedsources\forwardingheaders\javascriptcore\PropertySlot.h(46): note: or       'JSC::Attribute Function' (compiling source file C:\cygwin\home\buildbot\slave\win-release\build\Source\WebCore\bindings\js\JSBindingsAllInOne.cpp)
Comment 3 WebKit Commit Bot 2016-07-18 04:23:51 PDT 
Attachment 283898 [details] did not pass style-queue:


ERROR: Source/WebCore/dom/UserGestureIndicator.h:58:  Extra space before ( in function call  [whitespace/parens] [4]
ERROR: Source/WebCore/dom/UserGestureIndicator.h:70:  Extra space before ( in function call  [whitespace/parens] [4]
Total errors found: 2 in 2 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 4 Csaba Osztrogonác 2016-07-18 05:42:43 PDT 
Committed r203346: <http://trac.webkit.org/changeset/203346>