158354 – Rename NoncopyableFunction to Function

Bug 158354 - Rename NoncopyableFunction to Function

Summary: Rename NoncopyableFunction to Function

Status:	RESOLVED FIXED

Alias:	None

Product:	WebKit
Classification:	Unclassified
Component:	New Bugs (show other bugs)
Version:	WebKit Nightly Build
Hardware:	Unspecified Unspecified

Importance:	P2 Normal
Assignee:	Anders Carlsson

URL:
Keywords:

Depends on:	158374 159877
Blocks:
	Show dependency tree / graph

Reported:	2016-06-03 13:48 PDT by Anders Carlsson
Modified:	2016-07-18 04:54 PDT (History)
CC List:	9 users (show)

See Also:

Attachments
Patch (72.19 KB, patch) 2016-06-03 13:49 PDT, Anders Carlsson	no flags	Details \| Formatted Diff \| Diff
Patch (6.41 KB, patch) 2016-06-10 11:56 PDT, Anders Carlsson	no flags	Details \| Formatted Diff \| Diff
Patch (9.09 KB, patch) 2016-06-10 12:48 PDT, Anders Carlsson	no flags	Details \| Formatted Diff \| Diff
Patch (9.07 KB, patch) 2016-06-10 13:52 PDT, Anders Carlsson	no flags	Details \| Formatted Diff \| Diff
Patch (9.07 KB, patch) 2016-06-10 14:44 PDT, Anders Carlsson	no flags	Details \| Formatted Diff \| Diff
Patch (9.08 KB, patch) 2016-06-10 14:45 PDT, Anders Carlsson	no flags	Details \| Formatted Diff \| Diff
Patch (9.11 KB, patch) 2016-06-21 16:03 PDT, Anders Carlsson	no flags	Details \| Formatted Diff \| Diff
Patch (84.30 KB, patch) 2016-06-22 11:25 PDT, Anders Carlsson	no flags	Details \| Formatted Diff \| Diff
Patch (84.33 KB, patch) 2016-06-22 12:58 PDT, Anders Carlsson	no flags	Details \| Formatted Diff \| Diff
Patch (84.33 KB, patch) 2016-06-22 14:05 PDT, Anders Carlsson	no flags	Details \| Formatted Diff \| Diff
Patch (85.01 KB, patch) 2016-06-24 10:09 PDT, Anders Carlsson	no flags	Details \| Formatted Diff \| Diff
Patch (85.01 KB, patch) 2016-06-24 11:30 PDT, Anders Carlsson	cdumez: review+	Details \| Formatted Diff \| Diff
Show Obsolete (11) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.

Description Anders Carlsson 2016-06-03 13:48:33 PDT

Rename NoncopyableFunction to Function

Comment 1 Anders Carlsson 2016-06-03 13:49:43 PDT

Created attachment 280459 [details]
Patch

Comment 2 WebKit Commit Bot 2016-06-03 13:51:41 PDT

Attachment 280459 [details] did not pass style-queue:


ERROR: Source/WebCore/platform/mediastream/mac/AVMediaCaptureSource.mm:243:  Extra space before ( in function call  [whitespace/parens] [4]
ERROR: Source/WTF/wtf/win/WorkItemWin.h:42:  Extra space before ( in function call  [whitespace/parens] [4]
ERROR: Source/WTF/wtf/win/WorkItemWin.h:49:  Extra space before ( in function call  [whitespace/parens] [4]
ERROR: Source/WTF/wtf/win/WorkItemWin.h:52:  Extra space before ( in function call  [whitespace/parens] [4]
ERROR: Source/WTF/wtf/win/WorkItemWin.h:58:  Extra space before ( in function call  [whitespace/parens] [4]
ERROR: Source/WTF/wtf/win/WorkItemWin.h:65:  Extra space before ( in function call  [whitespace/parens] [4]
ERROR: Source/WebCore/Modules/webaudio/DefaultAudioDestinationNode.cpp:109:  Extra space before ( in function call  [whitespace/parens] [4]
ERROR: Source/WebCore/Modules/webaudio/DefaultAudioDestinationNode.cpp:118:  Extra space before ( in function call  [whitespace/parens] [4]
ERROR: Source/WTF/wtf/MainThread.cpp:50:  Extra space before ( in function call  [whitespace/parens] [4]
ERROR: Source/WTF/wtf/MainThread.cpp:52:  Extra space before ( in function call  [whitespace/parens] [4]
ERROR: Source/WTF/wtf/MainThread.cpp:123:  Extra space before ( in function call  [whitespace/parens] [4]
ERROR: Source/WTF/wtf/MainThread.cpp:147:  Extra space before ( in function call  [whitespace/parens] [4]
ERROR: Source/WTF/wtf/WorkQueue.h:75:  Extra space before ( in function call  [whitespace/parens] [4]
ERROR: Source/WTF/wtf/WorkQueue.h:76:  Extra space before ( in function call  [whitespace/parens] [4]
ERROR: Source/WebCore/fileapi/AsyncFileStream.cpp:42:  Alphabetical sorting problem.  [build/include_order] [4]
ERROR: Source/WebCore/fileapi/AsyncFileStream.cpp:67:  Extra space before ( in function call  [whitespace/parens] [4]
ERROR: Source/WebCore/fileapi/AsyncFileStream.cpp:72:  Extra space before ( in function call  [whitespace/parens] [4]
ERROR: Source/WebCore/fileapi/AsyncFileStream.cpp:93:  Extra space before ( in function call  [whitespace/parens] [4]
ERROR: Source/WTF/wtf/win/WorkQueueWin.cpp:132:  Extra space before ( in function call  [whitespace/parens] [4]
ERROR: Source/WTF/wtf/win/WorkQueueWin.cpp:152:  Extra space before ( in function call  [whitespace/parens] [4]
ERROR: Source/WTF/wtf/win/WorkQueueWin.cpp:183:  Extra space before ( in function call  [whitespace/parens] [4]
ERROR: Source/WTF/wtf/glib/RunLoopGLib.cpp:127:  Extra space before ( in function call  [whitespace/parens] [4]
ERROR: Source/WTF/wtf/glib/RunLoopGLib.cpp:138:  Extra space before ( in function call  [whitespace/parens] [4]
ERROR: Source/WTF/wtf/glib/RunLoopGLib.cpp:141:  Extra space before ( in function call  [whitespace/parens] [4]
ERROR: Source/WebKit2/NetworkProcess/cache/NetworkCacheIOChannelSoup.cpp:72:  Extra space before ( in function call  [whitespace/parens] [4]
ERROR: Source/WebCore/page/scrolling/ScrollingThread.h:36:  Alphabetical sorting problem.  [build/include_order] [4]
ERROR: Source/WebCore/page/scrolling/ScrollingThread.h:51:  Extra space before ( in function call  [whitespace/parens] [4]
ERROR: Source/WebCore/page/scrolling/ScrollingThread.h:55:  Extra space before ( in function call  [whitespace/parens] [4]
ERROR: Source/WebCore/page/scrolling/ScrollingThread.h:83:  Extra space before ( in function call  [whitespace/parens] [4]
ERROR: Source/WebCore/platform/graphics/avfoundation/objc/MediaPlayerPrivateMediaStreamAVFObjC.mm:627:  Extra space before ( in function call  [whitespace/parens] [4]
ERROR: Source/WTF/wtf/efl/WorkQueueEfl.cpp:57:  Extra space before ( in function call  [whitespace/parens] [4]
ERROR: Source/WTF/wtf/efl/WorkQueueEfl.cpp:65:  Extra space before ( in function call  [whitespace/parens] [4]
ERROR: Source/WebCore/page/FrameView.h:40:  Alphabetical sorting problem.  [build/include_order] [4]
ERROR: Source/WebKit2/NetworkProcess/NetworkProcess.cpp:311:  Extra space before ( in function call  [whitespace/parens] [4]
ERROR: Source/WebKit2/NetworkProcess/NetworkProcess.cpp:355:  Extra space before ( in function call  [whitespace/parens] [4]
ERROR: Source/WebKit2/NetworkProcess/NetworkProcess.cpp:369:  Extra space before ( in function call  [whitespace/parens] [4]
ERROR: Source/WebKit2/NetworkProcess/NetworkProcess.cpp:415:  Extra space before ( in function call  [whitespace/parens] [4]
ERROR: Source/WebCore/Modules/mediastream/MediaEndpointPeerConnection.h:82:  Extra space before ( in function call  [whitespace/parens] [4]
ERROR: Source/WebCore/Modules/mediastream/MediaEndpointPeerConnection.h:96:  Extra space before ( in function call  [whitespace/parens] [4]
ERROR: Source/WebCore/Modules/mediastream/MediaEndpointPeerConnection.cpp:98:  Extra space before ( in function call  [whitespace/parens] [4]
ERROR: Source/WebCore/dom/ScriptExecutionContext.h:38:  Alphabetical sorting problem.  [build/include_order] [4]
ERROR: Source/WebCore/dom/ScriptExecutionContext.h:136:  Extra space before ( in function call  [whitespace/parens] [4]
ERROR: Source/WebCore/dom/ScriptExecutionContext.h:143:  Extra space before ( in function call  [whitespace/parens] [4]
ERROR: Source/WebCore/dom/ScriptExecutionContext.h:149:  Extra space before ( in function call  [whitespace/parens] [4]
ERROR: Source/WebCore/dom/ScriptExecutionContext.h:166:  Extra space before ( in function call  [whitespace/parens] [4]
ERROR: Source/WTF/wtf/generic/RunLoopGeneric.cpp:35:  Extra space before ( in function call  [whitespace/parens] [4]
ERROR: Source/WTF/wtf/generic/RunLoopGeneric.cpp:40:  Extra space before ( in function call  [whitespace/parens] [4]
ERROR: Source/WTF/wtf/generic/RunLoopGeneric.cpp:93:  Extra space before ( in function call  [whitespace/parens] [4]
ERROR: Source/WTF/wtf/generic/RunLoopGeneric.cpp:240:  Extra space before ( in function call  [whitespace/parens] [4]
ERROR: Source/WebKit2/NetworkProcess/cache/NetworkCache.h:117:  Extra space before ( in function call  [whitespace/parens] [4]
ERROR: Source/WebCore/platform/graphics/avfoundation/objc/MediaPlayerPrivateMediaStreamAVFObjC.h:34:  Alphabetical sorting problem.  [build/include_order] [4]
ERROR: Source/WebCore/platform/graphics/avfoundation/objc/MediaPlayerPrivateMediaStreamAVFObjC.h:146:  Extra space before ( in function call  [whitespace/parens] [4]
ERROR: Source/WTF/wtf/generic/WorkQueueGeneric.cpp:84:  Extra space before ( in function call  [whitespace/parens] [4]
ERROR: Source/WTF/wtf/generic/WorkQueueGeneric.cpp:92:  Extra space before ( in function call  [whitespace/parens] [4]
ERROR: Source/WTF/wtf/CrossThreadTask.h:38:  Extra space before ( in function call  [whitespace/parens] [4]
ERROR: Source/WTF/wtf/CrossThreadTask.h:50:  Extra space before ( in function call  [whitespace/parens] [4]
ERROR: Source/WTF/wtf/FunctionDispatcher.h:42:  Extra space before ( in function call  [whitespace/parens] [4]
ERROR: Source/WebCore/Modules/webaudio/DefaultAudioDestinationNode.h:53:  Extra space before ( in function call  [whitespace/parens] [4]
ERROR: Source/WebCore/Modules/webaudio/DefaultAudioDestinationNode.h:54:  Extra space before ( in function call  [whitespace/parens] [4]
ERROR: Source/WebCore/Modules/webaudio/DefaultAudioDestinationNode.h:55:  Extra space before ( in function call  [whitespace/parens] [4]
ERROR: Source/WebCore/Modules/webaudio/AudioDestinationNode.h:62:  Extra space before ( in function call  [whitespace/parens] [4]
ERROR: Source/WebCore/Modules/webaudio/AudioDestinationNode.h:63:  Extra space before ( in function call  [whitespace/parens] [4]
ERROR: Source/WebCore/Modules/webaudio/AudioDestinationNode.h:64:  Extra space before ( in function call  [whitespace/parens] [4]
ERROR: Source/WTF/wtf/RunLoop.cpp:94:  Extra space before ( in function call  [whitespace/parens] [4]
ERROR: Source/WTF/wtf/RunLoop.cpp:109:  Extra space before ( in function call  [whitespace/parens] [4]
ERROR: Source/WTF/wtf/RunLoop.cpp:126:  Extra space before ( in function call  [whitespace/parens] [4]
ERROR: Source/WTF/wtf/cocoa/WorkQueueCocoa.cpp:31:  Extra space before ( in function call  [whitespace/parens] [4]
ERROR: Source/WTF/wtf/cocoa/WorkQueueCocoa.cpp:42:  Extra space before ( in function call  [whitespace/parens] [4]
ERROR: Source/WebKit2/NetworkProcess/cache/NetworkCacheStorage.h:38:  Alphabetical sorting problem.  [build/include_order] [4]
ERROR: Source/WebKit2/NetworkProcess/cache/NetworkCache.cpp:524:  Extra space before ( in function call  [whitespace/parens] [4]
ERROR: Source/WebCore/page/scrolling/ScrollingThread.cpp:48:  Extra space before ( in function call  [whitespace/parens] [4]
ERROR: Source/WebCore/page/scrolling/ScrollingThread.cpp:61:  Extra space before ( in function call  [whitespace/parens] [4]
ERROR: Source/WebCore/page/scrolling/ScrollingThread.cpp:107:  Extra space before ( in function call  [whitespace/parens] [4]
ERROR: Source/WTF/wtf/RunLoop.h:62:  Extra space before ( in function call  [whitespace/parens] [4]
ERROR: Source/WTF/wtf/RunLoop.h:82:  Extra space before ( in function call  [whitespace/parens] [4]
ERROR: Source/WTF/wtf/RunLoop.h:158:  Extra space before ( in function call  [whitespace/parens] [4]
ERROR: Source/WebCore/style/StyleTreeResolver.h:37:  Alphabetical sorting problem.  [build/include_order] [4]
ERROR: Source/WebCore/style/StyleTreeResolver.h:113:  Extra space before ( in function call  [whitespace/parens] [4]
ERROR: Source/WebCore/platform/mediastream/MediaStreamPrivate.cpp:302:  Extra space before ( in function call  [whitespace/parens] [4]
ERROR: Source/WTF/wtf/MainThread.h:44:  Extra space before ( in function call  [whitespace/parens] [4]
ERROR: Source/WTF/wtf/win/WorkItemWin.cpp:35:  Extra space before ( in function call  [whitespace/parens] [4]
ERROR: Source/WTF/wtf/win/WorkItemWin.cpp:41:  Extra space before ( in function call  [whitespace/parens] [4]
ERROR: Source/WTF/wtf/win/WorkItemWin.cpp:50:  Extra space before ( in function call  [whitespace/parens] [4]
ERROR: Source/WTF/wtf/win/WorkItemWin.cpp:58:  Extra space before ( in function call  [whitespace/parens] [4]
ERROR: Source/WebKit/Storage/StorageThread.h:48:  Extra space before ( in function call  [whitespace/parens] [4]
ERROR: Source/WebKit/Storage/StorageThread.h:61:  Extra space before ( in function call  [whitespace/parens] [4]
ERROR: Source/WebCore/style/StyleTreeResolver.cpp:524:  Extra space before ( in function call  [whitespace/parens] [4]
ERROR: Source/WebCore/style/StyleTreeResolver.cpp:526:  Extra space before ( in function call  [whitespace/parens] [4]
ERROR: Source/WebCore/style/StyleTreeResolver.cpp:530:  Extra space before ( in function call  [whitespace/parens] [4]
ERROR: Source/WebKit/Storage/StorageThread.cpp:77:  Extra space before ( in function call  [whitespace/parens] [4]
ERROR: Source/WebKit/Storage/StorageThread.cpp:81:  Extra space before ( in function call  [whitespace/parens] [4]
ERROR: Source/WebKit/Storage/StorageThread.cpp:93:  Extra space before ( in function call  [whitespace/parens] [4]
ERROR: Source/WebCore/platform/mediastream/mac/AVMediaCaptureSource.h:89:  Extra space before ( in function call  [whitespace/parens] [4]
ERROR: Source/WebCore/platform/mediastream/MediaStreamPrivate.h:44:  Alphabetical sorting problem.  [build/include_order] [4]
ERROR: Source/WebCore/platform/mediastream/MediaStreamPrivate.h:115:  Extra space before ( in function call  [whitespace/parens] [4]
ERROR: Source/WebKit/Storage/StorageSyncManager.h:46:  Extra space before ( in function call  [whitespace/parens] [4]
ERROR: Source/WebKit/Storage/StorageSyncManager.cpp:66:  Extra space before ( in function call  [whitespace/parens] [4]
ERROR: Source/WTF/wtf/efl/DispatchQueueWorkItemEfl.h:37:  Extra space before ( in function call  [whitespace/parens] [4]
ERROR: Source/WTF/wtf/efl/DispatchQueueWorkItemEfl.h:47:  Extra space before ( in function call  [whitespace/parens] [4]
ERROR: Source/WTF/wtf/efl/DispatchQueueWorkItemEfl.h:52:  Extra space before ( in function call  [whitespace/parens] [4]
ERROR: Source/WTF/wtf/efl/DispatchQueueWorkItemEfl.h:61:  Extra space before ( in function call  [whitespace/parens] [4]
Total errors found: 101 in 56 files


If any of these errors are false positives, please file a bug against check-webkit-style.

Comment 3 Chris Dumez 2016-06-03 14:21:12 PDT

Comment on attachment 280459 [details]
Patch

R=me as long as it builds everywhere.

Comment 4 WebKit Commit Bot 2016-06-03 15:22:45 PDT

Comment on attachment 280459 [details]
Patch

Clearing flags on attachment: 280459

Committed r201663: <http://trac.webkit.org/changeset/201663>

Comment 5 WebKit Commit Bot 2016-06-03 15:22:49 PDT

All reviewed patches have been landed.  Closing bug.

Comment 6 Ryan Haddad 2016-06-03 15:50:21 PDT

This change appears to have broken the Windows build:
https://build.webkit.org/builders/Apple%20Win%20Debug%20%28Build%29/builds/95211

C:\cygwin\home\buildbot\slave\win-release\build\Source\WebCore\bindings\js\JSCallbackData.h(121): error C2661: 'WebCore::ScriptExecutionContext::Task::Task': no overloaded function takes 2 arguments (compiling source file C:\cygwin\home\buildbot\slave\win-release\build\Source\WebCore\DerivedSources.cpp) [C:\cygwin\home\buildbot\slave\win-release\build\WebKitBuild\Release\Source\WebCore\WebCoreDerivedSources.vcxproj]

Comment 7 WebKit Commit Bot 2016-06-03 17:52:39 PDT

Re-opened since this is blocked by bug 158374

Comment 8 Darin Adler 2016-06-03 19:46:41 PDT

Comment on attachment 280459 [details]
Patch

If just named WTF::Function, then I think we need a comment explaining differences from std::function.

Comment 9 Anders Carlsson 2016-06-10 11:54:44 PDT

(In reply to comment #8)
> Comment on attachment 280459 [details]
> Patch
> 
> If just named WTF::Function, then I think we need a comment explaining
> differences from std::function.

I think our intention is to replace std::function with WTF::Function for the thread-safety reasons.

Comment 10 Anders Carlsson 2016-06-10 11:56:26 PDT

Created attachment 281024 [details]
Patch

Comment 11 Anders Carlsson 2016-06-10 12:48:04 PDT

Created attachment 281035 [details]
Patch

Comment 12 WebKit Commit Bot 2016-06-10 12:49:25 PDT

Attachment 281035 [details] did not pass style-queue:


ERROR: Source/WebCore/dom/ScriptExecutionContext.h:136:  Extra space before ( in function call  [whitespace/parens] [4]
ERROR: Source/WebCore/dom/ScriptExecutionContext.h:143:  Extra space before ( in function call  [whitespace/parens] [4]
ERROR: Source/WebCore/dom/ScriptExecutionContext.h:149:  Extra space before ( in function call  [whitespace/parens] [4]
ERROR: Source/WebCore/dom/ScriptExecutionContext.h:166:  Extra space before ( in function call  [whitespace/parens] [4]
Total errors found: 4 in 5 files


If any of these errors are false positives, please file a bug against check-webkit-style.

Comment 13 Anders Carlsson 2016-06-10 13:52:53 PDT

Created attachment 281042 [details]
Patch

Comment 14 WebKit Commit Bot 2016-06-10 13:54:11 PDT

Attachment 281042 [details] did not pass style-queue:


ERROR: Source/WebCore/dom/ScriptExecutionContext.h:136:  Extra space before ( in function call  [whitespace/parens] [4]
ERROR: Source/WebCore/dom/ScriptExecutionContext.h:143:  Extra space before ( in function call  [whitespace/parens] [4]
ERROR: Source/WebCore/dom/ScriptExecutionContext.h:149:  Extra space before ( in function call  [whitespace/parens] [4]
ERROR: Source/WebCore/dom/ScriptExecutionContext.h:166:  Extra space before ( in function call  [whitespace/parens] [4]
Total errors found: 4 in 5 files


If any of these errors are false positives, please file a bug against check-webkit-style.

Comment 15 Anders Carlsson 2016-06-10 14:44:26 PDT

Created attachment 281048 [details]
Patch

Comment 16 Anders Carlsson 2016-06-10 14:45:32 PDT

Created attachment 281049 [details]
Patch

Comment 17 WebKit Commit Bot 2016-06-10 14:48:12 PDT

Attachment 281049 [details] did not pass style-queue:


ERROR: Source/WebCore/dom/ScriptExecutionContext.h:136:  Extra space before ( in function call  [whitespace/parens] [4]
ERROR: Source/WebCore/dom/ScriptExecutionContext.h:143:  Extra space before ( in function call  [whitespace/parens] [4]
ERROR: Source/WebCore/dom/ScriptExecutionContext.h:149:  Extra space before ( in function call  [whitespace/parens] [4]
ERROR: Source/WebCore/dom/ScriptExecutionContext.h:166:  Extra space before ( in function call  [whitespace/parens] [4]
Total errors found: 4 in 5 files


If any of these errors are false positives, please file a bug against check-webkit-style.

Comment 18 Brent Fulgham 2016-06-16 16:19:58 PDT

The Windows build error appears to be unrelated to these changes.

Comment 19 Anders Carlsson 2016-06-16 16:26:25 PDT

(In reply to comment #18)
> The Windows build error appears to be unrelated to these changes.

No, it's related and I don't know what's causing it.

Comment 20 Brent Fulgham 2016-06-16 16:28:41 PDT

(In reply to comment #19)
> (In reply to comment #18)
> > The Windows build error appears to be unrelated to these changes.
> 
> No, it's related and I don't know what's causing it.

Sorry -- I made that comment on the wrong bug. Let's see if Per can track down the cause.

Comment 21 Per Arne Vollan 2016-06-16 23:48:01 PDT

I get this compile error:

1>------ Build started: Project: WebCore (WebCore\WebCore), Configuration: Release Win32 ------
1>  JSBindingsAllInOne.cpp
1>c:\projects\webkit\opensource\source\webcore\dom\ScriptExecutionContext.h(148): error C2872: 'Function': ambiguous symbol
1>  C:\Projects\WebKit\OpenSource\WebKitBuild\Release\DerivedSources\ForwardingHeaders\wtf/Function.h(33): note: could be 'WTF::Function = WTF::NoncopyableFunction<T>'
1>  c:\projects\webkit\opensource\webkitbuild\release\derivedsources\forwardingheaders\javascriptcore\PropertySlot.h(46): note: or       'JSC::Attribute Function'
1>c:\projects\webkit\opensource\source\webcore\dom\ScriptExecutionContext.h(171): error C2872: 'Function': ambiguous symbol
1>  C:\Projects\WebKit\OpenSource\WebKitBuild\Release\DerivedSources\ForwardingHeaders\wtf/Function.h(33): note: could be 'WTF::Function = WTF::NoncopyableFunction<T>'
1>  c:\projects\webkit\opensource\webkitbuild\release\derivedsources\forwardingheaders\javascriptcore\PropertySlot.h(46): note: or       'JSC::Attribute Function'

Comment 22 Anders Carlsson 2016-06-17 09:56:23 PDT

Thanks Per Arne, that's really useful!

Comment 23 Per Arne Vollan 2016-06-17 10:08:41 PDT

(In reply to comment #22)
> Thanks Per Arne, that's really useful!

No problem :)

Comment 24 Anders Carlsson 2016-06-21 16:03:50 PDT

Created attachment 281790 [details]
Patch

Comment 25 WebKit Commit Bot 2016-06-21 16:06:29 PDT

Attachment 281790 [details] did not pass style-queue:


ERROR: Source/WebCore/dom/ScriptExecutionContext.h:141:  Extra space before ( in function call  [whitespace/parens] [4]
ERROR: Source/WebCore/dom/ScriptExecutionContext.h:148:  Extra space before ( in function call  [whitespace/parens] [4]
ERROR: Source/WebCore/dom/ScriptExecutionContext.h:154:  Extra space before ( in function call  [whitespace/parens] [4]
ERROR: Source/WebCore/dom/ScriptExecutionContext.h:171:  Extra space before ( in function call  [whitespace/parens] [4]
Total errors found: 4 in 5 files


If any of these errors are false positives, please file a bug against check-webkit-style.

Comment 26 Anders Carlsson 2016-06-22 11:25:04 PDT

Created attachment 281851 [details]
Patch

Comment 27 WebKit Commit Bot 2016-06-22 11:27:38 PDT

Attachment 281851 [details] did not pass style-queue:


ERROR: Source/WebKit2/WebProcess/FileAPI/BlobRegistryProxy.cpp:84:  Extra space before ( in function call  [whitespace/parens] [4]
ERROR: Source/WebKit2/WebProcess/Network/NetworkProcessConnection.cpp:88:  Extra space before ( in function call  [whitespace/parens] [4]
ERROR: Source/WebKit2/WebProcess/FileAPI/BlobRegistryProxy.h:42:  Extra space before ( in function call  [whitespace/parens] [4]
ERROR: Source/WebKit2/NetworkProcess/NetworkProcess.h:116:  Extra space before ( in function call  [whitespace/parens] [4]
ERROR: Source/WebKit2/NetworkProcess/NetworkProcess.h:208:  Extra space before ( in function call  [whitespace/parens] [4]
ERROR: Source/WebCore/platform/mediastream/mac/AVMediaCaptureSource.mm:243:  Extra space before ( in function call  [whitespace/parens] [4]
ERROR: Source/WebCore/Modules/webaudio/DefaultAudioDestinationNode.cpp:109:  Extra space before ( in function call  [whitespace/parens] [4]
ERROR: Source/WebCore/Modules/webaudio/DefaultAudioDestinationNode.cpp:118:  Extra space before ( in function call  [whitespace/parens] [4]
ERROR: Source/WTF/wtf/MainThread.cpp:50:  Extra space before ( in function call  [whitespace/parens] [4]
ERROR: Source/WTF/wtf/MainThread.cpp:52:  Extra space before ( in function call  [whitespace/parens] [4]
ERROR: Source/WTF/wtf/MainThread.cpp:123:  Extra space before ( in function call  [whitespace/parens] [4]
ERROR: Source/WTF/wtf/MainThread.cpp:147:  Extra space before ( in function call  [whitespace/parens] [4]
ERROR: Source/WTF/wtf/WorkQueue.h:73:  Extra space before ( in function call  [whitespace/parens] [4]
ERROR: Source/WTF/wtf/WorkQueue.h:74:  Extra space before ( in function call  [whitespace/parens] [4]
ERROR: Source/WebCore/fileapi/AsyncFileStream.cpp:67:  Extra space before ( in function call  [whitespace/parens] [4]
ERROR: Source/WebCore/fileapi/AsyncFileStream.cpp:72:  Extra space before ( in function call  [whitespace/parens] [4]
ERROR: Source/WebCore/fileapi/AsyncFileStream.cpp:93:  Extra space before ( in function call  [whitespace/parens] [4]
ERROR: Source/WTF/wtf/win/WorkQueueWin.cpp:101:  Extra space before ( in function call  [whitespace/parens] [4]
ERROR: Source/WTF/wtf/win/WorkQueueWin.cpp:121:  Extra space before ( in function call  [whitespace/parens] [4]
ERROR: Source/WTF/wtf/win/WorkQueueWin.cpp:152:  Extra space before ( in function call  [whitespace/parens] [4]
ERROR: Source/WTF/wtf/glib/RunLoopGLib.cpp:127:  Extra space before ( in function call  [whitespace/parens] [4]
ERROR: Source/WTF/wtf/glib/RunLoopGLib.cpp:138:  Extra space before ( in function call  [whitespace/parens] [4]
ERROR: Source/WTF/wtf/glib/RunLoopGLib.cpp:141:  Extra space before ( in function call  [whitespace/parens] [4]
ERROR: Source/WebKit2/NetworkProcess/cache/NetworkCacheIOChannelSoup.cpp:72:  Extra space before ( in function call  [whitespace/parens] [4]
ERROR: Source/WebKit2/NetworkProcess/FileAPI/NetworkBlobRegistry.h:57:  Extra space before ( in function call  [whitespace/parens] [4]
ERROR: Source/WebCore/page/scrolling/ScrollingThread.h:51:  Extra space before ( in function call  [whitespace/parens] [4]
ERROR: Source/WebCore/page/scrolling/ScrollingThread.h:55:  Extra space before ( in function call  [whitespace/parens] [4]
ERROR: Source/WebCore/page/scrolling/ScrollingThread.h:83:  Extra space before ( in function call  [whitespace/parens] [4]
ERROR: Source/WebCore/platform/graphics/avfoundation/objc/MediaPlayerPrivateMediaStreamAVFObjC.mm:627:  Extra space before ( in function call  [whitespace/parens] [4]
ERROR: Source/WTF/wtf/efl/WorkQueueEfl.cpp:57:  Extra space before ( in function call  [whitespace/parens] [4]
ERROR: Source/WTF/wtf/efl/WorkQueueEfl.cpp:65:  Extra space before ( in function call  [whitespace/parens] [4]
ERROR: Source/WebKit2/NetworkProcess/NetworkProcess.cpp:296:  Extra space before ( in function call  [whitespace/parens] [4]
ERROR: Source/WebKit2/NetworkProcess/NetworkProcess.cpp:311:  Extra space before ( in function call  [whitespace/parens] [4]
ERROR: Source/WebKit2/NetworkProcess/NetworkProcess.cpp:355:  Extra space before ( in function call  [whitespace/parens] [4]
ERROR: Source/WebKit2/NetworkProcess/NetworkProcess.cpp:369:  Extra space before ( in function call  [whitespace/parens] [4]
ERROR: Source/WebKit2/NetworkProcess/NetworkProcess.cpp:415:  Extra space before ( in function call  [whitespace/parens] [4]
ERROR: Source/WebCore/Modules/mediastream/MediaEndpointPeerConnection.h:86:  Extra space before ( in function call  [whitespace/parens] [4]
ERROR: Source/WebCore/Modules/mediastream/MediaEndpointPeerConnection.h:114:  Extra space before ( in function call  [whitespace/parens] [4]
ERROR: Source/WebCore/Modules/mediastream/MediaEndpointPeerConnection.cpp:110:  Extra space before ( in function call  [whitespace/parens] [4]
ERROR: Source/WebCore/dom/ScriptExecutionContext.h:141:  Extra space before ( in function call  [whitespace/parens] [4]
ERROR: Source/WebCore/dom/ScriptExecutionContext.h:148:  Extra space before ( in function call  [whitespace/parens] [4]
ERROR: Source/WebCore/dom/ScriptExecutionContext.h:154:  Extra space before ( in function call  [whitespace/parens] [4]
ERROR: Source/WebCore/dom/ScriptExecutionContext.h:165:  Extra space before ( in function call  [whitespace/parens] [4]
ERROR: Source/WTF/wtf/generic/RunLoopGeneric.cpp:35:  Extra space before ( in function call  [whitespace/parens] [4]
ERROR: Source/WTF/wtf/generic/RunLoopGeneric.cpp:40:  Extra space before ( in function call  [whitespace/parens] [4]
ERROR: Source/WTF/wtf/generic/RunLoopGeneric.cpp:93:  Extra space before ( in function call  [whitespace/parens] [4]
ERROR: Source/WTF/wtf/generic/RunLoopGeneric.cpp:240:  Extra space before ( in function call  [whitespace/parens] [4]
ERROR: Source/WebKit2/NetworkProcess/cache/NetworkCache.h:109:  Extra space before ( in function call  [whitespace/parens] [4]
ERROR: Source/WebKit2/NetworkProcess/cache/NetworkCache.h:117:  Extra space before ( in function call  [whitespace/parens] [4]
ERROR: Source/WebCore/platform/network/BlobRegistryImpl.cpp:255:  Extra space before ( in function call  [whitespace/parens] [4]
ERROR: Source/WebCore/platform/graphics/avfoundation/objc/MediaPlayerPrivateMediaStreamAVFObjC.h:146:  Extra space before ( in function call  [whitespace/parens] [4]
ERROR: Source/WTF/wtf/generic/WorkQueueGeneric.cpp:84:  Extra space before ( in function call  [whitespace/parens] [4]
ERROR: Source/WTF/wtf/generic/WorkQueueGeneric.cpp:92:  Extra space before ( in function call  [whitespace/parens] [4]
ERROR: Source/WTF/wtf/CrossThreadTask.h:38:  Extra space before ( in function call  [whitespace/parens] [4]
ERROR: Source/WTF/wtf/CrossThreadTask.h:50:  Extra space before ( in function call  [whitespace/parens] [4]
ERROR: Source/WTF/wtf/FunctionDispatcher.h:42:  Extra space before ( in function call  [whitespace/parens] [4]
ERROR: Source/WebCore/page/scrolling/ScrollingThread.cpp:48:  Extra space before ( in function call  [whitespace/parens] [4]
ERROR: Source/WebCore/page/scrolling/ScrollingThread.cpp:61:  Extra space before ( in function call  [whitespace/parens] [4]
ERROR: Source/WebCore/page/scrolling/ScrollingThread.cpp:107:  Extra space before ( in function call  [whitespace/parens] [4]
ERROR: Source/WebCore/Modules/webaudio/DefaultAudioDestinationNode.h:53:  Extra space before ( in function call  [whitespace/parens] [4]
ERROR: Source/WebCore/Modules/webaudio/DefaultAudioDestinationNode.h:54:  Extra space before ( in function call  [whitespace/parens] [4]
ERROR: Source/WebCore/Modules/webaudio/DefaultAudioDestinationNode.h:55:  Extra space before ( in function call  [whitespace/parens] [4]
ERROR: Source/WebCore/Modules/webaudio/AudioDestinationNode.h:62:  Extra space before ( in function call  [whitespace/parens] [4]
ERROR: Source/WebCore/Modules/webaudio/AudioDestinationNode.h:63:  Extra space before ( in function call  [whitespace/parens] [4]
ERROR: Source/WebCore/Modules/webaudio/AudioDestinationNode.h:64:  Extra space before ( in function call  [whitespace/parens] [4]
ERROR: Source/WTF/wtf/RunLoop.cpp:94:  Extra space before ( in function call  [whitespace/parens] [4]
ERROR: Source/WTF/wtf/RunLoop.cpp:109:  Extra space before ( in function call  [whitespace/parens] [4]
ERROR: Source/WTF/wtf/RunLoop.cpp:126:  Extra space before ( in function call  [whitespace/parens] [4]
ERROR: Source/WTF/wtf/cocoa/WorkQueueCocoa.cpp:31:  Extra space before ( in function call  [whitespace/parens] [4]
ERROR: Source/WTF/wtf/cocoa/WorkQueueCocoa.cpp:42:  Extra space before ( in function call  [whitespace/parens] [4]
ERROR: Source/WebKit2/NetworkProcess/cache/NetworkCache.cpp:385:  Extra space before ( in function call  [whitespace/parens] [4]
ERROR: Source/WebKit2/NetworkProcess/cache/NetworkCache.cpp:483:  Extra space before ( in function call  [whitespace/parens] [4]
ERROR: Source/WebCore/bindings/js/SerializedScriptValue.h:90:  Extra space before ( in function call  [whitespace/parens] [4]
ERROR: Source/WTF/wtf/RunLoop.h:62:  Extra space before ( in function call  [whitespace/parens] [4]
ERROR: Source/WTF/wtf/RunLoop.h:82:  Extra space before ( in function call  [whitespace/parens] [4]
ERROR: Source/WTF/wtf/RunLoop.h:158:  Extra space before ( in function call  [whitespace/parens] [4]
ERROR: Source/WebCore/style/StyleTreeResolver.h:112:  Extra space before ( in function call  [whitespace/parens] [4]
ERROR: Source/WebCore/platform/mediastream/MediaStreamPrivate.cpp:302:  Extra space before ( in function call  [whitespace/parens] [4]
ERROR: Source/WTF/wtf/MainThread.h:44:  Extra space before ( in function call  [whitespace/parens] [4]
ERROR: Source/WebKit/Storage/StorageThread.h:48:  Extra space before ( in function call  [whitespace/parens] [4]
ERROR: Source/WebKit/Storage/StorageThread.h:61:  Extra space before ( in function call  [whitespace/parens] [4]
ERROR: Source/WebCore/platform/network/BlobRegistry.h:70:  Extra space before ( in function call  [whitespace/parens] [4]
ERROR: Source/WebKit2/WebProcess/Network/NetworkProcessConnection.h:61:  Extra space before ( in function call  [whitespace/parens] [4]
ERROR: Source/WebKit2/WebProcess/Network/NetworkProcessConnection.h:84:  Extra space before ( in function call  [whitespace/parens] [4]
ERROR: Source/WebCore/style/StyleTreeResolver.cpp:535:  Extra space before ( in function call  [whitespace/parens] [4]
ERROR: Source/WebCore/style/StyleTreeResolver.cpp:537:  Extra space before ( in function call  [whitespace/parens] [4]
ERROR: Source/WebCore/style/StyleTreeResolver.cpp:541:  Extra space before ( in function call  [whitespace/parens] [4]
ERROR: Source/WebKit/Storage/StorageThread.cpp:77:  Extra space before ( in function call  [whitespace/parens] [4]
ERROR: Source/WebKit/Storage/StorageThread.cpp:81:  Extra space before ( in function call  [whitespace/parens] [4]
ERROR: Source/WebKit/Storage/StorageThread.cpp:93:  Extra space before ( in function call  [whitespace/parens] [4]
ERROR: Source/WebCore/bindings/js/SerializedScriptValue.cpp:2801:  Extra space before ( in function call  [whitespace/parens] [4]
ERROR: Source/WebCore/platform/mediastream/mac/AVMediaCaptureSource.h:89:  Extra space before ( in function call  [whitespace/parens] [4]
ERROR: Source/WebCore/platform/network/BlobRegistryImpl.h:70:  Extra space before ( in function call  [whitespace/parens] [4]
ERROR: Source/WebCore/platform/mediastream/MediaStreamPrivate.h:115:  Extra space before ( in function call  [whitespace/parens] [4]
ERROR: Source/WebKit/Storage/StorageSyncManager.h:46:  Extra space before ( in function call  [whitespace/parens] [4]
ERROR: Source/WebKit/Storage/StorageSyncManager.cpp:66:  Extra space before ( in function call  [whitespace/parens] [4]
ERROR: Source/WTF/wtf/efl/DispatchQueueWorkItemEfl.h:37:  Extra space before ( in function call  [whitespace/parens] [4]
ERROR: Source/WTF/wtf/efl/DispatchQueueWorkItemEfl.h:47:  Extra space before ( in function call  [whitespace/parens] [4]
ERROR: Source/WTF/wtf/efl/DispatchQueueWorkItemEfl.h:52:  Extra space before ( in function call  [whitespace/parens] [4]
ERROR: Source/WTF/wtf/efl/DispatchQueueWorkItemEfl.h:61:  Extra space before ( in function call  [whitespace/parens] [4]
Total errors found: 100 in 66 files


If any of these errors are false positives, please file a bug against check-webkit-style.

Comment 28 Chris Dumez 2016-06-22 11:41:15 PDT

All red? :)

Comment 29 Anders Carlsson 2016-06-22 12:58:53 PDT

Created attachment 281864 [details]
Patch

Comment 30 WebKit Commit Bot 2016-06-22 13:01:49 PDT

Attachment 281864 [details] did not pass style-queue:


ERROR: Source/WebKit2/WebProcess/FileAPI/BlobRegistryProxy.cpp:84:  Extra space before ( in function call  [whitespace/parens] [4]
ERROR: Source/WebKit2/WebProcess/Network/NetworkProcessConnection.cpp:88:  Extra space before ( in function call  [whitespace/parens] [4]
ERROR: Source/WebKit2/WebProcess/FileAPI/BlobRegistryProxy.h:42:  Extra space before ( in function call  [whitespace/parens] [4]
ERROR: Source/WebKit2/NetworkProcess/NetworkProcess.h:116:  Extra space before ( in function call  [whitespace/parens] [4]
ERROR: Source/WebKit2/NetworkProcess/NetworkProcess.h:208:  Extra space before ( in function call  [whitespace/parens] [4]
ERROR: Source/WebCore/platform/mediastream/mac/AVMediaCaptureSource.mm:243:  Extra space before ( in function call  [whitespace/parens] [4]
ERROR: Source/WebCore/Modules/webaudio/DefaultAudioDestinationNode.cpp:109:  Extra space before ( in function call  [whitespace/parens] [4]
ERROR: Source/WebCore/Modules/webaudio/DefaultAudioDestinationNode.cpp:118:  Extra space before ( in function call  [whitespace/parens] [4]
ERROR: Source/WTF/wtf/MainThread.cpp:50:  Extra space before ( in function call  [whitespace/parens] [4]
ERROR: Source/WTF/wtf/MainThread.cpp:52:  Extra space before ( in function call  [whitespace/parens] [4]
ERROR: Source/WTF/wtf/MainThread.cpp:123:  Extra space before ( in function call  [whitespace/parens] [4]
ERROR: Source/WTF/wtf/MainThread.cpp:147:  Extra space before ( in function call  [whitespace/parens] [4]
ERROR: Source/WTF/wtf/WorkQueue.h:73:  Extra space before ( in function call  [whitespace/parens] [4]
ERROR: Source/WTF/wtf/WorkQueue.h:74:  Extra space before ( in function call  [whitespace/parens] [4]
ERROR: Source/WebCore/fileapi/AsyncFileStream.cpp:67:  Extra space before ( in function call  [whitespace/parens] [4]
ERROR: Source/WebCore/fileapi/AsyncFileStream.cpp:72:  Extra space before ( in function call  [whitespace/parens] [4]
ERROR: Source/WebCore/fileapi/AsyncFileStream.cpp:93:  Extra space before ( in function call  [whitespace/parens] [4]
ERROR: Source/WTF/wtf/win/WorkQueueWin.cpp:101:  Extra space before ( in function call  [whitespace/parens] [4]
ERROR: Source/WTF/wtf/win/WorkQueueWin.cpp:121:  Extra space before ( in function call  [whitespace/parens] [4]
ERROR: Source/WTF/wtf/win/WorkQueueWin.cpp:152:  Extra space before ( in function call  [whitespace/parens] [4]
ERROR: Source/WTF/wtf/glib/RunLoopGLib.cpp:127:  Extra space before ( in function call  [whitespace/parens] [4]
ERROR: Source/WTF/wtf/glib/RunLoopGLib.cpp:138:  Extra space before ( in function call  [whitespace/parens] [4]
ERROR: Source/WTF/wtf/glib/RunLoopGLib.cpp:141:  Extra space before ( in function call  [whitespace/parens] [4]
ERROR: Source/WebKit2/NetworkProcess/cache/NetworkCacheIOChannelSoup.cpp:72:  Extra space before ( in function call  [whitespace/parens] [4]
ERROR: Source/WebKit2/NetworkProcess/FileAPI/NetworkBlobRegistry.h:57:  Extra space before ( in function call  [whitespace/parens] [4]
ERROR: Source/WebCore/page/scrolling/ScrollingThread.h:51:  Extra space before ( in function call  [whitespace/parens] [4]
ERROR: Source/WebCore/page/scrolling/ScrollingThread.h:55:  Extra space before ( in function call  [whitespace/parens] [4]
ERROR: Source/WebCore/page/scrolling/ScrollingThread.h:83:  Extra space before ( in function call  [whitespace/parens] [4]
ERROR: Source/WebCore/platform/graphics/avfoundation/objc/MediaPlayerPrivateMediaStreamAVFObjC.mm:627:  Extra space before ( in function call  [whitespace/parens] [4]
ERROR: Source/WTF/wtf/efl/WorkQueueEfl.cpp:57:  Extra space before ( in function call  [whitespace/parens] [4]
ERROR: Source/WTF/wtf/efl/WorkQueueEfl.cpp:65:  Extra space before ( in function call  [whitespace/parens] [4]
ERROR: Source/WebKit2/NetworkProcess/NetworkProcess.cpp:296:  Extra space before ( in function call  [whitespace/parens] [4]
ERROR: Source/WebKit2/NetworkProcess/NetworkProcess.cpp:311:  Extra space before ( in function call  [whitespace/parens] [4]
ERROR: Source/WebKit2/NetworkProcess/NetworkProcess.cpp:355:  Extra space before ( in function call  [whitespace/parens] [4]
ERROR: Source/WebKit2/NetworkProcess/NetworkProcess.cpp:369:  Extra space before ( in function call  [whitespace/parens] [4]
ERROR: Source/WebKit2/NetworkProcess/NetworkProcess.cpp:415:  Extra space before ( in function call  [whitespace/parens] [4]
ERROR: Source/WebCore/Modules/mediastream/MediaEndpointPeerConnection.h:86:  Extra space before ( in function call  [whitespace/parens] [4]
ERROR: Source/WebCore/Modules/mediastream/MediaEndpointPeerConnection.h:114:  Extra space before ( in function call  [whitespace/parens] [4]
ERROR: Source/WebCore/Modules/mediastream/MediaEndpointPeerConnection.cpp:110:  Extra space before ( in function call  [whitespace/parens] [4]
ERROR: Source/WebCore/dom/ScriptExecutionContext.h:141:  Extra space before ( in function call  [whitespace/parens] [4]
ERROR: Source/WebCore/dom/ScriptExecutionContext.h:148:  Extra space before ( in function call  [whitespace/parens] [4]
ERROR: Source/WebCore/dom/ScriptExecutionContext.h:154:  Extra space before ( in function call  [whitespace/parens] [4]
ERROR: Source/WebCore/dom/ScriptExecutionContext.h:165:  Extra space before ( in function call  [whitespace/parens] [4]
ERROR: Source/WTF/wtf/generic/RunLoopGeneric.cpp:35:  Extra space before ( in function call  [whitespace/parens] [4]
ERROR: Source/WTF/wtf/generic/RunLoopGeneric.cpp:40:  Extra space before ( in function call  [whitespace/parens] [4]
ERROR: Source/WTF/wtf/generic/RunLoopGeneric.cpp:93:  Extra space before ( in function call  [whitespace/parens] [4]
ERROR: Source/WTF/wtf/generic/RunLoopGeneric.cpp:240:  Extra space before ( in function call  [whitespace/parens] [4]
ERROR: Source/WebKit2/NetworkProcess/cache/NetworkCache.h:109:  Extra space before ( in function call  [whitespace/parens] [4]
ERROR: Source/WebKit2/NetworkProcess/cache/NetworkCache.h:117:  Extra space before ( in function call  [whitespace/parens] [4]
ERROR: Source/WebCore/platform/network/BlobRegistryImpl.cpp:255:  Extra space before ( in function call  [whitespace/parens] [4]
ERROR: Source/WebCore/platform/graphics/avfoundation/objc/MediaPlayerPrivateMediaStreamAVFObjC.h:146:  Extra space before ( in function call  [whitespace/parens] [4]
ERROR: Source/WTF/wtf/generic/WorkQueueGeneric.cpp:84:  Extra space before ( in function call  [whitespace/parens] [4]
ERROR: Source/WTF/wtf/generic/WorkQueueGeneric.cpp:92:  Extra space before ( in function call  [whitespace/parens] [4]
ERROR: Source/WTF/wtf/CrossThreadTask.h:38:  Extra space before ( in function call  [whitespace/parens] [4]
ERROR: Source/WTF/wtf/CrossThreadTask.h:50:  Extra space before ( in function call  [whitespace/parens] [4]
ERROR: Source/WTF/wtf/FunctionDispatcher.h:42:  Extra space before ( in function call  [whitespace/parens] [4]
ERROR: Source/WebCore/page/scrolling/ScrollingThread.cpp:48:  Extra space before ( in function call  [whitespace/parens] [4]
ERROR: Source/WebCore/page/scrolling/ScrollingThread.cpp:61:  Extra space before ( in function call  [whitespace/parens] [4]
ERROR: Source/WebCore/page/scrolling/ScrollingThread.cpp:107:  Extra space before ( in function call  [whitespace/parens] [4]
ERROR: Source/WebCore/Modules/webaudio/DefaultAudioDestinationNode.h:53:  Extra space before ( in function call  [whitespace/parens] [4]
ERROR: Source/WebCore/Modules/webaudio/DefaultAudioDestinationNode.h:54:  Extra space before ( in function call  [whitespace/parens] [4]
ERROR: Source/WebCore/Modules/webaudio/DefaultAudioDestinationNode.h:55:  Extra space before ( in function call  [whitespace/parens] [4]
ERROR: Source/WebCore/Modules/webaudio/AudioDestinationNode.h:62:  Extra space before ( in function call  [whitespace/parens] [4]
ERROR: Source/WebCore/Modules/webaudio/AudioDestinationNode.h:63:  Extra space before ( in function call  [whitespace/parens] [4]
ERROR: Source/WebCore/Modules/webaudio/AudioDestinationNode.h:64:  Extra space before ( in function call  [whitespace/parens] [4]
ERROR: Source/WTF/wtf/RunLoop.cpp:94:  Extra space before ( in function call  [whitespace/parens] [4]
ERROR: Source/WTF/wtf/RunLoop.cpp:109:  Extra space before ( in function call  [whitespace/parens] [4]
ERROR: Source/WTF/wtf/RunLoop.cpp:126:  Extra space before ( in function call  [whitespace/parens] [4]
ERROR: Source/WTF/wtf/cocoa/WorkQueueCocoa.cpp:31:  Extra space before ( in function call  [whitespace/parens] [4]
ERROR: Source/WTF/wtf/cocoa/WorkQueueCocoa.cpp:42:  Extra space before ( in function call  [whitespace/parens] [4]
ERROR: Source/WebKit2/NetworkProcess/cache/NetworkCache.cpp:385:  Extra space before ( in function call  [whitespace/parens] [4]
ERROR: Source/WebKit2/NetworkProcess/cache/NetworkCache.cpp:483:  Extra space before ( in function call  [whitespace/parens] [4]
ERROR: Source/WebCore/bindings/js/SerializedScriptValue.h:90:  Extra space before ( in function call  [whitespace/parens] [4]
ERROR: Source/WTF/wtf/RunLoop.h:62:  Extra space before ( in function call  [whitespace/parens] [4]
ERROR: Source/WTF/wtf/RunLoop.h:82:  Extra space before ( in function call  [whitespace/parens] [4]
ERROR: Source/WTF/wtf/RunLoop.h:158:  Extra space before ( in function call  [whitespace/parens] [4]
ERROR: Source/WebCore/style/StyleTreeResolver.h:112:  Extra space before ( in function call  [whitespace/parens] [4]
ERROR: Source/WebCore/platform/mediastream/MediaStreamPrivate.cpp:302:  Extra space before ( in function call  [whitespace/parens] [4]
ERROR: Source/WTF/wtf/MainThread.h:44:  Extra space before ( in function call  [whitespace/parens] [4]
ERROR: Source/WebKit/Storage/StorageThread.h:48:  Extra space before ( in function call  [whitespace/parens] [4]
ERROR: Source/WebKit/Storage/StorageThread.h:61:  Extra space before ( in function call  [whitespace/parens] [4]
ERROR: Source/WebCore/platform/network/BlobRegistry.h:70:  Extra space before ( in function call  [whitespace/parens] [4]
ERROR: Source/WebKit2/WebProcess/Network/NetworkProcessConnection.h:61:  Extra space before ( in function call  [whitespace/parens] [4]
ERROR: Source/WebKit2/WebProcess/Network/NetworkProcessConnection.h:84:  Extra space before ( in function call  [whitespace/parens] [4]
ERROR: Source/WebCore/style/StyleTreeResolver.cpp:535:  Extra space before ( in function call  [whitespace/parens] [4]
ERROR: Source/WebCore/style/StyleTreeResolver.cpp:537:  Extra space before ( in function call  [whitespace/parens] [4]
ERROR: Source/WebCore/style/StyleTreeResolver.cpp:541:  Extra space before ( in function call  [whitespace/parens] [4]
ERROR: Source/WebKit/Storage/StorageThread.cpp:77:  Extra space before ( in function call  [whitespace/parens] [4]
ERROR: Source/WebKit/Storage/StorageThread.cpp:81:  Extra space before ( in function call  [whitespace/parens] [4]
ERROR: Source/WebKit/Storage/StorageThread.cpp:93:  Extra space before ( in function call  [whitespace/parens] [4]
ERROR: Source/WebCore/bindings/js/SerializedScriptValue.cpp:2801:  Extra space before ( in function call  [whitespace/parens] [4]
ERROR: Source/WebCore/platform/mediastream/mac/AVMediaCaptureSource.h:89:  Extra space before ( in function call  [whitespace/parens] [4]
ERROR: Source/WebCore/platform/network/BlobRegistryImpl.h:70:  Extra space before ( in function call  [whitespace/parens] [4]
ERROR: Source/WebCore/platform/mediastream/MediaStreamPrivate.h:115:  Extra space before ( in function call  [whitespace/parens] [4]
ERROR: Source/WebKit/Storage/StorageSyncManager.h:46:  Extra space before ( in function call  [whitespace/parens] [4]
ERROR: Source/WebKit/Storage/StorageSyncManager.cpp:66:  Extra space before ( in function call  [whitespace/parens] [4]
ERROR: Source/WTF/wtf/efl/DispatchQueueWorkItemEfl.h:37:  Extra space before ( in function call  [whitespace/parens] [4]
ERROR: Source/WTF/wtf/efl/DispatchQueueWorkItemEfl.h:47:  Extra space before ( in function call  [whitespace/parens] [4]
ERROR: Source/WTF/wtf/efl/DispatchQueueWorkItemEfl.h:52:  Extra space before ( in function call  [whitespace/parens] [4]
ERROR: Source/WTF/wtf/efl/DispatchQueueWorkItemEfl.h:61:  Extra space before ( in function call  [whitespace/parens] [4]
Total errors found: 100 in 66 files


If any of these errors are false positives, please file a bug against check-webkit-style.

Comment 31 Anders Carlsson 2016-06-22 14:05:57 PDT

Created attachment 281867 [details]
Patch

Comment 32 WebKit Commit Bot 2016-06-22 14:08:36 PDT

Attachment 281867 [details] did not pass style-queue:


ERROR: Source/WebKit2/WebProcess/FileAPI/BlobRegistryProxy.cpp:84:  Extra space before ( in function call  [whitespace/parens] [4]
ERROR: Source/WebKit2/WebProcess/Network/NetworkProcessConnection.cpp:88:  Extra space before ( in function call  [whitespace/parens] [4]
ERROR: Source/WebKit2/WebProcess/FileAPI/BlobRegistryProxy.h:42:  Extra space before ( in function call  [whitespace/parens] [4]
ERROR: Source/WebKit2/NetworkProcess/NetworkProcess.h:116:  Extra space before ( in function call  [whitespace/parens] [4]
ERROR: Source/WebKit2/NetworkProcess/NetworkProcess.h:208:  Extra space before ( in function call  [whitespace/parens] [4]
ERROR: Source/WebCore/platform/mediastream/mac/AVMediaCaptureSource.mm:243:  Extra space before ( in function call  [whitespace/parens] [4]
ERROR: Source/WebCore/Modules/webaudio/DefaultAudioDestinationNode.cpp:109:  Extra space before ( in function call  [whitespace/parens] [4]
ERROR: Source/WebCore/Modules/webaudio/DefaultAudioDestinationNode.cpp:118:  Extra space before ( in function call  [whitespace/parens] [4]
ERROR: Source/WTF/wtf/MainThread.cpp:50:  Extra space before ( in function call  [whitespace/parens] [4]
ERROR: Source/WTF/wtf/MainThread.cpp:52:  Extra space before ( in function call  [whitespace/parens] [4]
ERROR: Source/WTF/wtf/MainThread.cpp:123:  Extra space before ( in function call  [whitespace/parens] [4]
ERROR: Source/WTF/wtf/MainThread.cpp:147:  Extra space before ( in function call  [whitespace/parens] [4]
ERROR: Source/WTF/wtf/WorkQueue.h:73:  Extra space before ( in function call  [whitespace/parens] [4]
ERROR: Source/WTF/wtf/WorkQueue.h:74:  Extra space before ( in function call  [whitespace/parens] [4]
ERROR: Source/WebCore/fileapi/AsyncFileStream.cpp:67:  Extra space before ( in function call  [whitespace/parens] [4]
ERROR: Source/WebCore/fileapi/AsyncFileStream.cpp:72:  Extra space before ( in function call  [whitespace/parens] [4]
ERROR: Source/WebCore/fileapi/AsyncFileStream.cpp:93:  Extra space before ( in function call  [whitespace/parens] [4]
ERROR: Source/WTF/wtf/win/WorkQueueWin.cpp:101:  Extra space before ( in function call  [whitespace/parens] [4]
ERROR: Source/WTF/wtf/win/WorkQueueWin.cpp:121:  Extra space before ( in function call  [whitespace/parens] [4]
ERROR: Source/WTF/wtf/win/WorkQueueWin.cpp:152:  Extra space before ( in function call  [whitespace/parens] [4]
ERROR: Source/WTF/wtf/glib/RunLoopGLib.cpp:127:  Extra space before ( in function call  [whitespace/parens] [4]
ERROR: Source/WTF/wtf/glib/RunLoopGLib.cpp:138:  Extra space before ( in function call  [whitespace/parens] [4]
ERROR: Source/WTF/wtf/glib/RunLoopGLib.cpp:141:  Extra space before ( in function call  [whitespace/parens] [4]
ERROR: Source/WebKit2/NetworkProcess/cache/NetworkCacheIOChannelSoup.cpp:72:  Extra space before ( in function call  [whitespace/parens] [4]
ERROR: Source/WebKit2/NetworkProcess/FileAPI/NetworkBlobRegistry.h:57:  Extra space before ( in function call  [whitespace/parens] [4]
ERROR: Source/WebCore/page/scrolling/ScrollingThread.h:51:  Extra space before ( in function call  [whitespace/parens] [4]
ERROR: Source/WebCore/page/scrolling/ScrollingThread.h:55:  Extra space before ( in function call  [whitespace/parens] [4]
ERROR: Source/WebCore/page/scrolling/ScrollingThread.h:83:  Extra space before ( in function call  [whitespace/parens] [4]
ERROR: Source/WebCore/platform/graphics/avfoundation/objc/MediaPlayerPrivateMediaStreamAVFObjC.mm:627:  Extra space before ( in function call  [whitespace/parens] [4]
ERROR: Source/WTF/wtf/efl/WorkQueueEfl.cpp:57:  Extra space before ( in function call  [whitespace/parens] [4]
ERROR: Source/WTF/wtf/efl/WorkQueueEfl.cpp:65:  Extra space before ( in function call  [whitespace/parens] [4]
ERROR: Source/WebKit2/NetworkProcess/NetworkProcess.cpp:296:  Extra space before ( in function call  [whitespace/parens] [4]
ERROR: Source/WebKit2/NetworkProcess/NetworkProcess.cpp:311:  Extra space before ( in function call  [whitespace/parens] [4]
ERROR: Source/WebKit2/NetworkProcess/NetworkProcess.cpp:355:  Extra space before ( in function call  [whitespace/parens] [4]
ERROR: Source/WebKit2/NetworkProcess/NetworkProcess.cpp:369:  Extra space before ( in function call  [whitespace/parens] [4]
ERROR: Source/WebKit2/NetworkProcess/NetworkProcess.cpp:415:  Extra space before ( in function call  [whitespace/parens] [4]
ERROR: Source/WebCore/Modules/mediastream/MediaEndpointPeerConnection.h:86:  Extra space before ( in function call  [whitespace/parens] [4]
ERROR: Source/WebCore/Modules/mediastream/MediaEndpointPeerConnection.h:114:  Extra space before ( in function call  [whitespace/parens] [4]
ERROR: Source/WebCore/Modules/mediastream/MediaEndpointPeerConnection.cpp:110:  Extra space before ( in function call  [whitespace/parens] [4]
ERROR: Source/WebCore/dom/ScriptExecutionContext.h:141:  Extra space before ( in function call  [whitespace/parens] [4]
ERROR: Source/WebCore/dom/ScriptExecutionContext.h:148:  Extra space before ( in function call  [whitespace/parens] [4]
ERROR: Source/WebCore/dom/ScriptExecutionContext.h:154:  Extra space before ( in function call  [whitespace/parens] [4]
ERROR: Source/WebCore/dom/ScriptExecutionContext.h:165:  Extra space before ( in function call  [whitespace/parens] [4]
ERROR: Source/WTF/wtf/generic/RunLoopGeneric.cpp:35:  Extra space before ( in function call  [whitespace/parens] [4]
ERROR: Source/WTF/wtf/generic/RunLoopGeneric.cpp:40:  Extra space before ( in function call  [whitespace/parens] [4]
ERROR: Source/WTF/wtf/generic/RunLoopGeneric.cpp:93:  Extra space before ( in function call  [whitespace/parens] [4]
ERROR: Source/WTF/wtf/generic/RunLoopGeneric.cpp:240:  Extra space before ( in function call  [whitespace/parens] [4]
ERROR: Source/WebKit2/NetworkProcess/cache/NetworkCache.h:109:  Extra space before ( in function call  [whitespace/parens] [4]
ERROR: Source/WebKit2/NetworkProcess/cache/NetworkCache.h:117:  Extra space before ( in function call  [whitespace/parens] [4]
ERROR: Source/WebCore/platform/network/BlobRegistryImpl.cpp:255:  Extra space before ( in function call  [whitespace/parens] [4]
ERROR: Source/WebCore/platform/graphics/avfoundation/objc/MediaPlayerPrivateMediaStreamAVFObjC.h:146:  Extra space before ( in function call  [whitespace/parens] [4]
ERROR: Source/WTF/wtf/generic/WorkQueueGeneric.cpp:84:  Extra space before ( in function call  [whitespace/parens] [4]
ERROR: Source/WTF/wtf/generic/WorkQueueGeneric.cpp:92:  Extra space before ( in function call  [whitespace/parens] [4]
ERROR: Source/WTF/wtf/CrossThreadTask.h:38:  Extra space before ( in function call  [whitespace/parens] [4]
ERROR: Source/WTF/wtf/CrossThreadTask.h:50:  Extra space before ( in function call  [whitespace/parens] [4]
ERROR: Source/WTF/wtf/FunctionDispatcher.h:42:  Extra space before ( in function call  [whitespace/parens] [4]
ERROR: Source/WebCore/page/scrolling/ScrollingThread.cpp:48:  Extra space before ( in function call  [whitespace/parens] [4]
ERROR: Source/WebCore/page/scrolling/ScrollingThread.cpp:61:  Extra space before ( in function call  [whitespace/parens] [4]
ERROR: Source/WebCore/page/scrolling/ScrollingThread.cpp:107:  Extra space before ( in function call  [whitespace/parens] [4]
ERROR: Source/WebCore/Modules/webaudio/DefaultAudioDestinationNode.h:53:  Extra space before ( in function call  [whitespace/parens] [4]
ERROR: Source/WebCore/Modules/webaudio/DefaultAudioDestinationNode.h:54:  Extra space before ( in function call  [whitespace/parens] [4]
ERROR: Source/WebCore/Modules/webaudio/DefaultAudioDestinationNode.h:55:  Extra space before ( in function call  [whitespace/parens] [4]
ERROR: Source/WebCore/Modules/webaudio/AudioDestinationNode.h:62:  Extra space before ( in function call  [whitespace/parens] [4]
ERROR: Source/WebCore/Modules/webaudio/AudioDestinationNode.h:63:  Extra space before ( in function call  [whitespace/parens] [4]
ERROR: Source/WebCore/Modules/webaudio/AudioDestinationNode.h:64:  Extra space before ( in function call  [whitespace/parens] [4]
ERROR: Source/WTF/wtf/RunLoop.cpp:94:  Extra space before ( in function call  [whitespace/parens] [4]
ERROR: Source/WTF/wtf/RunLoop.cpp:109:  Extra space before ( in function call  [whitespace/parens] [4]
ERROR: Source/WTF/wtf/RunLoop.cpp:126:  Extra space before ( in function call  [whitespace/parens] [4]
ERROR: Source/WTF/wtf/cocoa/WorkQueueCocoa.cpp:31:  Extra space before ( in function call  [whitespace/parens] [4]
ERROR: Source/WTF/wtf/cocoa/WorkQueueCocoa.cpp:42:  Extra space before ( in function call  [whitespace/parens] [4]
ERROR: Source/WebKit2/NetworkProcess/cache/NetworkCache.cpp:385:  Extra space before ( in function call  [whitespace/parens] [4]
ERROR: Source/WebKit2/NetworkProcess/cache/NetworkCache.cpp:483:  Extra space before ( in function call  [whitespace/parens] [4]
ERROR: Source/WebCore/bindings/js/SerializedScriptValue.h:90:  Extra space before ( in function call  [whitespace/parens] [4]
ERROR: Source/WTF/wtf/RunLoop.h:62:  Extra space before ( in function call  [whitespace/parens] [4]
ERROR: Source/WTF/wtf/RunLoop.h:82:  Extra space before ( in function call  [whitespace/parens] [4]
ERROR: Source/WTF/wtf/RunLoop.h:158:  Extra space before ( in function call  [whitespace/parens] [4]
ERROR: Source/WebCore/style/StyleTreeResolver.h:112:  Extra space before ( in function call  [whitespace/parens] [4]
ERROR: Source/WebCore/platform/mediastream/MediaStreamPrivate.cpp:302:  Extra space before ( in function call  [whitespace/parens] [4]
ERROR: Source/WTF/wtf/MainThread.h:44:  Extra space before ( in function call  [whitespace/parens] [4]
ERROR: Source/WebKit/Storage/StorageThread.h:48:  Extra space before ( in function call  [whitespace/parens] [4]
ERROR: Source/WebKit/Storage/StorageThread.h:61:  Extra space before ( in function call  [whitespace/parens] [4]
ERROR: Source/WebCore/platform/network/BlobRegistry.h:70:  Extra space before ( in function call  [whitespace/parens] [4]
ERROR: Source/WebKit2/WebProcess/Network/NetworkProcessConnection.h:61:  Extra space before ( in function call  [whitespace/parens] [4]
ERROR: Source/WebKit2/WebProcess/Network/NetworkProcessConnection.h:84:  Extra space before ( in function call  [whitespace/parens] [4]
ERROR: Source/WebCore/style/StyleTreeResolver.cpp:535:  Extra space before ( in function call  [whitespace/parens] [4]
ERROR: Source/WebCore/style/StyleTreeResolver.cpp:537:  Extra space before ( in function call  [whitespace/parens] [4]
ERROR: Source/WebCore/style/StyleTreeResolver.cpp:541:  Extra space before ( in function call  [whitespace/parens] [4]
ERROR: Source/WebKit/Storage/StorageThread.cpp:77:  Extra space before ( in function call  [whitespace/parens] [4]
ERROR: Source/WebKit/Storage/StorageThread.cpp:81:  Extra space before ( in function call  [whitespace/parens] [4]
ERROR: Source/WebKit/Storage/StorageThread.cpp:93:  Extra space before ( in function call  [whitespace/parens] [4]
ERROR: Source/WebCore/bindings/js/SerializedScriptValue.cpp:2801:  Extra space before ( in function call  [whitespace/parens] [4]
ERROR: Source/WebCore/platform/mediastream/mac/AVMediaCaptureSource.h:89:  Extra space before ( in function call  [whitespace/parens] [4]
ERROR: Source/WebCore/platform/network/BlobRegistryImpl.h:70:  Extra space before ( in function call  [whitespace/parens] [4]
ERROR: Source/WebCore/platform/mediastream/MediaStreamPrivate.h:115:  Extra space before ( in function call  [whitespace/parens] [4]
ERROR: Source/WebKit/Storage/StorageSyncManager.h:46:  Extra space before ( in function call  [whitespace/parens] [4]
ERROR: Source/WebKit/Storage/StorageSyncManager.cpp:66:  Extra space before ( in function call  [whitespace/parens] [4]
ERROR: Source/WTF/wtf/efl/DispatchQueueWorkItemEfl.h:37:  Extra space before ( in function call  [whitespace/parens] [4]
ERROR: Source/WTF/wtf/efl/DispatchQueueWorkItemEfl.h:47:  Extra space before ( in function call  [whitespace/parens] [4]
ERROR: Source/WTF/wtf/efl/DispatchQueueWorkItemEfl.h:52:  Extra space before ( in function call  [whitespace/parens] [4]
ERROR: Source/WTF/wtf/efl/DispatchQueueWorkItemEfl.h:61:  Extra space before ( in function call  [whitespace/parens] [4]
Total errors found: 100 in 66 files


If any of these errors are false positives, please file a bug against check-webkit-style.

Comment 33 Anders Carlsson 2016-06-24 10:09:49 PDT

Created attachment 281995 [details]
Patch

Comment 34 WebKit Commit Bot 2016-06-24 10:11:27 PDT

Attachment 281995 [details] did not pass style-queue:


ERROR: Source/WebKit2/WebProcess/FileAPI/BlobRegistryProxy.cpp:84:  Extra space before ( in function call  [whitespace/parens] [4]
ERROR: Source/WebKit2/WebProcess/Network/NetworkProcessConnection.cpp:88:  Extra space before ( in function call  [whitespace/parens] [4]
ERROR: Source/WebKit2/WebProcess/FileAPI/BlobRegistryProxy.h:42:  Extra space before ( in function call  [whitespace/parens] [4]
ERROR: Source/WebKit2/NetworkProcess/NetworkProcess.h:116:  Extra space before ( in function call  [whitespace/parens] [4]
ERROR: Source/WebKit2/NetworkProcess/NetworkProcess.h:208:  Extra space before ( in function call  [whitespace/parens] [4]
ERROR: Source/WebCore/platform/mediastream/mac/AVMediaCaptureSource.mm:243:  Extra space before ( in function call  [whitespace/parens] [4]
ERROR: Source/WebCore/Modules/webaudio/DefaultAudioDestinationNode.cpp:109:  Extra space before ( in function call  [whitespace/parens] [4]
ERROR: Source/WebCore/Modules/webaudio/DefaultAudioDestinationNode.cpp:118:  Extra space before ( in function call  [whitespace/parens] [4]
ERROR: Source/WTF/wtf/MainThread.cpp:50:  Extra space before ( in function call  [whitespace/parens] [4]
ERROR: Source/WTF/wtf/MainThread.cpp:52:  Extra space before ( in function call  [whitespace/parens] [4]
ERROR: Source/WTF/wtf/MainThread.cpp:123:  Extra space before ( in function call  [whitespace/parens] [4]
ERROR: Source/WTF/wtf/MainThread.cpp:147:  Extra space before ( in function call  [whitespace/parens] [4]
ERROR: Source/WTF/wtf/WorkQueue.h:73:  Extra space before ( in function call  [whitespace/parens] [4]
ERROR: Source/WTF/wtf/WorkQueue.h:74:  Extra space before ( in function call  [whitespace/parens] [4]
ERROR: Source/WTF/wtf/WorkQueue.h:111:  Extra space before ( in function call  [whitespace/parens] [4]
ERROR: Source/WebCore/fileapi/AsyncFileStream.cpp:67:  Extra space before ( in function call  [whitespace/parens] [4]
ERROR: Source/WebCore/fileapi/AsyncFileStream.cpp:72:  Extra space before ( in function call  [whitespace/parens] [4]
ERROR: Source/WebCore/fileapi/AsyncFileStream.cpp:93:  Extra space before ( in function call  [whitespace/parens] [4]
ERROR: Source/WTF/wtf/win/WorkQueueWin.cpp:54:  Extra space before ( in function call  [whitespace/parens] [4]
ERROR: Source/WTF/wtf/win/WorkQueueWin.cpp:101:  Extra space before ( in function call  [whitespace/parens] [4]
ERROR: Source/WTF/wtf/win/WorkQueueWin.cpp:121:  Extra space before ( in function call  [whitespace/parens] [4]
ERROR: Source/WTF/wtf/win/WorkQueueWin.cpp:152:  Extra space before ( in function call  [whitespace/parens] [4]
ERROR: Source/WTF/wtf/glib/RunLoopGLib.cpp:127:  Extra space before ( in function call  [whitespace/parens] [4]
ERROR: Source/WTF/wtf/glib/RunLoopGLib.cpp:138:  Extra space before ( in function call  [whitespace/parens] [4]
ERROR: Source/WTF/wtf/glib/RunLoopGLib.cpp:141:  Extra space before ( in function call  [whitespace/parens] [4]
ERROR: Source/WebKit2/NetworkProcess/cache/NetworkCacheIOChannelSoup.cpp:72:  Extra space before ( in function call  [whitespace/parens] [4]
ERROR: Source/WebKit2/NetworkProcess/FileAPI/NetworkBlobRegistry.h:57:  Extra space before ( in function call  [whitespace/parens] [4]
ERROR: Source/WebCore/page/scrolling/ScrollingThread.h:51:  Extra space before ( in function call  [whitespace/parens] [4]
ERROR: Source/WebCore/page/scrolling/ScrollingThread.h:55:  Extra space before ( in function call  [whitespace/parens] [4]
ERROR: Source/WebCore/page/scrolling/ScrollingThread.h:83:  Extra space before ( in function call  [whitespace/parens] [4]
ERROR: Source/WebCore/platform/graphics/avfoundation/objc/MediaPlayerPrivateMediaStreamAVFObjC.mm:627:  Extra space before ( in function call  [whitespace/parens] [4]
ERROR: Source/WTF/wtf/efl/WorkQueueEfl.cpp:57:  Extra space before ( in function call  [whitespace/parens] [4]
ERROR: Source/WTF/wtf/efl/WorkQueueEfl.cpp:65:  Extra space before ( in function call  [whitespace/parens] [4]
ERROR: Source/WebKit2/NetworkProcess/NetworkProcess.cpp:296:  Extra space before ( in function call  [whitespace/parens] [4]
ERROR: Source/WebKit2/NetworkProcess/NetworkProcess.cpp:311:  Extra space before ( in function call  [whitespace/parens] [4]
ERROR: Source/WebKit2/NetworkProcess/NetworkProcess.cpp:355:  Extra space before ( in function call  [whitespace/parens] [4]
ERROR: Source/WebKit2/NetworkProcess/NetworkProcess.cpp:369:  Extra space before ( in function call  [whitespace/parens] [4]
ERROR: Source/WebKit2/NetworkProcess/NetworkProcess.cpp:415:  Extra space before ( in function call  [whitespace/parens] [4]
ERROR: Source/WebCore/Modules/mediastream/MediaEndpointPeerConnection.h:88:  Extra space before ( in function call  [whitespace/parens] [4]
ERROR: Source/WebCore/Modules/mediastream/MediaEndpointPeerConnection.h:116:  Extra space before ( in function call  [whitespace/parens] [4]
ERROR: Source/WebCore/Modules/mediastream/MediaEndpointPeerConnection.cpp:111:  Extra space before ( in function call  [whitespace/parens] [4]
ERROR: Source/WebCore/dom/ScriptExecutionContext.h:141:  Extra space before ( in function call  [whitespace/parens] [4]
ERROR: Source/WebCore/dom/ScriptExecutionContext.h:148:  Extra space before ( in function call  [whitespace/parens] [4]
ERROR: Source/WebCore/dom/ScriptExecutionContext.h:154:  Extra space before ( in function call  [whitespace/parens] [4]
ERROR: Source/WebCore/dom/ScriptExecutionContext.h:165:  Extra space before ( in function call  [whitespace/parens] [4]
ERROR: Source/WTF/wtf/generic/RunLoopGeneric.cpp:35:  Extra space before ( in function call  [whitespace/parens] [4]
ERROR: Source/WTF/wtf/generic/RunLoopGeneric.cpp:40:  Extra space before ( in function call  [whitespace/parens] [4]
ERROR: Source/WTF/wtf/generic/RunLoopGeneric.cpp:93:  Extra space before ( in function call  [whitespace/parens] [4]
ERROR: Source/WTF/wtf/generic/RunLoopGeneric.cpp:240:  Extra space before ( in function call  [whitespace/parens] [4]
ERROR: Source/WebKit2/NetworkProcess/cache/NetworkCache.h:109:  Extra space before ( in function call  [whitespace/parens] [4]
ERROR: Source/WebKit2/NetworkProcess/cache/NetworkCache.h:117:  Extra space before ( in function call  [whitespace/parens] [4]
ERROR: Source/WebCore/platform/network/BlobRegistryImpl.cpp:255:  Extra space before ( in function call  [whitespace/parens] [4]
ERROR: Source/WebCore/platform/graphics/avfoundation/objc/MediaPlayerPrivateMediaStreamAVFObjC.h:146:  Extra space before ( in function call  [whitespace/parens] [4]
ERROR: Source/WTF/wtf/generic/WorkQueueGeneric.cpp:84:  Extra space before ( in function call  [whitespace/parens] [4]
ERROR: Source/WTF/wtf/generic/WorkQueueGeneric.cpp:92:  Extra space before ( in function call  [whitespace/parens] [4]
ERROR: Source/WTF/wtf/CrossThreadTask.h:38:  Extra space before ( in function call  [whitespace/parens] [4]
ERROR: Source/WTF/wtf/CrossThreadTask.h:50:  Extra space before ( in function call  [whitespace/parens] [4]
ERROR: Source/WTF/wtf/FunctionDispatcher.h:42:  Extra space before ( in function call  [whitespace/parens] [4]
ERROR: Source/WebCore/page/scrolling/ScrollingThread.cpp:48:  Extra space before ( in function call  [whitespace/parens] [4]
ERROR: Source/WebCore/page/scrolling/ScrollingThread.cpp:61:  Extra space before ( in function call  [whitespace/parens] [4]
ERROR: Source/WebCore/page/scrolling/ScrollingThread.cpp:107:  Extra space before ( in function call  [whitespace/parens] [4]
ERROR: Source/WebCore/Modules/webaudio/DefaultAudioDestinationNode.h:53:  Extra space before ( in function call  [whitespace/parens] [4]
ERROR: Source/WebCore/Modules/webaudio/DefaultAudioDestinationNode.h:54:  Extra space before ( in function call  [whitespace/parens] [4]
ERROR: Source/WebCore/Modules/webaudio/DefaultAudioDestinationNode.h:55:  Extra space before ( in function call  [whitespace/parens] [4]
ERROR: Source/WebCore/Modules/webaudio/AudioDestinationNode.h:62:  Extra space before ( in function call  [whitespace/parens] [4]
ERROR: Source/WebCore/Modules/webaudio/AudioDestinationNode.h:63:  Extra space before ( in function call  [whitespace/parens] [4]
ERROR: Source/WebCore/Modules/webaudio/AudioDestinationNode.h:64:  Extra space before ( in function call  [whitespace/parens] [4]
ERROR: Source/WTF/wtf/RunLoop.cpp:94:  Extra space before ( in function call  [whitespace/parens] [4]
ERROR: Source/WTF/wtf/RunLoop.cpp:109:  Extra space before ( in function call  [whitespace/parens] [4]
ERROR: Source/WTF/wtf/RunLoop.cpp:126:  Extra space before ( in function call  [whitespace/parens] [4]
ERROR: Source/WTF/wtf/cocoa/WorkQueueCocoa.cpp:31:  Extra space before ( in function call  [whitespace/parens] [4]
ERROR: Source/WTF/wtf/cocoa/WorkQueueCocoa.cpp:42:  Extra space before ( in function call  [whitespace/parens] [4]
ERROR: Source/WebKit2/NetworkProcess/cache/NetworkCache.cpp:385:  Extra space before ( in function call  [whitespace/parens] [4]
ERROR: Source/WebKit2/NetworkProcess/cache/NetworkCache.cpp:483:  Extra space before ( in function call  [whitespace/parens] [4]
ERROR: Source/WebCore/bindings/js/SerializedScriptValue.h:90:  Extra space before ( in function call  [whitespace/parens] [4]
ERROR: Source/WTF/wtf/RunLoop.h:62:  Extra space before ( in function call  [whitespace/parens] [4]
ERROR: Source/WTF/wtf/RunLoop.h:82:  Extra space before ( in function call  [whitespace/parens] [4]
ERROR: Source/WTF/wtf/RunLoop.h:158:  Extra space before ( in function call  [whitespace/parens] [4]
ERROR: Source/WebCore/style/StyleTreeResolver.h:112:  Extra space before ( in function call  [whitespace/parens] [4]
ERROR: Source/WebCore/platform/mediastream/MediaStreamPrivate.cpp:302:  Extra space before ( in function call  [whitespace/parens] [4]
ERROR: Source/WTF/wtf/MainThread.h:44:  Extra space before ( in function call  [whitespace/parens] [4]
ERROR: Source/WebKit/Storage/StorageThread.h:48:  Extra space before ( in function call  [whitespace/parens] [4]
ERROR: Source/WebKit/Storage/StorageThread.h:61:  Extra space before ( in function call  [whitespace/parens] [4]
ERROR: Source/WebCore/platform/network/BlobRegistry.h:70:  Extra space before ( in function call  [whitespace/parens] [4]
ERROR: Source/WebKit2/WebProcess/Network/NetworkProcessConnection.h:61:  Extra space before ( in function call  [whitespace/parens] [4]
ERROR: Source/WebKit2/WebProcess/Network/NetworkProcessConnection.h:84:  Extra space before ( in function call  [whitespace/parens] [4]
ERROR: Source/WebCore/style/StyleTreeResolver.cpp:535:  Extra space before ( in function call  [whitespace/parens] [4]
ERROR: Source/WebCore/style/StyleTreeResolver.cpp:537:  Extra space before ( in function call  [whitespace/parens] [4]
ERROR: Source/WebCore/style/StyleTreeResolver.cpp:541:  Extra space before ( in function call  [whitespace/parens] [4]
ERROR: Source/WebKit/Storage/StorageThread.cpp:77:  Extra space before ( in function call  [whitespace/parens] [4]
ERROR: Source/WebKit/Storage/StorageThread.cpp:81:  Extra space before ( in function call  [whitespace/parens] [4]
ERROR: Source/WebKit/Storage/StorageThread.cpp:93:  Extra space before ( in function call  [whitespace/parens] [4]
ERROR: Source/WebCore/bindings/js/SerializedScriptValue.cpp:2801:  Extra space before ( in function call  [whitespace/parens] [4]
ERROR: Source/WebCore/platform/mediastream/mac/AVMediaCaptureSource.h:89:  Extra space before ( in function call  [whitespace/parens] [4]
ERROR: Source/WebCore/platform/network/BlobRegistryImpl.h:70:  Extra space before ( in function call  [whitespace/parens] [4]
ERROR: Source/WebCore/platform/mediastream/MediaStreamPrivate.h:115:  Extra space before ( in function call  [whitespace/parens] [4]
ERROR: Source/WebKit/Storage/StorageSyncManager.h:46:  Extra space before ( in function call  [whitespace/parens] [4]
ERROR: Source/WebKit/Storage/StorageSyncManager.cpp:66:  Extra space before ( in function call  [whitespace/parens] [4]
ERROR: Source/WTF/wtf/efl/DispatchQueueWorkItemEfl.h:37:  Extra space before ( in function call  [whitespace/parens] [4]
ERROR: Source/WTF/wtf/efl/DispatchQueueWorkItemEfl.h:47:  Extra space before ( in function call  [whitespace/parens] [4]
ERROR: Source/WTF/wtf/efl/DispatchQueueWorkItemEfl.h:52:  Extra space before ( in function call  [whitespace/parens] [4]
ERROR: Source/WTF/wtf/efl/DispatchQueueWorkItemEfl.h:61:  Extra space before ( in function call  [whitespace/parens] [4]
Total errors found: 102 in 66 files


If any of these errors are false positives, please file a bug against check-webkit-style.

Comment 35 Anders Carlsson 2016-06-24 11:30:10 PDT

Created attachment 282002 [details]
Patch

Comment 36 WebKit Commit Bot 2016-06-24 11:32:32 PDT

Attachment 282002 [details] did not pass style-queue:


ERROR: Source/WebKit2/WebProcess/FileAPI/BlobRegistryProxy.cpp:84:  Extra space before ( in function call  [whitespace/parens] [4]
ERROR: Source/WebKit2/WebProcess/Network/NetworkProcessConnection.cpp:88:  Extra space before ( in function call  [whitespace/parens] [4]
ERROR: Source/WebKit2/WebProcess/FileAPI/BlobRegistryProxy.h:42:  Extra space before ( in function call  [whitespace/parens] [4]
ERROR: Source/WebKit2/NetworkProcess/NetworkProcess.h:116:  Extra space before ( in function call  [whitespace/parens] [4]
ERROR: Source/WebKit2/NetworkProcess/NetworkProcess.h:208:  Extra space before ( in function call  [whitespace/parens] [4]
ERROR: Source/WebCore/platform/mediastream/mac/AVMediaCaptureSource.mm:243:  Extra space before ( in function call  [whitespace/parens] [4]
ERROR: Source/WebCore/Modules/webaudio/DefaultAudioDestinationNode.cpp:109:  Extra space before ( in function call  [whitespace/parens] [4]
ERROR: Source/WebCore/Modules/webaudio/DefaultAudioDestinationNode.cpp:118:  Extra space before ( in function call  [whitespace/parens] [4]
ERROR: Source/WTF/wtf/MainThread.cpp:50:  Extra space before ( in function call  [whitespace/parens] [4]
ERROR: Source/WTF/wtf/MainThread.cpp:52:  Extra space before ( in function call  [whitespace/parens] [4]
ERROR: Source/WTF/wtf/MainThread.cpp:123:  Extra space before ( in function call  [whitespace/parens] [4]
ERROR: Source/WTF/wtf/MainThread.cpp:147:  Extra space before ( in function call  [whitespace/parens] [4]
ERROR: Source/WTF/wtf/WorkQueue.h:73:  Extra space before ( in function call  [whitespace/parens] [4]
ERROR: Source/WTF/wtf/WorkQueue.h:74:  Extra space before ( in function call  [whitespace/parens] [4]
ERROR: Source/WTF/wtf/WorkQueue.h:111:  Extra space before ( in function call  [whitespace/parens] [4]
ERROR: Source/WebCore/fileapi/AsyncFileStream.cpp:67:  Extra space before ( in function call  [whitespace/parens] [4]
ERROR: Source/WebCore/fileapi/AsyncFileStream.cpp:72:  Extra space before ( in function call  [whitespace/parens] [4]
ERROR: Source/WebCore/fileapi/AsyncFileStream.cpp:93:  Extra space before ( in function call  [whitespace/parens] [4]
ERROR: Source/WTF/wtf/win/WorkQueueWin.cpp:54:  Extra space before ( in function call  [whitespace/parens] [4]
ERROR: Source/WTF/wtf/win/WorkQueueWin.cpp:101:  Extra space before ( in function call  [whitespace/parens] [4]
ERROR: Source/WTF/wtf/win/WorkQueueWin.cpp:121:  Extra space before ( in function call  [whitespace/parens] [4]
ERROR: Source/WTF/wtf/win/WorkQueueWin.cpp:152:  Extra space before ( in function call  [whitespace/parens] [4]
ERROR: Source/WTF/wtf/glib/RunLoopGLib.cpp:127:  Extra space before ( in function call  [whitespace/parens] [4]
ERROR: Source/WTF/wtf/glib/RunLoopGLib.cpp:138:  Extra space before ( in function call  [whitespace/parens] [4]
ERROR: Source/WTF/wtf/glib/RunLoopGLib.cpp:141:  Extra space before ( in function call  [whitespace/parens] [4]
ERROR: Source/WebKit2/NetworkProcess/cache/NetworkCacheIOChannelSoup.cpp:72:  Extra space before ( in function call  [whitespace/parens] [4]
ERROR: Source/WebKit2/NetworkProcess/FileAPI/NetworkBlobRegistry.h:57:  Extra space before ( in function call  [whitespace/parens] [4]
ERROR: Source/WebCore/page/scrolling/ScrollingThread.h:51:  Extra space before ( in function call  [whitespace/parens] [4]
ERROR: Source/WebCore/page/scrolling/ScrollingThread.h:55:  Extra space before ( in function call  [whitespace/parens] [4]
ERROR: Source/WebCore/page/scrolling/ScrollingThread.h:83:  Extra space before ( in function call  [whitespace/parens] [4]
ERROR: Source/WebCore/platform/graphics/avfoundation/objc/MediaPlayerPrivateMediaStreamAVFObjC.mm:627:  Extra space before ( in function call  [whitespace/parens] [4]
ERROR: Source/WTF/wtf/efl/WorkQueueEfl.cpp:57:  Extra space before ( in function call  [whitespace/parens] [4]
ERROR: Source/WTF/wtf/efl/WorkQueueEfl.cpp:65:  Extra space before ( in function call  [whitespace/parens] [4]
ERROR: Source/WebKit2/NetworkProcess/NetworkProcess.cpp:296:  Extra space before ( in function call  [whitespace/parens] [4]
ERROR: Source/WebKit2/NetworkProcess/NetworkProcess.cpp:311:  Extra space before ( in function call  [whitespace/parens] [4]
ERROR: Source/WebKit2/NetworkProcess/NetworkProcess.cpp:355:  Extra space before ( in function call  [whitespace/parens] [4]
ERROR: Source/WebKit2/NetworkProcess/NetworkProcess.cpp:369:  Extra space before ( in function call  [whitespace/parens] [4]
ERROR: Source/WebKit2/NetworkProcess/NetworkProcess.cpp:415:  Extra space before ( in function call  [whitespace/parens] [4]
ERROR: Source/WebCore/Modules/mediastream/MediaEndpointPeerConnection.h:88:  Extra space before ( in function call  [whitespace/parens] [4]
ERROR: Source/WebCore/Modules/mediastream/MediaEndpointPeerConnection.h:116:  Extra space before ( in function call  [whitespace/parens] [4]
ERROR: Source/WebCore/Modules/mediastream/MediaEndpointPeerConnection.cpp:111:  Extra space before ( in function call  [whitespace/parens] [4]
ERROR: Source/WebCore/dom/ScriptExecutionContext.h:141:  Extra space before ( in function call  [whitespace/parens] [4]
ERROR: Source/WebCore/dom/ScriptExecutionContext.h:148:  Extra space before ( in function call  [whitespace/parens] [4]
ERROR: Source/WebCore/dom/ScriptExecutionContext.h:154:  Extra space before ( in function call  [whitespace/parens] [4]
ERROR: Source/WebCore/dom/ScriptExecutionContext.h:165:  Extra space before ( in function call  [whitespace/parens] [4]
ERROR: Source/WTF/wtf/generic/RunLoopGeneric.cpp:35:  Extra space before ( in function call  [whitespace/parens] [4]
ERROR: Source/WTF/wtf/generic/RunLoopGeneric.cpp:40:  Extra space before ( in function call  [whitespace/parens] [4]
ERROR: Source/WTF/wtf/generic/RunLoopGeneric.cpp:93:  Extra space before ( in function call  [whitespace/parens] [4]
ERROR: Source/WTF/wtf/generic/RunLoopGeneric.cpp:240:  Extra space before ( in function call  [whitespace/parens] [4]
ERROR: Source/WebKit2/NetworkProcess/cache/NetworkCache.h:109:  Extra space before ( in function call  [whitespace/parens] [4]
ERROR: Source/WebKit2/NetworkProcess/cache/NetworkCache.h:117:  Extra space before ( in function call  [whitespace/parens] [4]
ERROR: Source/WebCore/platform/network/BlobRegistryImpl.cpp:255:  Extra space before ( in function call  [whitespace/parens] [4]
ERROR: Source/WebCore/platform/graphics/avfoundation/objc/MediaPlayerPrivateMediaStreamAVFObjC.h:146:  Extra space before ( in function call  [whitespace/parens] [4]
ERROR: Source/WTF/wtf/generic/WorkQueueGeneric.cpp:84:  Extra space before ( in function call  [whitespace/parens] [4]
ERROR: Source/WTF/wtf/generic/WorkQueueGeneric.cpp:92:  Extra space before ( in function call  [whitespace/parens] [4]
ERROR: Source/WTF/wtf/CrossThreadTask.h:38:  Extra space before ( in function call  [whitespace/parens] [4]
ERROR: Source/WTF/wtf/CrossThreadTask.h:50:  Extra space before ( in function call  [whitespace/parens] [4]
ERROR: Source/WTF/wtf/FunctionDispatcher.h:42:  Extra space before ( in function call  [whitespace/parens] [4]
ERROR: Source/WebCore/page/scrolling/ScrollingThread.cpp:48:  Extra space before ( in function call  [whitespace/parens] [4]
ERROR: Source/WebCore/page/scrolling/ScrollingThread.cpp:61:  Extra space before ( in function call  [whitespace/parens] [4]
ERROR: Source/WebCore/page/scrolling/ScrollingThread.cpp:107:  Extra space before ( in function call  [whitespace/parens] [4]
ERROR: Source/WebCore/Modules/webaudio/DefaultAudioDestinationNode.h:53:  Extra space before ( in function call  [whitespace/parens] [4]
ERROR: Source/WebCore/Modules/webaudio/DefaultAudioDestinationNode.h:54:  Extra space before ( in function call  [whitespace/parens] [4]
ERROR: Source/WebCore/Modules/webaudio/DefaultAudioDestinationNode.h:55:  Extra space before ( in function call  [whitespace/parens] [4]
ERROR: Source/WebCore/Modules/webaudio/AudioDestinationNode.h:62:  Extra space before ( in function call  [whitespace/parens] [4]
ERROR: Source/WebCore/Modules/webaudio/AudioDestinationNode.h:63:  Extra space before ( in function call  [whitespace/parens] [4]
ERROR: Source/WebCore/Modules/webaudio/AudioDestinationNode.h:64:  Extra space before ( in function call  [whitespace/parens] [4]
ERROR: Source/WTF/wtf/RunLoop.cpp:94:  Extra space before ( in function call  [whitespace/parens] [4]
ERROR: Source/WTF/wtf/RunLoop.cpp:109:  Extra space before ( in function call  [whitespace/parens] [4]
ERROR: Source/WTF/wtf/RunLoop.cpp:126:  Extra space before ( in function call  [whitespace/parens] [4]
ERROR: Source/WTF/wtf/cocoa/WorkQueueCocoa.cpp:31:  Extra space before ( in function call  [whitespace/parens] [4]
ERROR: Source/WTF/wtf/cocoa/WorkQueueCocoa.cpp:42:  Extra space before ( in function call  [whitespace/parens] [4]
ERROR: Source/WebKit2/NetworkProcess/cache/NetworkCache.cpp:385:  Extra space before ( in function call  [whitespace/parens] [4]
ERROR: Source/WebKit2/NetworkProcess/cache/NetworkCache.cpp:483:  Extra space before ( in function call  [whitespace/parens] [4]
ERROR: Source/WebCore/bindings/js/SerializedScriptValue.h:90:  Extra space before ( in function call  [whitespace/parens] [4]
ERROR: Source/WTF/wtf/RunLoop.h:62:  Extra space before ( in function call  [whitespace/parens] [4]
ERROR: Source/WTF/wtf/RunLoop.h:82:  Extra space before ( in function call  [whitespace/parens] [4]
ERROR: Source/WTF/wtf/RunLoop.h:158:  Extra space before ( in function call  [whitespace/parens] [4]
ERROR: Source/WebCore/style/StyleTreeResolver.h:112:  Extra space before ( in function call  [whitespace/parens] [4]
ERROR: Source/WebCore/platform/mediastream/MediaStreamPrivate.cpp:302:  Extra space before ( in function call  [whitespace/parens] [4]
ERROR: Source/WTF/wtf/MainThread.h:44:  Extra space before ( in function call  [whitespace/parens] [4]
ERROR: Source/WebKit/Storage/StorageThread.h:48:  Extra space before ( in function call  [whitespace/parens] [4]
ERROR: Source/WebKit/Storage/StorageThread.h:61:  Extra space before ( in function call  [whitespace/parens] [4]
ERROR: Source/WebCore/platform/network/BlobRegistry.h:70:  Extra space before ( in function call  [whitespace/parens] [4]
ERROR: Source/WebKit2/WebProcess/Network/NetworkProcessConnection.h:61:  Extra space before ( in function call  [whitespace/parens] [4]
ERROR: Source/WebKit2/WebProcess/Network/NetworkProcessConnection.h:84:  Extra space before ( in function call  [whitespace/parens] [4]
ERROR: Source/WebCore/style/StyleTreeResolver.cpp:535:  Extra space before ( in function call  [whitespace/parens] [4]
ERROR: Source/WebCore/style/StyleTreeResolver.cpp:537:  Extra space before ( in function call  [whitespace/parens] [4]
ERROR: Source/WebCore/style/StyleTreeResolver.cpp:541:  Extra space before ( in function call  [whitespace/parens] [4]
ERROR: Source/WebKit/Storage/StorageThread.cpp:77:  Extra space before ( in function call  [whitespace/parens] [4]
ERROR: Source/WebKit/Storage/StorageThread.cpp:81:  Extra space before ( in function call  [whitespace/parens] [4]
ERROR: Source/WebKit/Storage/StorageThread.cpp:93:  Extra space before ( in function call  [whitespace/parens] [4]
ERROR: Source/WebCore/bindings/js/SerializedScriptValue.cpp:2801:  Extra space before ( in function call  [whitespace/parens] [4]
ERROR: Source/WebCore/platform/mediastream/mac/AVMediaCaptureSource.h:89:  Extra space before ( in function call  [whitespace/parens] [4]
ERROR: Source/WebCore/platform/network/BlobRegistryImpl.h:70:  Extra space before ( in function call  [whitespace/parens] [4]
ERROR: Source/WebCore/platform/mediastream/MediaStreamPrivate.h:115:  Extra space before ( in function call  [whitespace/parens] [4]
ERROR: Source/WebKit/Storage/StorageSyncManager.h:46:  Extra space before ( in function call  [whitespace/parens] [4]
ERROR: Source/WebKit/Storage/StorageSyncManager.cpp:66:  Extra space before ( in function call  [whitespace/parens] [4]
ERROR: Source/WTF/wtf/efl/DispatchQueueWorkItemEfl.h:37:  Extra space before ( in function call  [whitespace/parens] [4]
ERROR: Source/WTF/wtf/efl/DispatchQueueWorkItemEfl.h:47:  Extra space before ( in function call  [whitespace/parens] [4]
ERROR: Source/WTF/wtf/efl/DispatchQueueWorkItemEfl.h:52:  Extra space before ( in function call  [whitespace/parens] [4]
ERROR: Source/WTF/wtf/efl/DispatchQueueWorkItemEfl.h:61:  Extra space before ( in function call  [whitespace/parens] [4]
Total errors found: 102 in 66 files


If any of these errors are false positives, please file a bug against check-webkit-style.

Comment 37 Chris Dumez 2016-06-24 12:36:46 PDT

Comment on attachment 282002 [details]
Patch

Rs=me

Comment 38 Anders Carlsson 2016-06-24 12:40:35 PDT

Committed r202439: <http://trac.webkit.org/changeset/202439>