Crypto subtle was disabled on GTK development builds on r173872: <http://trac.webkit.org/changeset/173872> On r202561 :<http://trac.webkit.org/changeset/r202561> the expectations were updated. However, it was missed that there were a global skip for this tests with manual passes that the layout-script didn't liked. 05:42:54.700 13141 LayoutTests/platform/gtk/TestExpectations:719 Duplicate or ambiguous entry lines LayoutTests/platform/gtk/TestExpectations:409 and LayoutTests/platform/gtk/TestExpectations:719. crypto/subtle/ 05:42:54.700 13141 LayoutTests/platform/gtk/TestExpectations:719 Duplicate or ambiguous entry lines LayoutTests/platform/gtk/TestExpectations:409 and LayoutTests/platform/gtk/TestExpectations:719. crypto/subtle/ 05:42:54.700 13141 LayoutTests/platform/gtk/TestExpectations:719 Duplicate or ambiguous entry lines LayoutTests/platform/gtk/TestExpectations:409 and LayoutTests/platform/gtk/TestExpectations:719. crypto/subtle/ [....] This were the previous contents: # crypto.subtle is not yet enabled, but digest algorithms are already implemented # and their tests are whitelisted webkit.org/b/133122 crypto/subtle [ Skip ] webkit.org/b/133319 crypto/subtle/sha-1.html [ Pass ] webkit.org/b/133319 crypto/subtle/sha-224.html [ Pass ] webkit.org/b/133319 crypto/subtle/sha-256.html [ Pass ] webkit.org/b/133319 crypto/subtle/sha-384.html [ Pass ] webkit.org/b/133319 crypto/subtle/sha-512.html [ Pass ] webkit.org/b/133320 crypto/subtle/hmac-check-algorithm.html [ Pass ] webkit.org/b/133320 crypto/subtle/hmac-export-key.html [ Pass ] webkit.org/b/133320 crypto/subtle/hmac-generate-key.html [ Pass ] webkit.org/b/133320 crypto/subtle/hmac-import-jwk.html [ Pass ] webkit.org/b/133320 crypto/subtle/hmac-sign-verify-empty-key.html [ Pass ] webkit.org/b/133320 crypto/subtle/hmac-sign-verify.html [ Pass ] So, I'm opening this bug to enable back subtle crypto when someone wants, and I'm pasting the above output that was on the TestExpectations working.
(In reply to comment #0) > Crypto subtle was disabled on GTK development builds on r173872: > <http://trac.webkit.org/changeset/173872> Sorry, I mean on r202535: <http://trac.webkit.org/changeset/202535>
Committed r202623: <http://trac.webkit.org/changeset/202623>
(In reply to comment #2) > Committed r202623: <http://trac.webkit.org/changeset/202623> Here I fixed the layout tests expectations. Once this feature is enabled back, please revert the part of that changeset that removes the tests that were passing when the feature was enabled.
Created attachment 283521 [details] Patch
Comment on attachment 283521 [details] Patch Clearing flags on attachment: 283521 Committed r203160: <http://trac.webkit.org/changeset/203160>
All reviewed patches have been landed. Closing bug.