Bug 133320 – [GTK] Adds implementation of subtle crypto HMAC algorithm

• Status: RESOLVED
• Resolution: FIXED
• Component: New Bugs

[Eduardo Lima Mitev]

[GTK] Adds implementation of subtle crypto HMAC algorithm

[Eduardo Lima Mitev]

Created attachment 232145 [details]
Patch

[Eduardo Lima Mitev]

Adding dependency on bug 133316 and bug 133317.

[Eduardo Lima Mitev]

Created attachment 232183 [details]
Patch

[Eduardo Lima Mitev]

Created attachment 232188 [details]
Patch

[Eduardo Lima Mitev]

Created attachment 236507 [details]
Patch

[WebKit Commit Bot]

Attachment 236507 [details] did not pass style-queue:


ERROR: Source/WebCore/crypto/gtk/CryptoAlgorithmHMACGtk.cpp:34:  Alphabetical sorting problem.  [build/include_order] [4]
Total errors found: 1 in 4 files


If any of these errors are false positives, please file a bug against check-webkit-style.

[Philippe Normand]

Comment on attachment 236507 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=236507&action=review

Looks good! Only a small nit to fix, I think

> Source/WebCore/crypto/gtk/CryptoAlgorithmHMACGtk.cpp:99
> +    callback(result);}

Is this a spurious curly brace?

[Eduardo Lima Mitev]

Created attachment 238540 [details]
Patch

[WebKit Commit Bot]

Attachment 238540 [details] did not pass style-queue:


ERROR: Source/WebCore/crypto/gtk/CryptoAlgorithmHMACGtk.cpp:34:  Alphabetical sorting problem.  [build/include_order] [4]
Total errors found: 1 in 4 files


If any of these errors are false positives, please file a bug against check-webkit-style.

[WebKit Commit Bot]

Comment on attachment 238540 [details]
Patch

Rejecting attachment 238540 [details] from commit-queue.

Failed to run "['/Volumes/Data/EWS/WebKit/Tools/Scripts/webkit-patch', '--status-host=webkit-queues.appspot.com', '--bot-id=webkit-cq-01', 'land-attachment', '--force-clean', '--non-interactive', '--parent-command=commit-queue', 238540, '--port=mac']" exit_code: 2 cwd: /Volumes/Data/EWS/WebKit

Last 500 characters of output:
/git.webkit.org/WebKit
   a45428a..f931c1e  master     -> origin/master
Partial-rebuilding .git/svn/refs/remotes/origin/master/.rev_map.268f45cc-cd09-0410-ab3c-d52691b4dbfc ...
Currently at 173871 = a45428ae254d923e5c28643f3328a338c0c90ddc
r173872 = f931c1ee8604471d4f672c8451fd6c8fa160443e
Done rebuilding .git/svn/refs/remotes/origin/master/.rev_map.268f45cc-cd09-0410-ab3c-d52691b4dbfc
First, rewinding head to replay your work on top of it...
Fast-forwarded master to refs/remotes/origin/master.

Full output: http://webkit-queues.appspot.com/results/4735183215394816

[Philippe Normand]

Needs a rebase

[Eduardo Lima Mitev]

Created attachment 238542 [details]
Patch

[WebKit Commit Bot]

Attachment 238542 [details] did not pass style-queue:


ERROR: Source/WebCore/crypto/gtk/CryptoAlgorithmHMACGtk.cpp:34:  Alphabetical sorting problem.  [build/include_order] [4]
Total errors found: 1 in 4 files


If any of these errors are false positives, please file a bug against check-webkit-style.

[WebKit Commit Bot]

Comment on attachment 238542 [details]
Patch

Clearing flags on attachment: 238542

Committed r173874: <http://trac.webkit.org/changeset/173874>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.