Bug 133316 – [GTK] Adds stubs for all subtle crypto algorithm implemntations

• Status: RESOLVED
• Resolution: FIXED
• Component: New Bugs

[Eduardo Lima Mitev]

[GTK] Adds stubs for all subtle crypto algorithm implemntations

[Eduardo Lima Mitev]

Created attachment 232141 [details]
Patch

[WebKit Commit Bot]

Attachment 232141 [details] did not pass style-queue:


ERROR: Source/WebCore/ChangeLog:1:  ChangeLog entry has no bug number  [changelog/bugnumber] [5]
ERROR: Source/WebCore/CMakeLists.txt:30:  There should be exactly one empty line instead of 0 between "inspector" and "loader/appcache".  [list/emptyline] [5]
Total errors found: 2 in 17 files


If any of these errors are false positives, please file a bug against check-webkit-style.

[Build Bot]

Comment on attachment 232141 [details]
Patch

Attachment 232141 [details] did not pass mac-wk2-ews (mac-wk2):
Output: http://webkit-queues.appspot.com/results/6696170550198272

New failing tests:
media/W3C/video/networkState/networkState_during_loadstart.html

[Build Bot]

Created attachment 232148 [details]
Archive of layout-test-results from webkit-ews-09 for mac-mountainlion-wk2

The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews.
Bot: webkit-ews-09  Port: mac-mountainlion-wk2  Platform: Mac OS X 10.8.5

[Eduardo Lima Mitev]

Created attachment 232184 [details]
Patch

[WebKit Commit Bot]

Attachment 232184 [details] did not pass style-queue:


ERROR: Source/WebCore/CMakeLists.txt:30:  There should be exactly one empty line instead of 0 between "inspector" and "loader/appcache".  [list/emptyline] [5]
Total errors found: 1 in 17 files


If any of these errors are false positives, please file a bug against check-webkit-style.

[Eduardo Lima Mitev]

(In reply to comment #6)
> Attachment 232184 [details] did not pass style-queue:
> 
> ERROR: Source/WebCore/CMakeLists.txt:30:  There should be exactly one empty line instead of 0 between "inspector" and "loader/appcache".  [list/emptyline] [5]
> Total errors found: 1 in 17 files
> 

I think this is a false positive. The patch has nothing to do with the error mentioned. The occurrence of "inspector" and "loader/appcache" happens at lines 545 and 547 (not 30), and there is an empty line between them.

[Eduardo Lima Mitev]

Created attachment 232204 [details]
Patch

[WebKit Commit Bot]

Attachment 232204 [details] did not pass style-queue:


ERROR: Source/WebCore/CMakeLists.txt:30:  There should be exactly one empty line instead of 0 between "inspector" and "loader/appcache".  [list/emptyline] [5]
Total errors found: 1 in 18 files


If any of these errors are false positives, please file a bug against check-webkit-style.

[Eduardo Lima Mitev]

(In reply to comment #9)
> Attachment 232204 [details] did not pass style-queue:
> 
> 
> ERROR: Source/WebCore/CMakeLists.txt:30:  There should be exactly one empty line instead of 0 between "inspector" and "loader/appcache".  [list/emptyline] [5]
> Total errors found: 1 in 18 files
> 
> 
> If any of these errors are false positives, please file a bug against check-webkit-style.

Opened bug 133354 to follow up with this style error.

[Philippe Normand]

Comment on attachment 232204 [details]
Patch

Looks good but please replace the "Unimplemented" comments with notImplemented() calls :)

[Eduardo Lima Mitev]

Created attachment 236274 [details]
Patch

[WebKit Commit Bot]

Attachment 236274 [details] did not pass style-queue:


ERROR: Source/WebCore/CMakeLists.txt:32:  Alphabetical sorting problem. "page" should be before "loader/appcache".  [list/order] [5]
Total errors found: 1 in 18 files


If any of these errors are false positives, please file a bug against check-webkit-style.

[Eduardo Lima Mitev]

Created attachment 236277 [details]
Patch

[WebKit Commit Bot]

Attachment 236277 [details] did not pass style-queue:


ERROR: Source/WebCore/CMakeLists.txt:32:  Alphabetical sorting problem. "page" should be before "loader/appcache".  [list/order] [5]
Total errors found: 1 in 18 files


If any of these errors are false positives, please file a bug against check-webkit-style.

[WebKit Commit Bot]

Comment on attachment 236277 [details]
Patch

Rejecting attachment 236277 [details] from commit-queue.

Failed to run "['/Volumes/Data/EWS/WebKit/Tools/Scripts/webkit-patch', '--status-host=webkit-queues.appspot.com', '--bot-id=webkit-cq-01', 'apply-attachment', '--no-update', '--non-interactive', 236277, '--port=mac']" exit_code: 2 cwd: /Volumes/Data/EWS/WebKit

Last 500 characters of output:
cmake/WebKitFeatures.cmake
Hunk #1 FAILED at 106.
1 out of 1 hunk FAILED -- saving rejects to file Source/cmake/WebKitFeatures.cmake.rej
patching file Source/cmakeconfig.h.cmake
Hunk #1 FAILED at 96.
1 out of 1 hunk FAILED -- saving rejects to file Source/cmakeconfig.h.cmake.rej
patching file ChangeLog
Hunk #1 succeeded at 1 with fuzz 3.

Failed to run "[u'/Volumes/Data/EWS/WebKit/Tools/Scripts/svn-apply', '--force', '--reviewer', u'Philippe Normand']" exit_code: 1 cwd: /Volumes/Data/EWS/WebKit

Full output: http://webkit-queues.appspot.com/results/4782779388657664

[Eduardo Lima Mitev]

Created attachment 236355 [details]
Patch

[WebKit Commit Bot]

Attachment 236355 [details] did not pass style-queue:


ERROR: Source/WebCore/CMakeLists.txt:33:  Alphabetical sorting problem. "page" should be before "loader/appcache".  [list/order] [5]
Total errors found: 1 in 16 files


If any of these errors are false positives, please file a bug against check-webkit-style.

[WebKit Commit Bot]

Comment on attachment 236355 [details]
Patch

Clearing flags on attachment: 236355

Committed r172389: <http://trac.webkit.org/changeset/172389>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.