Bug 133319 – [GTK] Adds implementation of subtle crypto digest algorithms

• Status: RESOLVED
• Resolution: FIXED
• Component: New Bugs

[Eduardo Lima Mitev]

[GTK] Adds implementation of subtle crypto digest algorithms

[Eduardo Lima Mitev]

Created attachment 232143 [details]
Patch

[Eduardo Lima Mitev]

Adding dependency on bug 133316 and bug 133317.

[Eduardo Lima Mitev]

Created attachment 232187 [details]
Patch

[Eduardo Lima Mitev]

Created attachment 236437 [details]
Patch

[WebKit Commit Bot]

Attachment 236437 [details] did not pass style-queue:


ERROR: Source/WebCore/crypto/gtk/CryptoDigestGtk.cpp:31:  Alphabetical sorting problem.  [build/include_order] [4]
Total errors found: 1 in 4 files


If any of these errors are false positives, please file a bug against check-webkit-style.

[Eduardo Lima Mitev]

(In reply to comment #5)
> Attachment 236437 [details] did not pass style-queue:
> 
> 
> ERROR: Source/WebCore/crypto/gtk/CryptoDigestGtk.cpp:31:  Alphabetical sorting problem.  [build/include_order] [4]
> Total errors found: 1 in 4 files
> 

This is an unavoidable positive:

#include <gnutls/gnutls.h>
#include <gnutls/crypto.h>

Order is alphabetically wrong, but the order cannot be inverted since crypto.h needs gnutls.h included before.

[Eduardo Lima Mitev]

Created attachment 236509 [details]
Patch

[WebKit Commit Bot]

Attachment 236509 [details] did not pass style-queue:


ERROR: Source/WebCore/crypto/gtk/CryptoDigestGtk.cpp:31:  Alphabetical sorting problem.  [build/include_order] [4]
Total errors found: 1 in 4 files


If any of these errors are false positives, please file a bug against check-webkit-style.

[Philippe Normand]

Comment on attachment 236509 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=236509&action=review

> Source/WebCore/crypto/gtk/CryptoDigestGtk.cpp:53
> +    gnutls_digest_algorithm_t gnutlsAlgo;

gnutlsAlgorithm please :)

[Eduardo Lima Mitev]

Created attachment 238538 [details]
Patch

[WebKit Commit Bot]

Attachment 238538 [details] did not pass style-queue:


ERROR: Source/WebCore/crypto/gtk/CryptoDigestGtk.cpp:31:  Alphabetical sorting problem.  [build/include_order] [4]
Total errors found: 1 in 4 files


If any of these errors are false positives, please file a bug against check-webkit-style.

[WebKit Commit Bot]

Comment on attachment 238538 [details]
Patch

Clearing flags on attachment: 238538

Committed r173872: <http://trac.webkit.org/changeset/173872>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.