Bug 157897 – Web Inspector: timelines should not update via requestAnimationFrame unless Web Inspector is visible

• Status: RESOLVED
• Resolution: FIXED
• Component: Web Inspector

[Blaze Burg]

.

[Blaze Burg]

<rdar://problem/26330802>

[Blaze Burg]

Created attachment 279393 [details]
Proposed Fix

[Build Bot]

Comment on attachment 279393 [details]
Proposed Fix

Attachment 279393 [details] did not pass mac-ews (mac):
Output: http://webkit-queues.webkit.org/results/1348904

Number of test failures exceeded the failure limit.

[Build Bot]

Created attachment 279399 [details]
Archive of layout-test-results from ews101 for mac-yosemite

The attached test failures were seen while running run-webkit-tests on the mac-ews.
Bot: ews101  Port: mac-yosemite  Platform: Mac OS X 10.10.5

[Blaze Burg]

Committed r201171: <http://trac.webkit.org/changeset/201171>

[Joseph Pecoraro]

Comment on attachment 279393 [details]
Proposed Fix

View in context: https://bugs.webkit.org/attachment.cgi?id=279393&action=review

> Source/WebInspectorUI/UserInterface/Views/TimelineRecordingContentView.js:443
> +        if (typeof startTime === "number" && !isNaN(this._currentTime))
>              this._currentTime = startTime;
> -        else if (!isNaN(this._currentTime)) {
> +        else {

I don't understand this logic change. It ends up breaking the backend informing the frontend what the current time is in the common case (a user inspecting a local page). I put up a patch to revert this in bug 163583. If you think this is still needed for some reason, please comment there. I believe this patch was meant for Safari WebDriver --inspect behavior, but I don't understand why we wouldn't set the current time here if we are visible and have a start time.