Bug 171034 - [Windows][WK1] Web Inspector: Timelines tab doesn't function at all
Summary: [Windows][WK1] Web Inspector: Timelines tab doesn't function at all
Status: RESOLVED WONTFIX
Alias: None
Product: WebKit
Classification: Unclassified
Component: Web Inspector (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on: 157897
Blocks:
  Show dependency treegraph
 
Reported: 2017-04-19 20:20 PDT by Fujii Hironori
Modified: 2023-02-23 12:53 PST (History)
6 users (show)

See Also:


Attachments
Screenshot of AppleWin port MiniBrowser (70.92 KB, image/png)
2017-04-19 20:21 PDT, Fujii Hironori
no flags Details
error messages (48.29 KB, image/png)
2017-04-20 03:03 PDT, Fujii Hironori
no flags Details
error messages 2 (56.71 KB, image/png)
2017-04-20 03:17 PDT, Fujii Hironori
no flags Details
error messages 3 (93.11 KB, image/png)
2017-04-20 03:30 PDT, Fujii Hironori
no flags Details
WIP patch using visibility API (1.40 KB, patch)
2017-04-24 00:24 PDT, Fujii Hironori
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Fujii Hironori 2017-04-19 20:20:09 PDT
[Windows] Web Inspector: Timelines tab doesn't function at all

AppleWin port and WinCairo port

Steps:

1) Open MiniBrowser
2) Open Web Inspector
3) Open Timelines tab
4) Push reload

Nothing happens in Timelines view.

Does some features need to be enabled?
Comment 1 Fujii Hironori 2017-04-19 20:21:09 PDT
Created attachment 307545 [details]
Screenshot of AppleWin port MiniBrowser
Comment 2 Joseph Pecoraro 2017-04-19 22:40:40 PDT
Nothing that I know of should cause these kinds of errors.

Maybe something with the JavaScript Intl APIs? First thing to check would be if there are any exceptions in the inspector page itself.
Comment 3 Fujii Hironori 2017-04-20 03:03:30 PDT
Created attachment 307584 [details]
error messages

Thank you, Joseph.
Here are the tow messages output in the secondary Web Inspector:

> Assertion Failed: Attempted to remove a CSSStyleSheet that was not tracked
> Error during DOMAgent operation: No node with given path found
Comment 4 Fujii Hironori 2017-04-20 03:17:33 PDT
Created attachment 307585 [details]
error messages 2

I tested several times. But, I see only the first error message, but the second one.
Comment 5 Fujii Hironori 2017-04-20 03:30:50 PDT
Created attachment 307587 [details]
error messages 3

I can get different error message with different steps.

Steps:

1) Open MiniBrowser
2) Open the first Web Inspector
3) Open the second Web Inspector
4) Open Console tab in the second Web Inspector
5) Open Timelines tab in the first Web Inspector
6) Push the recording button in the first Web Inspector
7) Open google.com in MiniBrowser
Comment 6 Joseph Pecoraro 2017-04-20 12:39:47 PDT
> > Assertion Failed: Attempted to remove a CSSStyleSheet that was not tracked
> > Error during DOMAgent operation: No node with given path found

Okay, these are benign warnings/errors. Unrelated to any serious issue.
Comment 7 Fujii Hironori 2017-04-21 03:38:22 PDT
I found a workaround.
Executing a following expression in the Console tab of the second Web Inspector, Timelines would work fine.

> WebInspector.visible = true
Comment 8 Fujii Hironori 2017-04-21 03:48:35 PDT
WebInspectorUI::setIsVisible is dispatching "setIsVisible" in WebKit2.
I'm guessing a similar method is required in WebKit1 of Windows port.
Comment 9 Joseph Pecoraro 2017-04-21 11:56:22 PDT
Ahh yes!

I'm still very disappointed with that addition to web inspector. It has cost me many hours of debugging to find the same thing in the past. I don't know why such a confusing addition was added.
Comment 10 Fujii Hironori 2017-04-23 22:16:36 PDT
I have two questions.

Timelines tab of remote web inspector of GTK+ port also doesn't work
even though RemoteWebInspectorUI::frontendLoaded in
Source/WebKit2/WebProcess/WebPage/RemoteWebInspectorUI.cpp has a code
to dispatch "setIsVisible". Why?

setIsVisible has been introduced in Bug 157897 for
requestAnimationFrame. Which window does this visibility mean for? The
target window or the inspector window? requestAnimationFrame is used
in the inspector window. Can I use visibility API for ths purpose in
the inspector window?
Comment 11 Fujii Hironori 2017-04-24 00:24:41 PDT
Created attachment 307959 [details]
WIP patch using visibility API

This patch solves the problems of Windows port and remote web inspector of GTK+ port.
Comment 12 Fujii Hironori 2017-04-26 19:22:31 PDT
(In reply to Fujii Hironori from comment #10)
> Timelines tab of remote web inspector of GTK+ port also doesn't work

GTK+ port has switched to ENABLE_REMOTE_INSPECTOR (Bug 166680). It works now.
Comment 13 Fujii Hironori 2017-04-27 03:04:28 PDT
  Bug 157897 – Web Inspector: timelines should not update via requestAnimationFrame unless Web Inspector is visible

Bug 157897 doesn't seem to be solved in a certain condition.
I tested with GTK+ port.

1) Start MiniBrowser
2) Inspect Element
3) Push "Detach into separate window" button
4) Close the inspector window
5) Navigate a web page in the main window
6) Wait for finishing load
7) Reopen the minimized inspector window

Timeline current time marker is starting from 0s.
Comment 14 Fujii Hironori 2017-04-27 03:05:52 PDT
> 4) Close the inspector window

s/Close/Minimize/
Comment 15 Joseph Pecoraro 2019-09-13 11:31:38 PDT
Is this still the case? Can we resolve this?
Comment 16 Fujii Hironori 2019-09-16 19:37:16 PDT
This issue (comment 0) is still valid.

And, Safari Technology Preview 91 also has comment 13 issue.

1. Start Safari
2. Open a web page
3. Inspect Element to open Web Inspector
4. Push "Detach into separate window" button
5. Minimize the inspector window
6. Navigate a web page in the main window
7. Wait for finishing load
8. Reopen the minimized inspector window

Timeline current time marker is starting from 0s.
Comment 17 Joseph Pecoraro 2019-09-16 19:54:19 PDT
(In reply to Fujii Hironori from comment #16)
> This issue (comment 0) is still valid.

Okay! Would you like to provide an updated patch?


> And, Safari Technology Preview 91 also has comment 13 issue.
> 
> 1. Start Safari
> 2. Open a web page
> 3. Inspect Element to open Web Inspector
> 4. Push "Detach into separate window" button
> 5. Minimize the inspector window
> 6. Navigate a web page in the main window
> 7. Wait for finishing load
> 8. Reopen the minimized inspector window
> 
> Timeline current time marker is starting from 0s.

Yes, I've seen this, would be nice to address.
Comment 18 Fujii Hironori 2019-09-16 23:11:53 PDT
This issue is not only for Windows WebKit1, but also Mac port WebKit1
because Bug 157897 changes only WebKit2.
Timelines doesn't work even in Mac WebKit1.

Joseph, would you fix Mac WK1 issue? It will let me know how to fix the Windows WK1 issue.
Comment 19 Fujii Hironori 2023-02-23 12:53:53 PST
Windows WK1 was removed.