Bug 163583 - REGRESSION(r201171): Web Inspector: Timeline Recording playhead should always start immediately, not wait until first event
Summary: REGRESSION(r201171): Web Inspector: Timeline Recording playhead should always...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Web Inspector (show other bugs)
Version: WebKit Nightly Build
Hardware: All All
: P2 Normal
Assignee: Nobody
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2016-10-17 20:31 PDT by Joseph Pecoraro
Modified: 2016-10-18 11:11 PDT (History)
8 users (show)

See Also:

Attachments
[PATCH] Proposed Fix (2.12 KB, patch)
2016-10-17 20:41 PDT, Joseph Pecoraro 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Joseph Pecoraro 2016-10-17 20:31:56 PDT 
Summary:
Timeline Recording playhead should always start immediately, not wait until first event

Steps to Reproduce:
1. Inspect a page
2. Start a timeline recording
3. Wait 10 seconds
4. Interact with the page

Expected Behavior:
Timeline UI starts updating immediately at (2)

Actual Behavior:
Timeline UI starts updating at (4)

Regression:
Almost certainly this is a regression from earlier behavior.
Comment 1 Radar WebKit Bug Importer 2016-10-17 20:32:14 PDT 
<rdar://problem/28815882>
Comment 2 Joseph Pecoraro 2016-10-17 20:38:53 PDT 
Looks like this would have regressed with:
<https://trac.webkit.org/r201171>

This changed some logic that it didn't need to and it looks like it changed it incorrectly.
Comment 3 Joseph Pecoraro 2016-10-17 20:41:35 PDT 
Created attachment 291915 [details]
[PATCH] Proposed Fix
Comment 4 Joseph Pecoraro 2016-10-17 20:48:10 PDT 
Comment on attachment 291915 [details]
[PATCH] Proposed Fix

After re-reading the original change, I still don't understand why this change would have been made, so setting cq? again.
Comment 5 WebKit Commit Bot 2016-10-18 11:10:59 PDT 
Comment on attachment 291915 [details]
[PATCH] Proposed Fix

Clearing flags on attachment: 291915

Committed r207473: <http://trac.webkit.org/changeset/207473>
Comment 6 WebKit Commit Bot 2016-10-18 11:11:03 PDT 
All reviewed patches have been landed.  Closing bug.