Bug 157110 – Set overflow: hidden on ::-webkit-media-controls in mediaControlsApple.css

• Status: RESOLVED
• Resolution: FIXED
• Component: Media

[Ada Chan]

This matches how we also set overflow: hidden on ::-webkit-media-controls in mediaControlsiOS.css.  We initially wanted to make this change as part of https://bugs.webkit.org/show_bug.cgi?id=156245, but ran into some layout tests failure/assertions.  

The assertions have been fixed with https://bugs.webkit.org/show_bug.cgi?id=156878.

The image diff difference for fast/regions/inline-block-inside-anonymous-overflow.html has been filed as https://bugs.webkit.org/show_bug.cgi?id=156245 https://bugs.webkit.org/show_bug.cgi?id=156320.  Zalan's recommendation is to mark this test as image-failure-only, and make a copy of that test with the media controls covered up just so we can catch other regressions with this test.

[Ada Chan]

Related to <rdar://problem/25231271>

[Ada Chan]

Created attachment 277555 [details]
Patch

[Ada Chan]

Submitted a patch to EWS to run - I'll probably need to rebaseline some tests.

[Build Bot]

Comment on attachment 277555 [details]
Patch

Attachment 277555 [details] did not pass mac-ews (mac):
Output: http://webkit-queues.webkit.org/results/1231310

New failing tests:
media/media-document-audio-repaint.html
media/video-zoom-controls.html

[Build Bot]

Created attachment 277561 [details]
Archive of layout-test-results from ews100 for mac-yosemite

The attached test failures were seen while running run-webkit-tests on the mac-ews.
Bot: ews100  Port: mac-yosemite  Platform: Mac OS X 10.10.5

[Build Bot]

Comment on attachment 277555 [details]
Patch

Attachment 277555 [details] did not pass mac-wk2-ews (mac-wk2):
Output: http://webkit-queues.webkit.org/results/1231311

New failing tests:
media/media-document-audio-repaint.html
media/video-zoom-controls.html

[Build Bot]

Created attachment 277562 [details]
Archive of layout-test-results from ews106 for mac-yosemite-wk2

The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews.
Bot: ews106  Port: mac-yosemite-wk2  Platform: Mac OS X 10.10.5

[Build Bot]

Comment on attachment 277555 [details]
Patch

Attachment 277555 [details] did not pass ios-sim-ews (ios-simulator-wk2):
Output: http://webkit-queues.webkit.org/results/1231389

New failing tests:
fast/regions/inline-block-inside-anonymous-overflow-with-covered-controls.html

[Build Bot]

Created attachment 277567 [details]
Archive of layout-test-results from ews125 for ios-simulator-wk2

The attached test failures were seen while running run-webkit-tests on the ios-sim-ews.
Bot: ews125  Port: ios-simulator-wk2  Platform: Mac OS X 10.11.4

[Build Bot]

Comment on attachment 277555 [details]
Patch

Attachment 277555 [details] did not pass mac-debug-ews (mac):
Output: http://webkit-queues.webkit.org/results/1231400

New failing tests:
media/media-document-audio-repaint.html
media/video-zoom-controls.html

[Build Bot]

Created attachment 277569 [details]
Archive of layout-test-results from ews115 for mac-yosemite

The attached test failures were seen while running run-webkit-tests on the mac-debug-ews.
Bot: ews115  Port: mac-yosemite  Platform: Mac OS X 10.10.5

[Ada Chan]

Created attachment 277592 [details]
Patch

[Ada Chan]

Committed:
http://trac.webkit.org/changeset/200196

This caused bug 157975.