Rename TextTrackRepresentationiOS to TextTrackRepresentationCocoa and enable on Mac
<rdar://problem/25231271>
Created attachment 275715 [details] Patch
Attachment 275715 [details] did not pass style-queue: ERROR: Source/WebCore/platform/graphics/cocoa/TextTrackRepresentationCocoa.mm:88: The parameter name "object" adds no information, so it should be removed. [readability/parameter_name] [5] ERROR: Source/WebCore/platform/graphics/cocoa/TextTrackRepresentationCocoa.mm:92: The parameter name "object" adds no information, so it should be removed. [readability/parameter_name] [5] Total errors found: 2 in 6 files If any of these errors are false positives, please file a bug against check-webkit-style.
Comment on attachment 275715 [details] Patch Attachment 275715 [details] did not pass mac-ews (mac): Output: http://webkit-queues.webkit.org/results/1106204 New failing tests: media/media-document-audio-repaint.html fast/regions/inline-block-inside-anonymous-overflow.html media/video-zoom-controls.html
Created attachment 275727 [details] Archive of layout-test-results from ews102 for mac-yosemite The attached test failures were seen while running run-webkit-tests on the mac-ews. Bot: ews102 Port: mac-yosemite Platform: Mac OS X 10.10.5
Comment on attachment 275715 [details] Patch Attachment 275715 [details] did not pass mac-wk2-ews (mac-wk2): Output: http://webkit-queues.webkit.org/results/1106205 New failing tests: media/media-document-audio-repaint.html fast/regions/inline-block-inside-anonymous-overflow.html media/video-zoom-controls.html
Created attachment 275728 [details] Archive of layout-test-results from ews107 for mac-yosemite-wk2 The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews. Bot: ews107 Port: mac-yosemite-wk2 Platform: Mac OS X 10.10.5
Comment on attachment 275715 [details] Patch Attachment 275715 [details] did not pass mac-debug-ews (mac): Output: http://webkit-queues.webkit.org/results/1106174 New failing tests: media/media-document-audio-repaint.html media/track/video-track.html http/tests/appcache/video.html media/track/video-track-alternate-groups.html media/track/track-in-band.html media/video-zoom-controls.html media/video-src-empty.html fast/regions/inline-block-inside-anonymous-overflow.html media/track/track-active-cues.html
Created attachment 275731 [details] Archive of layout-test-results from ews115 for mac-yosemite The attached test failures were seen while running run-webkit-tests on the mac-debug-ews. Bot: ews115 Port: mac-yosemite Platform: Mac OS X 10.10.5
Comment on attachment 275715 [details] Patch It looks like the failing tests just need to be rebased.
Created attachment 275820 [details] Patch
Attachment 275820 [details] did not pass style-queue: ERROR: Source/WebCore/platform/graphics/cocoa/TextTrackRepresentationCocoa.mm:88: The parameter name "object" adds no information, so it should be removed. [readability/parameter_name] [5] ERROR: Source/WebCore/platform/graphics/cocoa/TextTrackRepresentationCocoa.mm:92: The parameter name "object" adds no information, so it should be removed. [readability/parameter_name] [5] Total errors found: 2 in 9 files If any of these errors are false positives, please file a bug against check-webkit-style.
Comment on attachment 275820 [details] Patch Rebaseline a couple of tests after the changes to MediaControlsApple.css. Just want to submit this EWS to get the latest test results.
Comment on attachment 275820 [details] Patch Attachment 275820 [details] did not pass mac-ews (mac): Output: http://webkit-queues.webkit.org/results/1111258 New failing tests: fast/regions/inline-block-inside-anonymous-overflow.html
Created attachment 275824 [details] Archive of layout-test-results from ews100 for mac-yosemite The attached test failures were seen while running run-webkit-tests on the mac-ews. Bot: ews100 Port: mac-yosemite Platform: Mac OS X 10.10.5
Comment on attachment 275820 [details] Patch Attachment 275820 [details] did not pass mac-wk2-ews (mac-wk2): Output: http://webkit-queues.webkit.org/results/1111264 New failing tests: fast/regions/inline-block-inside-anonymous-overflow.html
Created attachment 275825 [details] Archive of layout-test-results from ews106 for mac-yosemite-wk2 The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews. Bot: ews106 Port: mac-yosemite-wk2 Platform: Mac OS X 10.10.5
Comment on attachment 275820 [details] Patch Attachment 275820 [details] did not pass mac-debug-ews (mac): Output: http://webkit-queues.webkit.org/results/1111281 New failing tests: media/track/video-track.html http/tests/appcache/video.html media/track/video-track-alternate-groups.html media/track/track-in-band.html media/video-src-empty.html fast/regions/inline-block-inside-anonymous-overflow.html media/track/track-active-cues.html
Created attachment 275827 [details] Archive of layout-test-results from ews115 for mac-yosemite The attached test failures were seen while running run-webkit-tests on the mac-debug-ews. Bot: ews115 Port: mac-yosemite Platform: Mac OS X 10.10.5
Created attachment 275903 [details] Patch
Created attachment 275905 [details] Patch
Attachment 275905 [details] did not pass style-queue: ERROR: Source/WebCore/platform/graphics/cocoa/TextTrackRepresentationCocoa.mm:88: The parameter name "object" adds no information, so it should be removed. [readability/parameter_name] [5] ERROR: Source/WebCore/platform/graphics/cocoa/TextTrackRepresentationCocoa.mm:92: The parameter name "object" adds no information, so it should be removed. [readability/parameter_name] [5] Total errors found: 2 in 10 files If any of these errors are false positives, please file a bug against check-webkit-style.
(In reply to comment #10) > Comment on attachment 275715 [details] > Patch > > It looks like the failing tests just need to be rebased. Thanks Eric! I've rebased the tests and skipped some tests with associated bugs. Committed: http://trac.webkit.org/changeset/199174
Skipped a couple of more tests with the same assertion in FrameView::rescheduleRelayoutOfSubtree(). http://trac.webkit.org/changeset/199198