Bug 156245 - Rename TextTrackRepresentationiOS to TextTrackRepresentationCocoa and enable on Mac
Summary: Rename TextTrackRepresentationiOS to TextTrackRepresentationCocoa and enable ...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Media (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Ada Chan
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2016-04-05 12:03 PDT by Ada Chan
Modified: 2016-04-07 16:35 PDT (History)
3 users (show)

See Also:


Attachments
Patch (27.53 KB, patch)
2016-04-05 16:44 PDT, Ada Chan
eric.carlson: review+
buildbot: commit-queue-
Details | Formatted Diff | Diff
Archive of layout-test-results from ews102 for mac-yosemite (1.05 MB, application/zip)
2016-04-05 17:28 PDT, Build Bot
no flags Details
Archive of layout-test-results from ews107 for mac-yosemite-wk2 (920.69 KB, application/zip)
2016-04-05 17:30 PDT, Build Bot
no flags Details
Archive of layout-test-results from ews115 for mac-yosemite (1.48 MB, application/zip)
2016-04-05 17:52 PDT, Build Bot
no flags Details
Patch (35.11 KB, patch)
2016-04-06 14:58 PDT, Ada Chan
buildbot: commit-queue-
Details | Formatted Diff | Diff
Archive of layout-test-results from ews100 for mac-yosemite (917.05 KB, application/zip)
2016-04-06 15:42 PDT, Build Bot
no flags Details
Archive of layout-test-results from ews106 for mac-yosemite-wk2 (898.76 KB, application/zip)
2016-04-06 15:46 PDT, Build Bot
no flags Details
Archive of layout-test-results from ews115 for mac-yosemite (1.48 MB, application/zip)
2016-04-06 16:07 PDT, Build Bot
no flags Details
Patch (36.48 KB, patch)
2016-04-07 11:33 PDT, Ada Chan
no flags Details | Formatted Diff | Diff
Patch (36.45 KB, patch)
2016-04-07 11:41 PDT, Ada Chan
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Ada Chan 2016-04-05 12:03:51 PDT
Rename TextTrackRepresentationiOS to TextTrackRepresentationCocoa and enable on Mac
Comment 1 Ada Chan 2016-04-05 12:04:25 PDT
<rdar://problem/25231271>
Comment 2 Ada Chan 2016-04-05 16:44:22 PDT
Created attachment 275715 [details]
Patch
Comment 3 WebKit Commit Bot 2016-04-05 16:46:37 PDT
Attachment 275715 [details] did not pass style-queue:


ERROR: Source/WebCore/platform/graphics/cocoa/TextTrackRepresentationCocoa.mm:88:  The parameter name "object" adds no information, so it should be removed.  [readability/parameter_name] [5]
ERROR: Source/WebCore/platform/graphics/cocoa/TextTrackRepresentationCocoa.mm:92:  The parameter name "object" adds no information, so it should be removed.  [readability/parameter_name] [5]
Total errors found: 2 in 6 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 4 Build Bot 2016-04-05 17:28:12 PDT
Comment on attachment 275715 [details]
Patch

Attachment 275715 [details] did not pass mac-ews (mac):
Output: http://webkit-queues.webkit.org/results/1106204

New failing tests:
media/media-document-audio-repaint.html
fast/regions/inline-block-inside-anonymous-overflow.html
media/video-zoom-controls.html
Comment 5 Build Bot 2016-04-05 17:28:15 PDT
Created attachment 275727 [details]
Archive of layout-test-results from ews102 for mac-yosemite

The attached test failures were seen while running run-webkit-tests on the mac-ews.
Bot: ews102  Port: mac-yosemite  Platform: Mac OS X 10.10.5
Comment 6 Build Bot 2016-04-05 17:30:33 PDT
Comment on attachment 275715 [details]
Patch

Attachment 275715 [details] did not pass mac-wk2-ews (mac-wk2):
Output: http://webkit-queues.webkit.org/results/1106205

New failing tests:
media/media-document-audio-repaint.html
fast/regions/inline-block-inside-anonymous-overflow.html
media/video-zoom-controls.html
Comment 7 Build Bot 2016-04-05 17:30:34 PDT
Created attachment 275728 [details]
Archive of layout-test-results from ews107 for mac-yosemite-wk2

The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews.
Bot: ews107  Port: mac-yosemite-wk2  Platform: Mac OS X 10.10.5
Comment 8 Build Bot 2016-04-05 17:52:51 PDT
Comment on attachment 275715 [details]
Patch

Attachment 275715 [details] did not pass mac-debug-ews (mac):
Output: http://webkit-queues.webkit.org/results/1106174

New failing tests:
media/media-document-audio-repaint.html
media/track/video-track.html
http/tests/appcache/video.html
media/track/video-track-alternate-groups.html
media/track/track-in-band.html
media/video-zoom-controls.html
media/video-src-empty.html
fast/regions/inline-block-inside-anonymous-overflow.html
media/track/track-active-cues.html
Comment 9 Build Bot 2016-04-05 17:52:54 PDT
Created attachment 275731 [details]
Archive of layout-test-results from ews115 for mac-yosemite

The attached test failures were seen while running run-webkit-tests on the mac-debug-ews.
Bot: ews115  Port: mac-yosemite  Platform: Mac OS X 10.10.5
Comment 10 Eric Carlson 2016-04-06 09:03:14 PDT
Comment on attachment 275715 [details]
Patch

It looks like the failing tests just need to be rebased.
Comment 11 Ada Chan 2016-04-06 14:58:58 PDT
Created attachment 275820 [details]
Patch
Comment 12 WebKit Commit Bot 2016-04-06 15:01:22 PDT
Attachment 275820 [details] did not pass style-queue:


ERROR: Source/WebCore/platform/graphics/cocoa/TextTrackRepresentationCocoa.mm:88:  The parameter name "object" adds no information, so it should be removed.  [readability/parameter_name] [5]
ERROR: Source/WebCore/platform/graphics/cocoa/TextTrackRepresentationCocoa.mm:92:  The parameter name "object" adds no information, so it should be removed.  [readability/parameter_name] [5]
Total errors found: 2 in 9 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 13 Ada Chan 2016-04-06 15:01:52 PDT
Comment on attachment 275820 [details]
Patch

Rebaseline a couple of tests after the changes to MediaControlsApple.css.  Just want to submit this EWS to get the latest test results.
Comment 14 Build Bot 2016-04-06 15:42:33 PDT
Comment on attachment 275820 [details]
Patch

Attachment 275820 [details] did not pass mac-ews (mac):
Output: http://webkit-queues.webkit.org/results/1111258

New failing tests:
fast/regions/inline-block-inside-anonymous-overflow.html
Comment 15 Build Bot 2016-04-06 15:42:36 PDT
Created attachment 275824 [details]
Archive of layout-test-results from ews100 for mac-yosemite

The attached test failures were seen while running run-webkit-tests on the mac-ews.
Bot: ews100  Port: mac-yosemite  Platform: Mac OS X 10.10.5
Comment 16 Build Bot 2016-04-06 15:46:06 PDT
Comment on attachment 275820 [details]
Patch

Attachment 275820 [details] did not pass mac-wk2-ews (mac-wk2):
Output: http://webkit-queues.webkit.org/results/1111264

New failing tests:
fast/regions/inline-block-inside-anonymous-overflow.html
Comment 17 Build Bot 2016-04-06 15:46:09 PDT
Created attachment 275825 [details]
Archive of layout-test-results from ews106 for mac-yosemite-wk2

The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews.
Bot: ews106  Port: mac-yosemite-wk2  Platform: Mac OS X 10.10.5
Comment 18 Build Bot 2016-04-06 16:07:27 PDT
Comment on attachment 275820 [details]
Patch

Attachment 275820 [details] did not pass mac-debug-ews (mac):
Output: http://webkit-queues.webkit.org/results/1111281

New failing tests:
media/track/video-track.html
http/tests/appcache/video.html
media/track/video-track-alternate-groups.html
media/track/track-in-band.html
media/video-src-empty.html
fast/regions/inline-block-inside-anonymous-overflow.html
media/track/track-active-cues.html
Comment 19 Build Bot 2016-04-06 16:07:30 PDT
Created attachment 275827 [details]
Archive of layout-test-results from ews115 for mac-yosemite

The attached test failures were seen while running run-webkit-tests on the mac-debug-ews.
Bot: ews115  Port: mac-yosemite  Platform: Mac OS X 10.10.5
Comment 20 Ada Chan 2016-04-07 11:33:40 PDT
Created attachment 275903 [details]
Patch
Comment 21 Ada Chan 2016-04-07 11:41:35 PDT
Created attachment 275905 [details]
Patch
Comment 22 WebKit Commit Bot 2016-04-07 11:43:42 PDT
Attachment 275905 [details] did not pass style-queue:


ERROR: Source/WebCore/platform/graphics/cocoa/TextTrackRepresentationCocoa.mm:88:  The parameter name "object" adds no information, so it should be removed.  [readability/parameter_name] [5]
ERROR: Source/WebCore/platform/graphics/cocoa/TextTrackRepresentationCocoa.mm:92:  The parameter name "object" adds no information, so it should be removed.  [readability/parameter_name] [5]
Total errors found: 2 in 10 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 23 Ada Chan 2016-04-07 13:05:56 PDT
(In reply to comment #10)
> Comment on attachment 275715 [details]
> Patch
> 
> It looks like the failing tests just need to be rebased.

Thanks Eric!  I've rebased the tests and skipped some tests with associated bugs.

Committed:
http://trac.webkit.org/changeset/199174
Comment 24 Ada Chan 2016-04-07 16:35:25 PDT
Skipped a couple of more tests with the same assertion in FrameView::rescheduleRelayoutOfSubtree().

http://trac.webkit.org/changeset/199198