Bug 156878 - RenderVideo should always update the intrinsic size before layout.
Summary: RenderVideo should always update the intrinsic size before layout.
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Layout and Rendering (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: zalan
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2016-04-21 16:23 PDT by zalan
Modified: 2016-04-28 00:48 PDT (History)
7 users (show)

See Also:

Attachments
Patch (3.27 KB, patch)
2016-04-21 16:33 PDT, zalan 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description zalan 2016-04-21 16:23:24 PDT 
and definitely not after that.
Comment 1 zalan 2016-04-21 16:33:52 PDT 
Created attachment 276980 [details]
Patch
Comment 2 WebKit Commit Bot 2016-04-21 18:13:13 PDT 
Comment on attachment 276980 [details]
Patch

Clearing flags on attachment: 276980

Committed r199856: <http://trac.webkit.org/changeset/199856>
Comment 3 WebKit Commit Bot 2016-04-21 18:13:17 PDT 
All reviewed patches have been landed.  Closing bug.
Comment 4 Daniel Bates 2016-04-28 00:47:20 PDT 
Comment on attachment 276980 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=276980&action=review

> Source/WebCore/rendering/RenderVideo.cpp:225
> +    bool intrinsicSizeChanged;
> +    intrinsicSizeChanged = updateIntrinsicSize();

I would have written this in one line:

bool intrinsicSizeChanged = updateIntrinsicSize();