Bug 156683 - libjavascriptcoregtk-4.0.dylib is no longer installed
Summary: libjavascriptcoregtk-4.0.dylib is no longer installed
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: JavaScriptCore (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks: 126492
  Show dependency tree / graph
 
Reported: 2016-04-17 16:04 PDT by Jeremy Huddleston Sequoia
Modified: 2016-04-18 00:14 PDT (History)
2 users (show)

See Also:

Attachments
0001-Fix-incorrect-assumption-that-APPLE-implies-Mac (1.75 KB, patch)
2016-04-17 17:09 PDT, Jeremy Huddleston Sequoia 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Jeremy Huddleston Sequoia 2016-04-17 16:04:13 PDT 
libjavascriptcoregtk-4.0.dylib is not installed by 'make install' in r199646.

Last known good was r198900.

Multiple unrelated build failures plague simple bisection.
Comment 1 Jeremy Huddleston Sequoia 2016-04-17 16:07:44 PDT 
Looks like it was caused by https://bugs.webkit.org/show_bug.cgi?id=156268

More incorrect assumptions that APPLE == Mac.
Comment 2 Jeremy Huddleston Sequoia 2016-04-17 17:09:54 PDT 
Created attachment 276613 [details]
0001-Fix-incorrect-assumption-that-APPLE-implies-Mac

This patch fixes the issue and is being used now by MacPorts.
Comment 3 Alex Christensen 2016-04-17 23:01:20 PDT 
Comment on attachment 276613 [details]
0001-Fix-incorrect-assumption-that-APPLE-implies-Mac

My bad
Comment 4 WebKit Commit Bot 2016-04-17 23:52:27 PDT 
Comment on attachment 276613 [details]
0001-Fix-incorrect-assumption-that-APPLE-implies-Mac

Clearing flags on attachment: 276613

Committed r199651: <http://trac.webkit.org/changeset/199651>
Comment 5 WebKit Commit Bot 2016-04-17 23:52:31 PDT 
All reviewed patches have been landed.  Closing bug.
Comment 6 Alex Christensen 2016-04-18 00:08:27 PDT 
There's probably a similar assumption in WebKit2/CMakeLists.txt.
Comment 7 Alex Christensen 2016-04-18 00:14:28 PDT 
(In reply to comment #6)
> There's probably a similar assumption in WebKit2/CMakeLists.txt.
Fixed in https://bugs.webkit.org/show_bug.cgi?id=156679