WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
156268
Make CMake-generated binaries on Mac able to run
https://bugs.webkit.org/show_bug.cgi?id=156268
Summary
Make CMake-generated binaries on Mac able to run
Alex Christensen
Reported
2016-04-05 17:39:12 PDT
Make CMake-generated binaries on Mac able to run
Attachments
Patch
(11.63 KB, patch)
2016-04-05 17:39 PDT
,
Alex Christensen
no flags
Details
Formatted Diff
Diff
Patch
(12.01 KB, patch)
2016-04-05 18:05 PDT
,
Alex Christensen
dbates
: review+
Details
Formatted Diff
Diff
Show Obsolete
(1)
View All
Add attachment
proposed patch, testcase, etc.
Alex Christensen
Comment 1
2016-04-05 17:39:36 PDT
Created
attachment 275729
[details]
Patch
Alex Christensen
Comment 2
2016-04-05 18:05:43 PDT
Created
attachment 275734
[details]
Patch
Daniel Bates
Comment 3
2016-04-05 22:00:03 PDT
Comment on
attachment 275734
[details]
Patch r=me
Alex Christensen
Comment 4
2016-04-05 22:32:21 PDT
Committed to
http://trac.webkit.org/changeset/199094
with one change from the patch: I hardcoded -compatibility_version 1 instead of ${WEBKIT_MAC_VERSION} because that is what Xcode does right now.
Alex Christensen
Comment 5
2016-04-05 22:36:24 PDT
Next step: getting them to run without crashing. Right now sizeof(WebCore::Page) is inconsistent, causing horrible crashes :(
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug