Bug 156268 - Make CMake-generated binaries on Mac able to run
Summary: Make CMake-generated binaries on Mac able to run
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Alex Christensen
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2016-04-05 17:39 PDT by Alex Christensen
Modified: 2016-04-05 22:36 PDT (History)
4 users (show)

See Also:


Attachments
Patch (11.63 KB, patch)
2016-04-05 17:39 PDT, Alex Christensen
no flags Details | Formatted Diff | Diff
Patch (12.01 KB, patch)
2016-04-05 18:05 PDT, Alex Christensen
dbates: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Alex Christensen 2016-04-05 17:39:12 PDT
Make CMake-generated binaries on Mac able to run
Comment 1 Alex Christensen 2016-04-05 17:39:36 PDT
Created attachment 275729 [details]
Patch
Comment 2 Alex Christensen 2016-04-05 18:05:43 PDT
Created attachment 275734 [details]
Patch
Comment 3 Daniel Bates 2016-04-05 22:00:03 PDT
Comment on attachment 275734 [details]
Patch

r=me
Comment 4 Alex Christensen 2016-04-05 22:32:21 PDT
Committed to http://trac.webkit.org/changeset/199094 with one change from the patch: I hardcoded -compatibility_version 1 instead of ${WEBKIT_MAC_VERSION} because that is what Xcode does right now.
Comment 5 Alex Christensen 2016-04-05 22:36:24 PDT
Next step: getting them to run without crashing.  Right now sizeof(WebCore::Page) is inconsistent, causing horrible crashes :(