Bug 156679 - Trunk r198947 (Compile DumpRenderTree with CMake on Mac) causes build failures on OSX
Summary: Trunk r198947 (Compile DumpRenderTree with CMake on Mac) causes build failure...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords:
: 156616 (view as bug list)
Depends on:
Blocks: 126492
  Show dependency tree / graph
 
Reported: 2016-04-17 13:35 PDT by Jeremy Huddleston Sequoia
Modified: 2016-04-18 01:09 PDT (History)
1 user (show)

See Also:

Attachments
0001-Fix-incorrect-assumption-that-APPLE-implies-Mac (3.61 KB, patch)
2016-04-17 14:02 PDT, Jeremy Huddleston Sequoia 		no flags Details | Formatted Diff | Diff
0001-Fix-incorrect-assumption-that-APPLE-implies-Mac (3.76 KB, patch)
2016-04-17 14:50 PDT, Jeremy Huddleston Sequoia 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Jeremy Huddleston Sequoia 2016-04-17 13:35:40 PDT 
The changes in r198947 for https://bugs.webkit.org/show_bug.cgi?id=156088 introduced build failures on OSX.

The changes in r198947 assume that APPLE implies bundled framework.  This certainly doesn't work for the GTK build and I suspect also fails for QT.

I believe you should be using (PORT STREQUAL "Mac") instead.
Comment 1 Jeremy Huddleston Sequoia 2016-04-17 14:02:30 PDT 
Created attachment 276597 [details]
0001-Fix-incorrect-assumption-that-APPLE-implies-Mac

Presumptive fix.  Testing it now.
Comment 2 Jeremy Huddleston Sequoia 2016-04-17 14:44:07 PDT 
This change fixes the issue in WebKit, but looks like more recent changes on master caused it to not apply cleanly.
Comment 3 Jeremy Huddleston Sequoia 2016-04-17 14:50:38 PDT 
Created attachment 276598 [details]
0001-Fix-incorrect-assumption-that-APPLE-implies-Mac
Comment 4 Jeremy Huddleston Sequoia 2016-04-17 14:54:26 PDT 
*** Bug 156616 has been marked as a duplicate of this bug. ***
Comment 5 WebKit Commit Bot 2016-04-18 01:09:42 PDT 
Comment on attachment 276598 [details]
0001-Fix-incorrect-assumption-that-APPLE-implies-Mac

Clearing flags on attachment: 276598

Committed r199656: <http://trac.webkit.org/changeset/199656>
Comment 6 WebKit Commit Bot 2016-04-18 01:09:45 PDT 
All reviewed patches have been landed.  Closing bug.