Bug 156088 - Compile DumpRenderTree with CMake on Mac
Summary: Compile DumpRenderTree with CMake on Mac
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Alex Christensen
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2016-03-31 16:09 PDT by Alex Christensen
Modified: 2016-04-17 13:20 PDT (History)
6 users (show)

See Also:

Attachments
Patch (27.06 KB, patch)
2016-03-31 16:23 PDT, Alex Christensen 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Alex Christensen 2016-03-31 16:09:01 PDT 
Compile DumpRenderTree with CMake on Mac
Comment 1 Alex Christensen 2016-03-31 16:23:23 PDT 
Created attachment 275352 [details]
Patch
Comment 2 Brent Fulgham 2016-03-31 19:42:56 PDT 
Comment on attachment 275352 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=275352&action=review

> Source/WebKit2/PlatformMac.cmake:446
> +set(WebKit2_NetworkProcess_OUTPUT_NAME com.apple.WebKit.Networking.Development.xpc)

Maybe you can key this off of the "OFFICIAL_BUILD" compile flag we use for, well, "official builds"?

> Source/WebKit2/PlatformMac.cmake:714
> +file(WRITE ${DERIVED_SOURCES_DIR}/ForwardingHeaders/WebKit/WebDatabaseManagerPrivate.h "#import <WebKit/mac/Storage/WebDatabaseManagerPrivate.h>")

Is this needed because of a bad include path in our sources?
Comment 3 Alex Christensen 2016-04-01 08:55:35 PDT 
Comment on attachment 275352 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=275352&action=review

>> Source/WebKit2/PlatformMac.cmake:714
>> +file(WRITE ${DERIVED_SOURCES_DIR}/ForwardingHeaders/WebKit/WebDatabaseManagerPrivate.h "#import <WebKit/mac/Storage/WebDatabaseManagerPrivate.h>")
> 
> Is this needed because of a bad include path in our sources?

Maybe
Comment 4 WebKit Commit Bot 2016-04-01 09:45:55 PDT 
Comment on attachment 275352 [details]
Patch

Clearing flags on attachment: 275352

Committed r198947: <http://trac.webkit.org/changeset/198947>
Comment 5 WebKit Commit Bot 2016-04-01 09:45:59 PDT 
All reviewed patches have been landed.  Closing bug.
Comment 6 Csaba Osztrogonác 2016-04-04 02:33:36 PDT 
(In reply to comment #4)
> Comment on attachment 275352 [details]
> Patch
> 
> Clearing flags on attachment: 275352
> 
> Committed r198947: <http://trac.webkit.org/changeset/198947>

It broke the Apple Mac cmake build. :)
Comment 7 Csaba Osztrogonác 2016-04-04 02:34:30 PDT 
(In reply to comment #4)
> Comment on attachment 275352 [details]
> Patch
> 
> Clearing flags on attachment: 275352
> 
> Committed r198947: <http://trac.webkit.org/changeset/198947>

and http://trac.webkit.org/changeset/198948
Comment 8 Jeremy Huddleston Sequoia 2016-04-17 13:20:26 PDT 
This caused build failures of webkit-gtk on mac.