WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
155168
Refactor RenderMathMLSpace to avoid using flexbox
https://bugs.webkit.org/show_bug.cgi?id=155168
Summary
Refactor RenderMathMLSpace to avoid using flexbox
Frédéric Wang (:fredw)
Reported
2016-03-08 06:19:39 PST
To prepare for
bug 153991
, let's do as in other classes and implement RenderMathMLSpace::computePreferredLogicalWidths, RenderMathMLSpace::layoutBlock and RenderMathMLSpace::firstLineBaseline
Attachments
Patch
(5.48 KB, patch)
2016-03-08 06:24 PST
,
Frédéric Wang (:fredw)
no flags
Details
Formatted Diff
Diff
Patch
(6.70 KB, patch)
2016-03-11 01:27 PST
,
Frédéric Wang (:fredw)
no flags
Details
Formatted Diff
Diff
Patch
(6.71 KB, patch)
2016-03-31 08:24 PDT
,
Frédéric Wang (:fredw)
mrobinson
: review+
Details
Formatted Diff
Diff
Patch
(5.97 KB, patch)
2016-04-20 05:47 PDT
,
Frédéric Wang (:fredw)
no flags
Details
Formatted Diff
Diff
Show Obsolete
(2)
View All
Add attachment
proposed patch, testcase, etc.
Frédéric Wang (:fredw)
Comment 1
2016-03-08 06:24:43 PST
Created
attachment 273293
[details]
Patch
Frédéric Wang (:fredw)
Comment 2
2016-03-11 01:27:28 PST
Created
attachment 273707
[details]
Patch I'm uploading updated version of the MathML refactoring patches to solve conflicts after
bug 154388
and
bug 155005
; and to do other minor changes.
Frédéric Wang (:fredw)
Comment 3
2016-03-31 08:24:01 PDT
Created
attachment 275291
[details]
Patch
Martin Robinson
Comment 4
2016-04-04 11:57:51 PDT
Comment on
attachment 275291
[details]
Patch View in context:
https://bugs.webkit.org/attachment.cgi?id=275291&action=review
> LayoutTests/ChangeLog:8 > + * mathml/presentation/mspace-prefered-width-expected.html: Update the expectation so that the logical width and preferred width are both equal to the one specified by the width attribute.
Please break lines at 100 characters.
> Source/WebCore/ChangeLog:8 > + No new tests, already covered by existing tests. The behavior of mspace-prefered-width-expected is not specified by the MathML recommendation, we update that test to match our new behavior.
Ditto.
Frédéric Wang (:fredw)
Comment 5
2016-04-20 05:47:09 PDT
Created
attachment 276819
[details]
Patch Rebasing patch.
Frédéric Wang (:fredw)
Comment 6
2016-04-20 06:09:00 PDT
Removing dependencies as we don't really have to wait for
bug 155018
/155019 to take this patch.
Frédéric Wang (:fredw)
Comment 7
2016-04-20 06:25:31 PDT
Committed
r199771
: <
http://trac.webkit.org/changeset/199771
>
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug