Bug 154046 - Add SPI to remove individual user scripts or user style sheets
Summary: Add SPI to remove individual user scripts or user style sheets
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Anders Carlsson
URL:
Keywords:
: 154052 (view as bug list)
Depends on: 154056 154103
Blocks:
  Show dependency tree / graph
 
Reported: 2016-02-09 14:09 PST by Anders Carlsson
Modified: 2016-02-11 02:34 PST (History)
4 users (show)

See Also:

Attachments
Patch (13.04 KB, patch)
2016-02-09 14:12 PST, Anders Carlsson 		no flags Details | Formatted Diff | Diff
Patch (13.08 KB, patch)
2016-02-09 14:55 PST, Anders Carlsson 		sam: review+
Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Anders Carlsson 2016-02-09 14:09:50 PST 
Add SPI to remove individual user scripts or user style sheets
Comment 1 Anders Carlsson 2016-02-09 14:12:06 PST 
Created attachment 270952 [details]
Patch
Comment 2 mitz 2016-02-09 14:37:23 PST 
Comment on attachment 270952 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=270952&action=review

> Source/WebKit2/UIProcess/API/Cocoa/WKUserContentControllerPrivate.h:42
> +@property (nonatomic, readonly, copy) WK_ARRAY(_WKUserStyleSheet *) *_userStyleSheets;

This looks new. Why no availability?
Comment 3 Anders Carlsson 2016-02-09 14:43:16 PST 
(In reply to comment #2)
> Comment on attachment 270952 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=270952&action=review
> 
> > Source/WebKit2/UIProcess/API/Cocoa/WKUserContentControllerPrivate.h:42
> > +@property (nonatomic, readonly, copy) WK_ARRAY(_WKUserStyleSheet *) *_userStyleSheets;
> 
> This looks new. Why no availability?

Oversight on my part. Fixed.
Comment 4 Anders Carlsson 2016-02-09 14:55:28 PST 
Created attachment 270955 [details]
Patch
Comment 5 Anders Carlsson 2016-02-09 15:04:28 PST 
Committed r196341: <http://trac.webkit.org/changeset/196341>
Comment 6 WebKit Commit Bot 2016-02-09 16:53:14 PST 
Re-opened since this is blocked by bug 154056
Comment 7 Ryan Haddad 2016-02-09 17:12:12 PST 
*** Bug 154052 has been marked as a duplicate of this bug. ***
Comment 8 Ryan Haddad 2016-02-09 17:12:38 PST 
3 WKUserContentController API tests were failing on Mac and iOS after this change:

Tests that failed:
  WKUserContentController.AddUserStyleSheetBeforeCreatingView
  WKUserContentController.UserStyleSheetAffectingAllFrames
  WKUserContentController.UserStyleSheetAffectingOnlyMainFrame

<https://build.webkit.org/builders/Apple%20El%20Capitan%20Release%20WK2%20%28Tests%29/builds/3215>

FAIL WKUserContentController.AddUserStyleSheetBeforeCreatingView

/Volumes/Data/slave/elcapitan-release/build/Tools/TestWebKitAPI/Tests/WebKit2Cocoa/UserContentController.mm:276
Value of: value
  Actual: "rgb(255, 0, 0)"
Expected: color
Which is: "rgb(0, 128, 0)"

FAIL WKUserContentController.UserStyleSheetAffectingAllFrames

/Volumes/Data/slave/elcapitan-release/build/Tools/TestWebKitAPI/Tests/WebKit2Cocoa/UserContentController.mm:276
Value of: value
  Actual: "rgb(255, 0, 0)"
Expected: color
Which is: "rgb(0, 128, 0)"


/Volumes/Data/slave/elcapitan-release/build/Tools/TestWebKitAPI/Tests/WebKit2Cocoa/UserContentController.mm:276
Value of: value
  Actual: "rgba(0, 0, 0, 0)"
Expected: color
Which is: "rgb(0, 128, 0)"

FAIL WKUserContentController.UserStyleSheetAffectingOnlyMainFrame

/Volumes/Data/slave/elcapitan-release/build/Tools/TestWebKitAPI/Tests/WebKit2Cocoa/UserContentController.mm:276
Value of: value
  Actual: "rgb(255, 0, 0)"
Expected: color
Which is: "rgb(0, 128, 0)"
Comment 9 Anders Carlsson 2016-02-10 15:57:31 PST 
Committed r196399: <http://trac.webkit.org/changeset/196399>
Comment 10 Frédéric Wang (:fredw) 2016-02-11 01:58:59 PST 
(In reply to comment #9)
> Committed r196399: <http://trac.webkit.org/changeset/196399>

This broke the GTK build.