RESOLVED FIXED 154103
[GTK] Build error after bug 154046
https://bugs.webkit.org/show_bug.cgi?id=154103
Summary [GTK] Build error after bug 154046
Frédéric Wang (:fredw)
Reported 2016-02-11 02:34:09 PST
../../Source/WebKit2/UIProcess/API/gtk/WebKitUserContentManager.cpp ../../Source/WebKit2/UIProcess/API/gtk/WebKitUserContentManager.cpp: In function ‘void webkit_user_content_manager_add_style_sheet(WebKitUserContentManager*, WebKitUserStyleSheet*)’: ../../Source/WebKit2/UIProcess/API/gtk/WebKitUserContentManager.cpp:130:110: error: no matching function for call to ‘WebKit::WebUserContentControllerProxy::addUserStyleSheet(const WebCore::UserStyleSheet&)’ manager->priv->userContentController->addUserStyleSheet(webkitUserStyleSheetGetUserStyleSheet(styleSheet)); ^ ../../Source/WebKit2/UIProcess/API/gtk/WebKitUserContentManager.cpp:130:110: note: candidate is: In file included from ../../Source/WebKit2/UIProcess/API/gtk/WebKitUserContentManagerPrivate.h:24:0, from ../../Source/WebKit2/UIProcess/API/gtk/WebKitUserContentManager.cpp:26: ../../Source/WebKit2/UIProcess/UserContent/WebUserContentControllerProxy.h:80:10: note: void WebKit::WebUserContentControllerProxy::addUserStyleSheet(API::UserStyleSheet&) void addUserStyleSheet(API::UserStyleSheet&); ^ ../../Source/WebKit2/UIProcess/UserContent/WebUserContentControllerProxy.h:80:10: note: no known conversion for argument 1 from ‘const WebCore::UserStyleSheet’ to ‘API::UserStyleSheet&’ ninja: build stopped: subcommand failed.
Attachments
Patch (3.26 KB, patch)
2016-02-11 02:36 PST, Frédéric Wang (:fredw)
no flags
Frédéric Wang (:fredw)
Comment 1 2016-02-11 02:36:52 PST
WebKit Commit Bot
Comment 2 2016-02-11 02:38:32 PST
Thanks for the patch. If this patch contains new public API please make sure it follows the guidelines for new WebKit2 GTK+ API. See http://trac.webkit.org/wiki/WebKitGTK/AddingNewWebKit2API
WebKit Commit Bot
Comment 3 2016-02-11 06:30:55 PST
Comment on attachment 271054 [details] Patch Clearing flags on attachment: 271054 Committed r196420: <http://trac.webkit.org/changeset/196420>
WebKit Commit Bot
Comment 4 2016-02-11 06:30:58 PST
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.