Bug 153808 – Modern IDB: WebKit 2 IPC layer

• Status: RESOLVED
• Resolution: FIXED
• Component: WebKit2

[Brady Eidson]

Modern IDB: WebKit 2 IPC layer

[Brady Eidson]

The remaining work on this should be small.

I'm attaching a WIP patch that enables modern IDB and then runs WK2 against the exact same set of tests as WK1.

With this patch as-is, there are 14 text failures and 2 database process assertions.
Everything else passes.

I'll poke at the failures a bit to see if only small tweaks can fix them.

[Brady Eidson]

Created attachment 272164 [details]
Patch WIP

[Brady Eidson]

Created attachment 272165 [details]
Patch WIP

Updated patch that vastly improves those failures.

[Brady Eidson]

Giving EWS a run on this before I get back to it tomorroe

[Build Bot]

Comment on attachment 272165 [details]
Patch WIP

Attachment 272165 [details] did not pass mac-wk2-ews (mac-wk2):
Output: http://webkit-queues.webkit.org/results/879839

New failing tests:
storage/indexeddb/deletedatabase-delayed-by-open-and-versionchange.html
storage/indexeddb/database-odd-names.html

[Build Bot]

Created attachment 272170 [details]
Archive of layout-test-results from ews104 for mac-yosemite-wk2

The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews.
Bot: ews104  Port: mac-yosemite-wk2  Platform: Mac OS X 10.10.5

[Brady Eidson]

These failures are the 2 remaining ones on my machine. Hope to make short work of them tomorrow.

[Brady Eidson]

The DatabaseProcess crashers are assertions related to the inability to open files calculated from "odd" database names.

I filed https://bugs.webkit.org/show_bug.cgi?id=154681 to track that and will skip them for now when landing this patch.

[Brady Eidson]

Created attachment 272214 [details]
Patch v1

[WebKit Commit Bot]

Comment on attachment 272214 [details]
Patch v1

Clearing flags on attachment: 272214

Committed r197122: <http://trac.webkit.org/changeset/197122>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.