Modern IDB: Encoder/Decoder/Messaging scaffolding
Created attachment 271578 [details] Patch v1
Comment on attachment 271578 [details] Patch v1 View in context: https://bugs.webkit.org/attachment.cgi?id=271578&action=review > Source/WebCore/Modules/indexeddb/shared/IDBRequestData.h:143 > + request.m_requestIdentifier = std::make_unique<IDBResourceIdentifier>(identifier); There ought to be a better way to do this without requiring the use of the copy constructor.
(In reply to comment #2) > Comment on attachment 271578 [details] > Patch v1 > > View in context: > https://bugs.webkit.org/attachment.cgi?id=271578&action=review > > > Source/WebCore/Modules/indexeddb/shared/IDBRequestData.h:143 > > + request.m_requestIdentifier = std::make_unique<IDBResourceIdentifier>(identifier); > > There ought to be a better way to do this without requiring the use of the > copy constructor. As discussed in person, but here for the record: YES PLEASE... MessageEncoder and MessageDecoder should have built-in ways for encoding/decoding "optionally null objects on the heap"
(In reply to comment #3) > (In reply to comment #2) > > Comment on attachment 271578 [details] > > Patch v1 > > > > View in context: > > https://bugs.webkit.org/attachment.cgi?id=271578&action=review > > > > > Source/WebCore/Modules/indexeddb/shared/IDBRequestData.h:143 > > > + request.m_requestIdentifier = std::make_unique<IDBResourceIdentifier>(identifier); > > > > There ought to be a better way to do this without requiring the use of the > > copy constructor. > > As discussed in person, but here for the record: YES PLEASE... > MessageEncoder and MessageDecoder should have built-in ways for > encoding/decoding "optionally null objects on the heap" But, outside the scope of this patch to add that.
Comment on attachment 271578 [details] Patch v1 Clearing flags on attachment: 271578 Committed r196715: <http://trac.webkit.org/changeset/196715>
All reviewed patches have been landed. Closing bug.