Bug 154351 – Modern IDB: Encoder/Decoder/Messaging scaffolding for WK2 IPC

• Status: RESOLVED
• Resolution: FIXED
• Component: WebCore Misc.

[Brady Eidson]

Modern IDB: Encoder/Decoder/Messaging scaffolding

[Brady Eidson]

Created attachment 271578 [details]
Patch v1

[Alex Christensen]

Comment on attachment 271578 [details]
Patch v1

View in context: https://bugs.webkit.org/attachment.cgi?id=271578&action=review

> Source/WebCore/Modules/indexeddb/shared/IDBRequestData.h:143
> +        request.m_requestIdentifier = std::make_unique<IDBResourceIdentifier>(identifier);

There ought to be a better way to do this without requiring the use of the copy constructor.

[Brady Eidson]

(In reply to comment #2)
> Comment on attachment 271578 [details]
> Patch v1
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=271578&action=review
> 
> > Source/WebCore/Modules/indexeddb/shared/IDBRequestData.h:143
> > +        request.m_requestIdentifier = std::make_unique<IDBResourceIdentifier>(identifier);
> 
> There ought to be a better way to do this without requiring the use of the
> copy constructor.

As discussed in person, but here for the record: YES PLEASE... MessageEncoder and MessageDecoder should have built-in ways for encoding/decoding "optionally null objects on the heap"

[Brady Eidson]

(In reply to comment #3)
> (In reply to comment #2)
> > Comment on attachment 271578 [details]
> > Patch v1
> > 
> > View in context:
> > https://bugs.webkit.org/attachment.cgi?id=271578&action=review
> > 
> > > Source/WebCore/Modules/indexeddb/shared/IDBRequestData.h:143
> > > +        request.m_requestIdentifier = std::make_unique<IDBResourceIdentifier>(identifier);
> > 
> > There ought to be a better way to do this without requiring the use of the
> > copy constructor.
> 
> As discussed in person, but here for the record: YES PLEASE...
> MessageEncoder and MessageDecoder should have built-in ways for
> encoding/decoding "optionally null objects on the heap"

But, outside the scope of this patch to add that.

[WebKit Commit Bot]

Comment on attachment 271578 [details]
Patch v1

Clearing flags on attachment: 271578

Committed r196715: <http://trac.webkit.org/changeset/196715>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.