Bug 154356 – Modern IDB: More Encoder/Decoder/Messaging scaffolding for WK2 IPC

• Status: RESOLVED
• Resolution: FIXED
• Component: WebCore Misc.

[Brady Eidson]

Modern IDB: More Encoder/Decoder/Messaging scaffolding for WK2 IPC

[Brady Eidson]

Created attachment 271584 [details]
Patch v1

[Alex Christensen]

Comment on attachment 271584 [details]
Patch v1

View in context: https://bugs.webkit.org/attachment.cgi?id=271584&action=review

> Source/WebCore/Modules/indexeddb/shared/IDBDatabaseInfo.h:62
> +    WEBCORE_EXPORT IDBDatabaseInfo();

I think this should go with the other constructor declaration.

> Source/WebKit2/WebProcess/Databases/IndexedDB/WebIDBConnectionToServer.messages.in:41
> +

intentional space?

[Brady Eidson]

(In reply to comment #2)
> Comment on attachment 271584 [details]
> Patch v1
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=271584&action=review
> 
> > Source/WebCore/Modules/indexeddb/shared/IDBDatabaseInfo.h:62
> > +    WEBCORE_EXPORT IDBDatabaseInfo();
> 
> I think this should go with the other constructor declaration.

I've been trying to make it clear - or at least suggest - that these default constructors are only for the sake of encoder/decoder (They didn't exist before today)

> 
> > Source/WebKit2/WebProcess/Databases/IndexedDB/WebIDBConnectionToServer.messages.in:41
> > +
> 
> intentional space?

Yes.

[Brady Eidson]

Created attachment 271595 [details]
Patch for linux EWS

[Brady Eidson]

GTK is broken for other reasons... I'm landing now.

[Brady Eidson]

http://trac.webkit.org/changeset/196725