Bug 152708 - isUntypedSpeculationForArithmetic is wrong
Summary: isUntypedSpeculationForArithmetic is wrong
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: JavaScriptCore (show other bugs)
Version: WebKit Nightly Build
Hardware: All All
: P2 Normal
Assignee: Mark Lam
URL:
Keywords:
Depends on:
Blocks: 152736
  Show dependency tree / graph
 
Reported: 2016-01-04 12:26 PST by Filip Pizlo
Modified: 2016-01-05 10:32 PST (History)
5 users (show)

See Also:

Attachments
proposed patch. (1.74 KB, patch)
2016-01-04 14:46 PST, Mark Lam 		fpizlo: review+
Details | Formatted Diff | Diff
x86_64 benchmark result. (66.40 KB, text/plain)
2016-01-04 14:49 PST, Mark Lam 		no flags Details
x86 benchmark result. (65.98 KB, text/plain)
2016-01-04 14:49 PST, Mark Lam 		no flags Details
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Filip Pizlo 2016-01-04 12:26:26 PST 
It will currently return true anytime that the prediction set does not contain numeric types.  That's not correct.
Comment 1 Mark Lam 2016-01-04 14:46:59 PST 
Created attachment 268235 [details]
proposed patch.
Comment 2 Mark Lam 2016-01-04 14:49:09 PST 
Created attachment 268236 [details]
x86_64 benchmark result.
Comment 3 Mark Lam 2016-01-04 14:49:43 PST 
Created attachment 268237 [details]
x86 benchmark result.
Comment 4 Mark Lam 2016-01-04 14:56:12 PST 
Thanks for the review.  Landed in r194560: <http://trac.webkit.org/r194560>.