Bug 152736 - Make ftl-polymorphic-xxx tests more polymorphic.
Summary: Make ftl-polymorphic-xxx tests more polymorphic.
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: JavaScriptCore (show other bugs)
Version: WebKit Local Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Mark Lam
URL:
Keywords:
Depends on: 152708
Blocks:
  Show dependency tree / graph
 
Reported: 2016-01-05 10:31 PST by Mark Lam
Modified: 2016-01-05 12:39 PST (History)
7 users (show)

See Also:

Attachments
proposed patch. (14.95 KB, patch)
2016-01-05 10:53 PST, Mark Lam 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Mark Lam 2016-01-05 10:31:27 PST 
This is needed to show the benefits of the bug fix in r194560: <http://trac.webkit.org/r194560>.
Comment 1 Mark Lam 2016-01-05 10:53:01 PST 
Created attachment 268291 [details]
proposed patch.
Comment 2 Mark Lam 2016-01-05 10:54:24 PST 
Benchmark results:

32-bit x86:
                                   base32                    new32                                       

ftl-polymorphic-bitand       438.6813+-5.5200     ^    419.3707+-8.7194        ^ definitely 1.0460x faster
ftl-polymorphic-bitor        436.4698+-9.0457          423.4412+-13.4575         might be 1.0308x faster
ftl-polymorphic-bitxor       435.5074+-7.7446          420.9383+-10.8230         might be 1.0346x faster
ftl-polymorphic-div         1035.5532+-19.3121    ^    888.5800+-12.8470       ^ definitely 1.1654x faster
ftl-polymorphic-lshift       477.8201+-7.1122     ?    484.8278+-3.9323        ? might be 1.0147x slower
ftl-polymorphic-mul          734.8997+-13.1643    ^    556.3594+-2.5985        ^ definitely 1.3209x faster
ftl-polymorphic-rshift       471.3873+-11.0434    ?    485.7097+-6.5891        ? might be 1.0304x slower
ftl-polymorphic-sub          664.7216+-24.3030    ^    485.1122+-7.4716        ^ definitely 1.3702x faster
ftl-polymorphic-urshift      556.2922+-7.1576     ^    489.4644+-20.6402       ^ definitely 1.1365x faster

<geometric>                  558.4487+-2.4824     ^    503.1079+-5.0828        ^ definitely 1.1100x faster

64-bit x86_64:
                                   base64                    new64                                       

ftl-polymorphic-bitand       429.4120+-11.6639    ^    158.4169+-9.2592        ^ definitely 2.7106x faster
ftl-polymorphic-bitor        426.9303+-6.4924     ^    158.1396+-3.5201        ^ definitely 2.6997x faster
ftl-polymorphic-bitxor       433.5088+-2.9996     ^    157.8170+-4.6547        ^ definitely 2.7469x faster
ftl-polymorphic-div         1043.1423+-9.7208     ^    615.3205+-2.7054        ^ definitely 1.6953x faster
ftl-polymorphic-lshift       510.7916+-10.2317    ^    201.7161+-9.6339        ^ definitely 2.5322x faster
ftl-polymorphic-mul          617.5995+-20.1207    ^    302.7993+-7.9359        ^ definitely 2.0396x faster
ftl-polymorphic-rshift       522.7670+-23.1329    ^    203.2807+-7.0183        ^ definitely 2.5717x faster
ftl-polymorphic-sub          530.7805+-3.3946     ^    233.0609+-16.9867       ^ definitely 2.2774x faster
ftl-polymorphic-urshift      581.1417+-12.3496    ^    216.1865+-7.5609        ^ definitely 2.6881x faster

<geometric>                  544.6146+-6.9738     ^    225.6836+-2.9312        ^ definitely 2.4132x faster
Comment 3 WebKit Commit Bot 2016-01-05 12:39:04 PST 
Comment on attachment 268291 [details]
proposed patch.

Clearing flags on attachment: 268291

Committed r194597: <http://trac.webkit.org/changeset/194597>
Comment 4 WebKit Commit Bot 2016-01-05 12:39:09 PST 
All reviewed patches have been landed.  Closing bug.