Bug 152705 - FTL B3 should do the ArithSub binary snippet
Summary: FTL B3 should do the ArithSub binary snippet
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: JavaScriptCore (show other bugs)
Version: WebKit Nightly Build
Hardware: All All
: P2 Normal
Assignee: Filip Pizlo
URL:
Keywords:
Depends on:
Blocks: 152668
  Show dependency treegraph
 
Reported: 2016-01-04 12:10 PST by Filip Pizlo
Modified: 2016-01-04 12:51 PST (History)
5 users (show)

See Also:


Attachments
the patch (9.48 KB, patch)
2016-01-04 12:32 PST, Filip Pizlo
no flags Details | Formatted Diff | Diff
the patch (9.48 KB, patch)
2016-01-04 12:32 PST, Filip Pizlo
no flags Details | Formatted Diff | Diff
the patch (8.90 KB, patch)
2016-01-04 12:33 PST, Filip Pizlo
sbarati: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Filip Pizlo 2016-01-04 12:10:07 PST
Gotta start somewhere.
Comment 1 Filip Pizlo 2016-01-04 12:27:10 PST
It turns out that the ArithSub DFG/FTL snippets are totally busted even for the simplest of test cases.  See: https://bugs.webkit.org/show_bug.cgi?id=152708
Comment 2 Filip Pizlo 2016-01-04 12:32:21 PST
Created attachment 268217 [details]
the patch
Comment 3 Filip Pizlo 2016-01-04 12:32:53 PST
Created attachment 268218 [details]
the patch
Comment 4 Filip Pizlo 2016-01-04 12:33:43 PST
Created attachment 268219 [details]
the patch
Comment 5 WebKit Commit Bot 2016-01-04 12:35:08 PST
Attachment 268219 [details] did not pass style-queue:


ERROR: Source/JavaScriptCore/ftl/FTLLowerDFGToLLVM.cpp:7410:  Place brace on its own line for function definitions.  [whitespace/braces] [4]
ERROR: Source/JavaScriptCore/ftl/FTLLowerDFGToLLVM.cpp:7424:  Place brace on its own line for function definitions.  [whitespace/braces] [4]
Total errors found: 2 in 4 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 6 Filip Pizlo 2016-01-04 12:51:54 PST
Landed in http://trac.webkit.org/changeset/194548