Bug 152004 - Fix computation of min|max-content contribution of non-replaced blocks
Summary: Fix computation of min|max-content contribution of non-replaced blocks
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Sergio Villar Senin
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2015-12-08 11:23 PST by Sergio Villar Senin
Modified: 2016-01-01 20:13 PST (History)
11 users (show)

See Also:

Attachments
Patch (48.74 KB, patch)
2015-12-08 11:29 PST, Sergio Villar Senin 		no flags Details | Formatted Diff | Diff
Archive of layout-test-results from ews105 for mac-yosemite-wk2 (1.77 MB, application/zip)
2015-12-08 12:01 PST, Build Bot 		no flags Details
Archive of layout-test-results from ews100 for mac-yosemite (1.70 MB, application/zip)
2015-12-08 12:16 PST, Build Bot 		no flags Details
Archive of layout-test-results from ews115 for mac-yosemite (1.56 MB, application/zip)
2015-12-08 12:52 PST, Build Bot 		no flags Details
Patch (48.71 KB, patch)
2015-12-09 07:32 PST, Sergio Villar Senin 		no flags Details | Formatted Diff | Diff
Archive of layout-test-results from ews102 for mac-yosemite (1.00 MB, application/zip)
2015-12-09 07:58 PST, Build Bot 		no flags Details
Archive of layout-test-results from ews105 for mac-yosemite-wk2 (1.08 MB, application/zip)
2015-12-09 08:03 PST, Build Bot 		no flags Details
Archive of layout-test-results from ews114 for mac-yosemite (952.45 KB, application/zip)
2015-12-09 11:51 PST, Build Bot 		no flags Details
Patch (48.81 KB, patch)
2015-12-14 11:46 PST, Sergio Villar Senin 		no flags Details | Formatted Diff | Diff
Archive of layout-test-results from ews102 for mac-yosemite (760.38 KB, application/zip)
2015-12-14 12:35 PST, Build Bot 		no flags Details
Archive of layout-test-results from ews104 for mac-yosemite-wk2 (790.11 KB, application/zip)
2015-12-14 12:39 PST, Build Bot 		no flags Details
Archive of layout-test-results from ews114 for mac-yosemite (814.16 KB, application/zip)
2015-12-14 12:39 PST, Build Bot 		no flags Details
Patch (48.88 KB, patch)
2015-12-15 05:20 PST, Sergio Villar Senin 		darin: review+
buildbot: commit-queue-
Details | Formatted Diff | Diff
Archive of layout-test-results from ews107 for mac-yosemite-wk2 (1.19 MB, application/zip)
2015-12-15 06:13 PST, Build Bot 		no flags Details
Show Obsolete (3) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Sergio Villar Senin 2015-12-08 11:23:12 PST 
Fix computation of min|max-content contribution of non-replaced blocks
Comment 1 Sergio Villar Senin 2015-12-08 11:29:47 PST 
Created attachment 266917 [details]
Patch
Comment 2 Build Bot 2015-12-08 12:01:17 PST 
Comment on attachment 266917 [details]
Patch

Attachment 266917 [details] did not pass mac-wk2-ews (mac-wk2):
Output: http://webkit-queues.webkit.org/results/533711

New failing tests:
fast/dynamic/012.html
tables/mozilla/bugs/bug55694.html
tables/mozilla/bugs/bug24200.html
fast/table/fixed-with-auto-with-colspan-vertical.html
tables/mozilla/bugs/bug22019.html
tables/mozilla/bugs/bug8950.html
fast/css-generated-content/pseudo-animation.html
compositing/repaint/content-into-overflow.html
fast/repaint/content-into-overflow.html
tables/mozilla/bugs/bug59354.html
fast/table/fixed-with-auto-with-colspan.html
fast/css-generated-content/pseudo-transition.html
fast/table/032.html
tables/mozilla/bugs/bug4576.html
fast/borders/fieldsetBorderRadius.html
tables/mozilla/bugs/bug2123.html
fast/table/005.html
tables/mozilla_expected_failures/bugs/bug59252.html
tables/mozilla/bugs/bug2981-2.html
fast/writing-mode/table-percent-width-quirk.html
Comment 3 Build Bot 2015-12-08 12:01:21 PST 
Created attachment 266924 [details]
Archive of layout-test-results from ews105 for mac-yosemite-wk2

The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews.
Bot: ews105  Port: mac-yosemite-wk2  Platform: Mac OS X 10.10.5
Comment 4 Build Bot 2015-12-08 12:15:56 PST 
Comment on attachment 266917 [details]
Patch

Attachment 266917 [details] did not pass mac-ews (mac):
Output: http://webkit-queues.webkit.org/results/533781

New failing tests:
tables/mozilla/bugs/bug55694.html
tables/mozilla/bugs/bug24200.html
fast/table/fixed-with-auto-with-colspan-vertical.html
tables/mozilla/bugs/bug22019.html
tables/mozilla/bugs/bug8950.html
fast/css-generated-content/pseudo-animation.html
tables/mozilla/bugs/bug2981-2.html
fast/table/005.html
fast/repaint/content-into-overflow.html
tables/mozilla/bugs/bug59354.html
fast/table/fixed-with-auto-with-colspan.html
fast/css-generated-content/pseudo-transition.html
fast/table/032.html
tables/mozilla/bugs/bug2123.html
fast/borders/fieldsetBorderRadius.html
tables/mozilla_expected_failures/bugs/bug59252.html
tables/mozilla/bugs/bug4576.html
fast/writing-mode/table-percent-width-quirk.html
Comment 5 Build Bot 2015-12-08 12:16:01 PST 
Created attachment 266925 [details]
Archive of layout-test-results from ews100 for mac-yosemite

The attached test failures were seen while running run-webkit-tests on the mac-ews.
Bot: ews100  Port: mac-yosemite  Platform: Mac OS X 10.10.5
Comment 6 Build Bot 2015-12-08 12:51:57 PST 
Comment on attachment 266917 [details]
Patch

Attachment 266917 [details] did not pass mac-debug-ews (mac):
Output: http://webkit-queues.webkit.org/results/533867

New failing tests:
tables/mozilla/bugs/bug2123.html
tables/mozilla/bugs/bug55694.html
tables/mozilla/bugs/bug24200.html
fast/table/fixed-with-auto-with-colspan-vertical.html
tables/mozilla/bugs/bug22019.html
tables/mozilla/bugs/bug8950.html
fast/css-generated-content/pseudo-animation.html
fast/table/005.html
fast/repaint/content-into-overflow.html
tables/mozilla/bugs/bug59354.html
fast/table/fixed-with-auto-with-colspan.html
fast/css-generated-content/pseudo-transition.html
tables/mozilla/bugs/bug4576.html
fast/borders/fieldsetBorderRadius.html
tables/mozilla_expected_failures/bugs/bug59252.html
fast/writing-mode/table-percent-width-quirk.html
tables/mozilla/bugs/bug2981-2.html
fast/table/032.html
Comment 7 Build Bot 2015-12-08 12:52:02 PST 
Created attachment 266930 [details]
Archive of layout-test-results from ews115 for mac-yosemite

The attached test failures were seen while running run-webkit-tests on the mac-debug-ews.
Bot: ews115  Port: mac-yosemite  Platform: Mac OS X 10.10.5
Comment 8 Sergio Villar Senin 2015-12-09 07:32:53 PST 
Created attachment 267003 [details]
Patch

Fixed failing table test cases
Comment 9 Build Bot 2015-12-09 07:58:08 PST 
Comment on attachment 267003 [details]
Patch

Attachment 267003 [details] did not pass mac-ews (mac):
Output: http://webkit-queues.webkit.org/results/537259

New failing tests:
fast/repaint/content-into-overflow.html
fast/css-generated-content/pseudo-transition.html
fast/borders/fieldsetBorderRadius.html
fast/css-generated-content/pseudo-animation.html
Comment 10 Build Bot 2015-12-09 07:58:11 PST 
Created attachment 267004 [details]
Archive of layout-test-results from ews102 for mac-yosemite

The attached test failures were seen while running run-webkit-tests on the mac-ews.
Bot: ews102  Port: mac-yosemite  Platform: Mac OS X 10.10.5
Comment 11 Build Bot 2015-12-09 08:03:00 PST 
Comment on attachment 267003 [details]
Patch

Attachment 267003 [details] did not pass mac-wk2-ews (mac-wk2):
Output: http://webkit-queues.webkit.org/results/537267

New failing tests:
fast/repaint/content-into-overflow.html
compositing/repaint/content-into-overflow.html
fast/borders/fieldsetBorderRadius.html
fast/css-generated-content/pseudo-transition.html
fast/css-generated-content/pseudo-animation.html
Comment 12 Build Bot 2015-12-09 08:03:03 PST 
Created attachment 267005 [details]
Archive of layout-test-results from ews105 for mac-yosemite-wk2

The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews.
Bot: ews105  Port: mac-yosemite-wk2  Platform: Mac OS X 10.10.5
Comment 13 Build Bot 2015-12-09 11:51:01 PST 
Comment on attachment 267003 [details]
Patch

Attachment 267003 [details] did not pass mac-debug-ews (mac):
Output: http://webkit-queues.webkit.org/results/537911

New failing tests:
fast/borders/fieldsetBorderRadius.html
fast/css-generated-content/pseudo-transition.html
fast/repaint/content-into-overflow.html
fast/css-generated-content/pseudo-animation.html
Comment 14 Build Bot 2015-12-09 11:51:06 PST 
Created attachment 267032 [details]
Archive of layout-test-results from ews114 for mac-yosemite

The attached test failures were seen while running run-webkit-tests on the mac-debug-ews.
Bot: ews114  Port: mac-yosemite  Platform: Mac OS X 10.10.5
Comment 15 Sergio Villar Senin 2015-12-14 11:46:52 PST 
Created attachment 267306 [details]
Patch
Comment 16 Build Bot 2015-12-14 12:35:22 PST 
Comment on attachment 267306 [details]
Patch

Attachment 267306 [details] did not pass mac-ews (mac):
Output: http://webkit-queues.webkit.org/results/559198

New failing tests:
fast/css-generated-content/pseudo-transition.html
fast/repaint/content-into-overflow.html
fast/css-generated-content/pseudo-animation.html
Comment 17 Build Bot 2015-12-14 12:35:25 PST 
Created attachment 267309 [details]
Archive of layout-test-results from ews102 for mac-yosemite

The attached test failures were seen while running run-webkit-tests on the mac-ews.
Bot: ews102  Port: mac-yosemite  Platform: Mac OS X 10.10.5
Comment 18 Build Bot 2015-12-14 12:39:06 PST 
Comment on attachment 267306 [details]
Patch

Attachment 267306 [details] did not pass mac-wk2-ews (mac-wk2):
Output: http://webkit-queues.webkit.org/results/559199

New failing tests:
compositing/repaint/content-into-overflow.html
fast/repaint/content-into-overflow.html
fast/css-generated-content/pseudo-transition.html
fast/css-generated-content/pseudo-animation.html
Comment 19 Build Bot 2015-12-14 12:39:10 PST 
Created attachment 267313 [details]
Archive of layout-test-results from ews104 for mac-yosemite-wk2

The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews.
Bot: ews104  Port: mac-yosemite-wk2  Platform: Mac OS X 10.10.5
Comment 20 Build Bot 2015-12-14 12:39:27 PST 
Comment on attachment 267306 [details]
Patch

Attachment 267306 [details] did not pass mac-debug-ews (mac):
Output: http://webkit-queues.webkit.org/results/559190

New failing tests:
fast/css-generated-content/pseudo-transition.html
fast/repaint/content-into-overflow.html
fast/css-generated-content/pseudo-animation.html
Comment 21 Build Bot 2015-12-14 12:39:31 PST 
Created attachment 267314 [details]
Archive of layout-test-results from ews114 for mac-yosemite

The attached test failures were seen while running run-webkit-tests on the mac-debug-ews.
Bot: ews114  Port: mac-yosemite  Platform: Mac OS X 10.10.5
Comment 22 Sergio Villar Senin 2015-12-15 05:20:26 PST 
Created attachment 267365 [details]
Patch

Properly unset the dirty flag after computing the preferred widths
Comment 23 Build Bot 2015-12-15 06:13:10 PST 
Comment on attachment 267365 [details]
Patch

Attachment 267365 [details] did not pass mac-wk2-ews (mac-wk2):
Output: http://webkit-queues.webkit.org/results/562393

New failing tests:
imported/w3c/web-platform-tests/XMLHttpRequest/timeout-sync.htm
Comment 24 Build Bot 2015-12-15 06:13:15 PST 
Created attachment 267367 [details]
Archive of layout-test-results from ews107 for mac-yosemite-wk2

The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews.
Bot: ews107  Port: mac-yosemite-wk2  Platform: Mac OS X 10.10.5
Comment 25 Sergio Villar Senin 2015-12-16 06:54:03 PST 
Committed r194143: <http://trac.webkit.org/changeset/194143>
Comment 26 Myles C. Maxfield 2016-01-01 20:13:20 PST 
This broke Wikipedia. See https://bugs.webkit.org/show_bug.cgi?id=152644