New tests introduced in http://trac.webkit.org/r192664 fail on ARM Linux tester bots. Maybe they fail on iOS too, but I don't know, because there is no (public) iOS JSC tester. 32 bit ARM bots: ----------------- - https://build.webkit.org/builders/EFL%20Linux%20ARMv7%20Thumb2%20Release/builds/16232 - https://build.webkit.org/builders/EFL%20Linux%20ARMv7%20Traditional%20Release/builds/16078 - https://build.webkit.org/builders/GTK%20Linux%20ARM%20Release/builds/9401 ** The following JSC stress test failures have been introduced: stress/op_rshift.js.always-trigger-copy-phase stress/op_rshift.js.default stress/op_rshift.js.dfg-maximal-flush-validate-no-cjit stress/op_rshift.js.no-cjit-validate-phases stress/op_rshift.js.no-llint stress/op_urshift.js.always-trigger-copy-phase stress/op_urshift.js.default stress/op_urshift.js.dfg-maximal-flush-validate-no-cjit stress/op_urshift.js.no-cjit-validate-phases stress/op_urshift.js.no-llint the 64 bit ARM bot: -------------------- - https://build.webkit.org/builders/EFL%20Linux%20AArch64%20Release/builds/4437 ** The following JSC stress test failures have been introduced: [snip] (older failures) stress/op_div.js.always-trigger-copy-phase stress/op_div.js.default stress/op_div.js.dfg-eager stress/op_div.js.dfg-eager-no-cjit-validate stress/op_div.js.dfg-maximal-flush-validate-no-cjit stress/op_div.js.no-cjit-validate-phases stress/op_div.js.no-llint [snip] (older failures)
I've confirmed the op_div failures on ARM64. Checking ARMv7 now.
I've also confirmed the op_rshift and op_urshift failures on ARMv7.
I filed https://bugs.webkit.org/show_bug.cgi?id=151514 to track the ARM32 bugs, and https://bugs.webkit.org/show_bug.cgi?id=151515 to track the ARM64 bug. I will skip those tests for now.
Created attachment 266004 [details] proposed patch.
Comment on attachment 266004 [details] proposed patch. r=me
Comment on attachment 266004 [details] proposed patch. Cancelling commit queue. Will commit manually.
Thanks for the review. Landed in r192708: <http://trac.webkit.org/r192708>.