Bug 151465 - Create correctness tests for binary snippet operators.
Summary: Create correctness tests for binary snippet operators.
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: JavaScriptCore (show other bugs)
Version: WebKit Local Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Mark Lam
URL:
Keywords:
Depends on: 151485
Blocks:
  Show dependency tree / graph
 
Reported: 2015-11-19 14:19 PST by Mark Lam
Modified: 2015-11-20 02:37 PST (History)
7 users (show)

See Also:

Attachments
proposed patch. (51.86 KB, patch)
2015-11-19 14:35 PST, Mark Lam 		ggaren: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Mark Lam 2015-11-19 14:19:50 PST 
Implement a common infrastructure for generating and running tests on binary operators.  Also refactored the op_add, op_sub, and op_mul tests to be based on this new infrastructure.
Comment 1 Mark Lam 2015-11-19 14:35:44 PST 
Created attachment 265905 [details]
proposed patch.
Comment 2 Geoffrey Garen 2015-11-19 14:39:15 PST 
Comment on attachment 265905 [details]
proposed patch.

r=me
Comment 3 Mark Lam 2015-11-19 15:17:49 PST 
Comment on attachment 265905 [details]
proposed patch.

Cancelling commit.  Will land manually.
Comment 4 Mark Lam 2015-11-19 15:32:44 PST 
Thanks for the review.  Landed in r192664: <http://trac.webkit.org/r192664>.