Bug 150765 – Update to match text-orientation spec

• Status: RESOLVED
• Resolution: FIXED
• Component: Text

[Myles C. Maxfield]

We currently have implemented an old version of the CSS Writing Modes [1] spec. We should update it.

AFAICT, this is the state of things:
1. Our "vertical-right" value matches the spec's "mixed" value
2. Our "upright" value matches the spec
3. Our "sideways-right" value matches the spec
4. We need to implement "sideways-left"
5. We need to update "sideways" to correctly match sideways-right / sideways-left

[1] http://www.w3.org/TR/css-writing-modes-3

[Koji Ishii]

A few comments:
* text-orientation: sideways-left is gone, no worry for that. writing-mode: sideways-lr, sideways-rl were added instead, so that we don't have to flip baseline within a single BFC. They're at risk though.
* text-combine was updated in both property name and value name, great if you could take care of this change too.

[Myles C. Maxfield]

(In reply to comment #1)
> A few comments:
> * text-orientation: sideways-left is gone, no worry for that. writing-mode:
> sideways-lr, sideways-rl were added instead, so that we don't have to flip
> baseline within a single BFC. They're at risk though.
> * text-combine was updated in both property name and value name, great if
> you could take care of this change too.

Thanks, Koji! I wasn't reading the dev version of the spec. I should make "sideways" a simple alias to "sideways-right".

Updating "writing-mode" to match the spec is a different bug. https://bugs.webkit.org/show_bug.cgi?id=150820

Same thing for text-combine: https://bugs.webkit.org/show_bug.cgi?id=150821

[Myles C. Maxfield]

Created attachment 264661 [details]
Patch

[WebKit Commit Bot]

Comment on attachment 264661 [details]
Patch

Clearing flags on attachment: 264661

Committed r191953: <http://trac.webkit.org/changeset/191953>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.