[Vertical Writing Mode] Rename "vertical-right" CSS value to match spec
Created attachment 264502 [details] Patch
Comment on attachment 264502 [details] Patch Attachment 264502 [details] did not pass mac-debug-ews (mac): Output: http://webkit-queues.webkit.org/results/365661 New failing tests: svg/css/getComputedStyle-basic.xhtml fast/css/getComputedStyle/computed-style.html fast/css/inherited-properties-rare-text.html fast/css/getComputedStyle/computed-style-without-renderer.html
Created attachment 264503 [details] Archive of layout-test-results from ews113 for mac-yosemite The attached test failures were seen while running run-webkit-tests on the mac-debug-ews. Bot: ews113 Port: mac-yosemite Platform: Mac OS X 10.10.5
Comment on attachment 264502 [details] Patch Attachment 264502 [details] did not pass mac-ews (mac): Output: http://webkit-queues.webkit.org/results/365691 New failing tests: svg/css/getComputedStyle-basic.xhtml fast/css/getComputedStyle/computed-style.html fast/css/inherited-properties-rare-text.html fast/css/getComputedStyle/computed-style-without-renderer.html
Created attachment 264504 [details] Archive of layout-test-results from ews102 for mac-mavericks The attached test failures were seen while running run-webkit-tests on the mac-ews. Bot: ews102 Port: mac-mavericks Platform: Mac OS X 10.9.5
Comment on attachment 264502 [details] Patch Attachment 264502 [details] did not pass mac-wk2-ews (mac-wk2): Output: http://webkit-queues.webkit.org/results/365695 New failing tests: svg/css/getComputedStyle-basic.xhtml fast/css/getComputedStyle/computed-style.html fast/css/inherited-properties-rare-text.html fast/css/getComputedStyle/computed-style-without-renderer.html
Created attachment 264505 [details] Archive of layout-test-results from ews106 for mac-mavericks-wk2 The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews. Bot: ews106 Port: mac-mavericks-wk2 Platform: Mac OS X 10.9.5
Comment on attachment 264502 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=264502&action=review > Source/WebCore/css/CSSParser.cpp:3110 > + // FIXME: For now just support sideways, sideways-right, upright and vertical-right (mixed). This is a confusing FIXME. The old one matched the code just below it, the new comment does not. What’s the value of this comment? How about just deleting it unless there is something to non-obvious to say.
Created attachment 264540 [details] Patch
Comment on attachment 264540 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=264540&action=review > Source/WebCore/rendering/style/RenderStyle.cpp:1827 > + return std::make_pair(Horizontal, NonCJKGlyphOrientationMixed); I think argument list syntax is superior: return { Horizontal, NonCJKGlyphOrientationMixed }; Unless it won’t work. > Source/WebCore/rendering/style/RenderStyle.h:713 > + std::pair<FontOrientation, NonCJKGlyphOrientation> getFontAndGlyphOrientation(); If you’re changing this to return a tuple then it should not be named “get” any more. We use “get” to mean “uses out arguments” and when we just return something, we name the function for what it’s returning.
Created attachment 264566 [details] Patch for committing
Created attachment 264569 [details] Patch for committing
Created attachment 264614 [details] Patch for committing
Comment on attachment 264614 [details] Patch for committing Attachment 264614 [details] did not pass mac-ews (mac): Output: http://webkit-queues.webkit.org/results/373652 New failing tests: storage/indexeddb/modern/idbobjectstore-count-failures.html
Created attachment 264633 [details] Archive of layout-test-results from ews100 for mac-mavericks The attached test failures were seen while running run-webkit-tests on the mac-ews. Bot: ews100 Port: mac-mavericks Platform: Mac OS X 10.9.5
Test failures are unrelated.
Created attachment 264649 [details] Patch for committing
Comment on attachment 264649 [details] Patch for committing Clearing flags on attachment: 264649 Committed r191935: <http://trac.webkit.org/changeset/191935>