The name of the property is now "text-combine-upright". In addition, the semantics of this property has changed, where the author is not required to mark up each bit of text they want to make horizontal. Instead, they just put text-combine-upright on the whole paragraph, and we do the right thing.
> the semantics of this property has changed
It's a bit confusing, sorry about that.
is semantically equivalent to
so this should be a simple renaming.
text-combine-upright: digits <integer>?
was added to do automatic detection of digits in a row within a text run as one implementer showed an interest. But this is not implemented by other implementers yet at this point and is at risk. Probably you read this part?
We should add the support for:
text-combine: digits 2
Chrome 48 supported it.
Pinging this bug report in the hope that Webkit can finish making the text-combine-upright property work.
The 'all' value is already supported in Gecko and Blink browsers, and this feature is really important for adequate handling of vertically-set text.
Supporting the 'digits' values would be good for content authors, since it requires less markup, and better semantic markup, and offers greater control.
Splitting this in 2 bits makes sense to me:
* Style work: Making -webkit-text-combine inherited, and implement text-combine-upright as an aliased property (with different values)
* Rendering work: Implement "digits" syntax
Created attachment 448001 [details]
Created attachment 448002 [details]
Created attachment 448006 [details]
Comment on attachment 448006 [details]
View in context: https://bugs.webkit.org/attachment.cgi?id=448006&action=review
> + This more or less gets to Chrome parity, though there's quite a bit of work
> + to match the standard, or even just reach Firefox parity.
Could you expand on this a bit? What still needs to be done? Are there open bugzillas?
Created attachment 448111 [details]
Committed r287487 (245622@trunk): <https://commits.webkit.org/245622@trunk>