Bug 234694 - Make -webkit-text-combine an inherited property
Summary: Make -webkit-text-combine an inherited property
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: CSS (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Tim Nguyen (:ntim)
URL:
Keywords: InRadar
Depends on:
Blocks: 150821
  Show dependency tree / graph
 
Reported: 2021-12-26 11:25 PST by Tim Nguyen (:ntim)
Modified: 2021-12-26 16:05 PST (History)
8 users (show)

See Also:

Attachments
Patch (11.81 KB, patch)
2021-12-26 11:28 PST, Tim Nguyen (:ntim) 		simon.fraser: review+
Details | Formatted Diff | Diff
Patch (3.44 KB, patch)
2021-12-26 11:39 PST, Tim Nguyen (:ntim) 		no flags Details | Formatted Diff | Diff
[fast-cq] Patch (11.68 KB, patch)
2021-12-26 15:59 PST, Tim Nguyen (:ntim) 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Tim Nguyen (:ntim) 2021-12-26 11:25:06 PST 
-webkit-text-combine is said to be inherited in CSSProperties.json, but it is not actually the case. It should be inherited per-spec (for text-combine-upright).

https://drafts.csswg.org/css-writing-modes/#text-combine-upright
Comment 1 Tim Nguyen (:ntim) 2021-12-26 11:26:21 PST 
Some WPT actually exist for this:

css/css-writing-modes/text-combine-upright-inherit-all-001.html
css/css-writing-modes/text-combine-upright-inherit-all-002.html
Comment 2 Tim Nguyen (:ntim) 2021-12-26 11:28:33 PST 
Created attachment 447983 [details]
Patch
Comment 3 Tim Nguyen (:ntim) 2021-12-26 11:39:45 PST 
Created attachment 447985 [details]
Patch
Comment 4 Tim Nguyen (:ntim) 2021-12-26 11:40:12 PST 
Comment on attachment 447985 [details]
Patch

Wrong bug
Comment 5 Simon Fraser (smfr) 2021-12-26 13:21:28 PST 
Comment on attachment 447983 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=447983&action=review

> LayoutTests/fast/text/text-combine-inherited.html:6
> +<link rel="author" title="Tim Nguyen" href="https://github.com/nt1m">
> +<link rel="match" href="text-combine-inherited-expected.html">

We don't normally add these to non-WPT tests.
Comment 6 Tim Nguyen (:ntim) 2021-12-26 15:59:59 PST 
Created attachment 447991 [details]
[fast-cq] Patch
Comment 7 EWS 2021-12-26 16:04:50 PST 
Committed r287451 (245586@main): <https://commits.webkit.org/245586@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 447991 [details].
Comment 8 Radar WebKit Bug Importer 2021-12-26 16:05:20 PST 
<rdar://problem/86923772>