Bug 149906 - DataView instances should not have own "byteLength" and "byteOffset" properties
Summary: DataView instances should not have own "byteLength" and "byteOffset" properties
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: JavaScriptCore (show other bugs)
Version: WebKit Nightly Build
Hardware: All All
: P2 Trivial
Assignee: Alexey Shvayka
URL:
Keywords: InRadar
Depends on: 149687
Blocks:
  Show dependency treegraph
 
Reported: 2015-10-07 17:00 PDT by Keith Miller
Modified: 2020-09-25 04:52 PDT (History)
9 users (show)

See Also:


Attachments
Patch (7.00 KB, patch)
2020-09-24 14:58 PDT, Alexey Shvayka
no flags Details | Formatted Diff | Diff
Patch (8.60 KB, patch)
2020-09-25 02:12 PDT, Alexey Shvayka
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Keith Miller 2015-10-07 17:00:35 PDT
According to the ECMA 6 spec DataView should use getters on the DataView.prototype for byteLength and byteOffset.
Comment 1 Alexey Shvayka 2020-09-24 14:58:43 PDT
Created attachment 409624 [details]
Patch
Comment 2 Ross Kirsling 2020-09-24 15:02:21 PDT
Comment on attachment 409624 [details]
Patch

Cool!
Comment 3 Alexey Shvayka 2020-09-24 15:06:25 PDT
(In reply to Keith Miller from comment #0)
> According to the ECMA 6 spec DataView should use getters on the
> DataView.prototype for byteLength and byteOffset.

The getters were added in r198435. This patch removes them as own properties.
Comment 4 Alexey Shvayka 2020-09-25 02:12:08 PDT
Created attachment 409670 [details]
Patch

Adjust inspector/model/remote-object/object.html expectations.
Comment 5 Alexey Shvayka 2020-09-25 04:39:11 PDT
Comment on attachment 409670 [details]
Patch

(In reply to Ross Kirsling from comment #2)
> Comment on attachment 409624 [details]
> Patch
> 
> Cool!

Thanks for review, Ross!
Comment 6 EWS 2020-09-25 04:51:38 PDT
Committed r267564: <https://trac.webkit.org/changeset/267564>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 409670 [details].
Comment 7 Radar WebKit Bug Importer 2020-09-25 04:52:16 PDT
<rdar://problem/69563463>