Bug 155625 - DataView should use an accessor for its length and buffer properties
Summary: DataView should use an accessor for its length and buffer properties
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Keith Miller
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2016-03-17 21:51 PDT by Keith Miller
Modified: 2020-09-24 15:06 PDT (History)
4 users (show)

See Also:


Attachments
Patch (15.74 KB, patch)
2016-03-17 21:58 PDT, Keith Miller
no flags Details | Formatted Diff | Diff
Benchmark results (67.16 KB, text/plain)
2016-03-18 10:11 PDT, Keith Miller
no flags Details
Patch for landing (15.73 KB, patch)
2016-03-18 10:42 PDT, Keith Miller
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Keith Miller 2016-03-17 21:51:37 PDT
DataView should use an accessor for its length and buffer properties
Comment 1 Keith Miller 2016-03-17 21:58:18 PDT
Created attachment 274370 [details]
Patch
Comment 2 Keith Miller 2016-03-18 10:11:05 PDT
Created attachment 274424 [details]
Benchmark results

Looks neutral
Comment 3 Michael Saboff 2016-03-18 10:30:22 PDT
Comment on attachment 274370 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=274370&action=review

r=me

> Source/JavaScriptCore/ChangeLog:12
> +        the object JSArrayBufferView no longer needs to intercept accesses to

add change "JSArrayBufferView no" to "JSArrayBufferView, it no"
Comment 4 Keith Miller 2016-03-18 10:42:08 PDT
Created attachment 274427 [details]
Patch for landing
Comment 5 WebKit Commit Bot 2016-03-18 11:42:58 PDT
Comment on attachment 274427 [details]
Patch for landing

Clearing flags on attachment: 274427

Committed r198435: <http://trac.webkit.org/changeset/198435>
Comment 6 WebKit Commit Bot 2016-03-18 11:43:03 PDT
All reviewed patches have been landed.  Closing bug.