Bug 149689 - [MSE] Browser crashes when appending invalid data to MSE source buffer
Summary: [MSE] Browser crashes when appending invalid data to MSE source buffer
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Jer Noble
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2015-09-30 17:40 PDT by Jer Noble
Modified: 2016-10-16 18:58 PDT (History)
3 users (show)

See Also:

Attachments
Patch (5.77 KB, patch)
2015-09-30 17:42 PDT, Jer Noble 		darin: review+
Details | Formatted Diff | Diff
Patch for landing (5.77 KB, patch)
2015-10-02 08:27 PDT, Jer Noble 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Jer Noble 2015-09-30 17:40:16 PDT 
[MSE] Browser crashes when appending valid data to MSE source buffer
Comment 1 Jer Noble 2015-09-30 17:40:56 PDT 
rdar://problem/22152214
Comment 2 Jer Noble 2015-09-30 17:42:48 PDT 
Created attachment 262215 [details]
Patch
Comment 3 Darin Adler 2015-09-30 21:28:16 PDT 
Comment on attachment 262215 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=262215&action=review

> Source/WebCore/Modules/mediasource/SourceBuffer.cpp:1025
> +    if (!segment.audioTracks.size() && !segment.videoTracks.size() && !segment.textTracks.size()) {

Would read nicer if you used isEmpty instead of !size.
Comment 4 Jer Noble 2015-10-02 08:27:38 PDT 
Created attachment 262332 [details]
Patch for landing
Comment 5 WebKit Commit Bot 2015-10-02 12:51:50 PDT 
Comment on attachment 262332 [details]
Patch for landing

Clearing flags on attachment: 262332

Committed r190516: <http://trac.webkit.org/changeset/190516>
Comment 6 Michael Catanzaro 2016-10-16 18:58:19 PDT 
It introduced two layout test failures for GTK, see bug #163515 (the new test is failing) and bug #163516 (broke preexisting test). Shame it took a year for us to notice.