Bug 149284 - Web Inspector: Add UI and settings management logic for SettingsTabContentView
Summary: Web Inspector: Add UI and settings management logic for SettingsTabContentView
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Web Inspector (show other bugs)
Version: WebKit Nightly Build
Hardware: All All
: P2 Normal
Assignee: Devin Rousso
URL:
Keywords: InRadar
Depends on:
Blocks: 149120 149261 149487
  Show dependency tree / graph
 
Reported: 2015-09-17 14:06 PDT by Matt Baker
Modified: 2017-01-13 14:09 PST (History)
6 users (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Matt Baker 2015-09-17 14:06:29 PDT 
* SUMMARY
Add UI and settings management logic for SettingsTabContentView. Some things we'll likely need:

- UI/CSS for setting groups (Text Editor, Console, etc), and setting items (toggle, radio/picker, nested settings)
- A manager class for persisting settings, dispatching settings change notifications, storing defaults
- A way to reset all settings to their defaults

* NOTES
This issue covers generic infrastructure only. The addition of specific settings will be tracked by separate issues as needed.
Comment 1 Radar WebKit Bug Importer 2015-09-17 14:06:46 PDT 
<rdar://problem/22745863>
Comment 2 BJ Burg 2017-01-12 15:11:12 PST 
What is left to do here? Aren't most settings saved as WI.Setting which has events already?
Comment 3 Devin Rousso 2017-01-12 20:49:32 PST 
(In reply to comment #2)
> What is left to do here? Aren't most settings saved as WI.Setting which has
> events already?

I think this bug was kept open because <https://webkit.org/b/149487> is still open and this bug blocks it.  This bug was really a META bug, but never marked as such.  Unless anyone has an issue, I think we can close it.
Comment 4 Matt Baker 2017-01-13 13:29:31 PST 
(In reply to comment #3)
> (In reply to comment #2)
> > What is left to do here? Aren't most settings saved as WI.Setting which has
> > events already?
> 
> I think this bug was kept open because <https://webkit.org/b/149487> is
> still open and this bug blocks it.  This bug was really a META bug, but
> never marked as such.  Unless anyone has an issue, I think we can close it.

Let's close it.