Bug 149261 - Web Inspector: The right sidebar always opens up on breakpoint
Summary: Web Inspector: The right sidebar always opens up on breakpoint
Alias: None
Product: WebKit
Classification: Unclassified
Component: Web Inspector (show other bugs)
Version: WebKit Local Build
Hardware: All All
: P2 Normal
Assignee: Devin Rousso
Keywords: InRadar
Depends on: 149284
  Show dependency treegraph
Reported: 2015-09-17 07:09 PDT by Nikita Vasilyev
Modified: 2015-09-22 18:30 PDT (History)
8 users (show)

See Also:

[Image] Current behavior (314.73 KB, image/png)
2015-09-17 07:09 PDT, Nikita Vasilyev
no flags Details
Patch (1.42 KB, patch)
2015-09-17 13:18 PDT, Devin Rousso
timothy: review+
joepeck: commit-queue-
Details | Formatted Diff | Diff
Patch (2.28 KB, patch)
2015-09-22 17:44 PDT, Devin Rousso
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Nikita Vasilyev 2015-09-17 07:09:16 PDT
Created attachment 261391 [details]
[Image] Current behavior

The right sidebar always opens up when paused on a breakpoint, taking a significant amount of my screen space. Even if I close it, it will open again on a next breakpoint.

When execution resumed, the sidebar still stays on, even if it's empty. At very least, we should close the sidebar when resuming execution and there are no watch expressions.

I don't think it needs to be open every time since it doesn't even provide essential debugger buttons, e.g. resume, step in, etc. Maybe we should remember if it was closed while paused on debugger and not open it again next time.
Comment 1 Radar WebKit Bug Importer 2015-09-17 07:09:31 PDT
Comment 2 Timothy Hatcher 2015-09-17 08:42:51 PDT
Matt was wanting to change this too.
Comment 3 Devin Rousso 2015-09-17 13:18:34 PDT
Created attachment 261413 [details]

This fixes the issue for me.  One quick question though: since I removed the only instance that showScopeChainDetailsSidebarPanel is ever called, should I also remove that function and its corresponding logic or leave it there in case it is needed again?
Comment 4 Joseph Pecoraro 2015-09-17 13:48:54 PDT
Comment on attachment 261413 [details]

cq- for now.

1. We think it would be good to add a Preference for this.
We should add a FIXME: <webkit.org/b/###> Web Inspector: Preference for Auto Showing Scope Chain sidebar on pause
2. This should remove the "showScopeChainDetailsSidebarPanel" parameter, it is no longer being used.
823:WebInspector.showDebuggerTab = function(breakpointToSelect, showScopeChainDetailsSidebarPanel)
Comment 5 Devin Rousso 2015-09-22 17:44:15 PDT
Created attachment 261785 [details]
Comment 6 WebKit Commit Bot 2015-09-22 18:29:55 PDT
Comment on attachment 261785 [details]

Clearing flags on attachment: 261785

Committed r190149: <http://trac.webkit.org/changeset/190149>
Comment 7 WebKit Commit Bot 2015-09-22 18:30:00 PDT
All reviewed patches have been landed.  Closing bug.