Bug 149261 – Web Inspector: The right sidebar always opens up on breakpoint

• Status: RESOLVED
• Resolution: FIXED
• Component: Web Inspector

[Nikita Vasilyev]

Created attachment 261391 [details]
[Image] Current behavior

The right sidebar always opens up when paused on a breakpoint, taking a significant amount of my screen space. Even if I close it, it will open again on a next breakpoint.

When execution resumed, the sidebar still stays on, even if it's empty. At very least, we should close the sidebar when resuming execution and there are no watch expressions.

I don't think it needs to be open every time since it doesn't even provide essential debugger buttons, e.g. resume, step in, etc. Maybe we should remember if it was closed while paused on debugger and not open it again next time.

[Radar WebKit Bug Importer]

<rdar://problem/22738337>

[Timothy Hatcher]

Matt was wanting to change this too.

[Devin Rousso]

Created attachment 261413 [details]
Patch

This fixes the issue for me.  One quick question though: since I removed the only instance that showScopeChainDetailsSidebarPanel is ever called, should I also remove that function and its corresponding logic or leave it there in case it is needed again?

[Joseph Pecoraro]

Comment on attachment 261413 [details]
Patch

cq- for now.

1. We think it would be good to add a Preference for this.
We should add a FIXME: <webkit.org/b/###> Web Inspector: Preference for Auto Showing Scope Chain sidebar on pause
2. This should remove the "showScopeChainDetailsSidebarPanel" parameter, it is no longer being used.
823:WebInspector.showDebuggerTab = function(breakpointToSelect, showScopeChainDetailsSidebarPanel)

[Devin Rousso]

Created attachment 261785 [details]
Patch

[WebKit Commit Bot]

Comment on attachment 261785 [details]
Patch

Clearing flags on attachment: 261785

Committed r190149: <http://trac.webkit.org/changeset/190149>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.