WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
149487
Web Inspector: Preference for Auto Showing Scope Chain sidebar on pause
https://bugs.webkit.org/show_bug.cgi?id=149487
Summary
Web Inspector: Preference for Auto Showing Scope Chain sidebar on pause
Devin Rousso
Reported
2015-09-22 17:41:11 PDT
Currently, the default is to only show the scope chain sidebar if it is already visible before the pause. This should be a setting to auto-open the sidebar on pause.
Attachments
Patch
(7.98 KB, patch)
2017-03-21 18:30 PDT
,
Devin Rousso
no flags
Details
Formatted Diff
Diff
[Image] After Patch is applied
(226.48 KB, image/png)
2017-03-21 18:31 PDT
,
Devin Rousso
no flags
Details
View All
Add attachment
proposed patch, testcase, etc.
Radar WebKit Bug Importer
Comment 1
2015-09-22 17:41:36 PDT
<
rdar://problem/22812421
>
Devin Rousso
Comment 2
2017-03-21 18:30:49 PDT
Created
attachment 305059
[details]
Patch
Devin Rousso
Comment 3
2017-03-21 18:31:13 PDT
Created
attachment 305060
[details]
[Image] After Patch is applied
Timothy Hatcher
Comment 4
2017-04-03 14:49:21 PDT
Comment on
attachment 305059
[details]
Patch View in context:
https://bugs.webkit.org/attachment.cgi?id=305059&action=review
> Source/WebInspectorUI/UserInterface/Views/SettingsTabContentView.js:214 > + valueControllerContainer.append(WebInspector.UIString("Show Scope Chain on pause"));
Show Scope Chain Details Sidebar on pause?
Devin Rousso
Comment 5
2017-04-03 14:59:20 PDT
Comment on
attachment 305059
[details]
Patch View in context:
https://bugs.webkit.org/attachment.cgi?id=305059&action=review
>> Source/WebInspectorUI/UserInterface/Views/SettingsTabContentView.js:214 >> + valueControllerContainer.append(WebInspector.UIString("Show Scope Chain on pause")); > > Show Scope Chain Details Sidebar on pause?
Personally I don't like the idea of putting "___ sidebar" in localized strings (it just seems redundant to me). Additionally, this makes the text quite long compared to the rest of the settings labels. I think "Scope Chain" is clear enough.
WebKit Commit Bot
Comment 6
2017-04-03 15:10:54 PDT
Comment on
attachment 305059
[details]
Patch Clearing flags on attachment: 305059 Committed
r214847
: <
http://trac.webkit.org/changeset/214847
>
WebKit Commit Bot
Comment 7
2017-04-03 15:10:56 PDT
All reviewed patches have been landed. Closing bug.
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug