Bug 149487 – Web Inspector: Preference for Auto Showing Scope Chain sidebar on pause

• Status: RESOLVED
• Resolution: FIXED
• Component: Web Inspector

[Devin Rousso]

Currently, the default is to only show the scope chain sidebar if it is already visible before the pause.  This should be a setting to auto-open the sidebar on pause.

[Radar WebKit Bug Importer]

<rdar://problem/22812421>

[Devin Rousso]

Created attachment 305059 [details]
Patch

[Devin Rousso]

Created attachment 305060 [details]
[Image] After Patch is applied

[Timothy Hatcher]

Comment on attachment 305059 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=305059&action=review

> Source/WebInspectorUI/UserInterface/Views/SettingsTabContentView.js:214
> +            valueControllerContainer.append(WebInspector.UIString("Show Scope Chain on pause"));

Show Scope Chain Details Sidebar on pause?

[Devin Rousso]

Comment on attachment 305059 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=305059&action=review

>> Source/WebInspectorUI/UserInterface/Views/SettingsTabContentView.js:214
>> +            valueControllerContainer.append(WebInspector.UIString("Show Scope Chain on pause"));
> 
> Show Scope Chain Details Sidebar on pause?

Personally I don't like the idea of putting "___ sidebar" in localized strings (it just seems redundant to me).  Additionally, this makes the text quite long compared to the rest of the settings labels.  I think "Scope Chain" is clear enough.

[WebKit Commit Bot]

Comment on attachment 305059 [details]
Patch

Clearing flags on attachment: 305059

Committed r214847: <http://trac.webkit.org/changeset/214847>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.